From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DCB2C437DD for ; Tue, 28 Jun 2022 19:02:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FAB368B996; Tue, 28 Jun 2022 22:02:51 +0300 (EEST) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BB1E68B74C for ; Tue, 28 Jun 2022 22:02:45 +0300 (EEST) Received: by mail-yb1-f181.google.com with SMTP id v38so13107921ybi.3 for ; Tue, 28 Jun 2022 12:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=xLBPpTxPzTmK+f/ue6zooq+2OUG20Nznaxldi92FVH0=; b=ko1QFbY1S82qD+iDaJyHYipwAHg+evWBevyQuhvIo7G7qNm5nRC7kpAYeYJn0qOhM0 IdBxkw05xmio+Zy6Bg4d2iFBqfAEal+xRtmA/W7xNEso0dNyKr7Z1/tlIWPwoIOCzaGi taJxxQmnIPCgPxlZvBXnAyz7JzScLnG4mfofUQ/WXvpj0fYpDSgtHdIMs6UQRinfQIBV ISa9Xdni62P2/AXBIgILUXt18SArO9ITfWLZ6BDBc+FvTjl6f2e5fQdHdbIGzkoW7w2P xEgQsWC9KzCK5tUWrvXuFuDdMFZC0djHg5OlZi2H2yZpE2u2GZjA/1qqZRXUB0VVv220 qiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=xLBPpTxPzTmK+f/ue6zooq+2OUG20Nznaxldi92FVH0=; b=JMBAR7CHbpieg4QvqXo8Gu7AVCrRcITohPkVrMogSBwjV1rXUnbZqi7qlpvdheIM2T eAt9NVZFZJdO8IwQzbiCJiIl9/rz3BIj7bQziuJ+AlieiYaLxo9ibZ9UK48BwmZfDU7Z oqM6F7TIDbNRzWRgfmm0suCL16PsaX3ZRI7YFazkG5Jv0zUPbT5h6npMwNd0anMuruzf l/uXn6vRMJdPDwGnj0utCufiZ0rmM/3TV0v7Qx/iLPCyOiuXGp5KaXeISpP/XR8YE5YW qz3ZNDN3RCIAnGrcMG2JAeoh5BuxVc/4hn+JDWnhOaJHnrtFwRVn+asGgx36Inf29uen LiPA== X-Gm-Message-State: AJIora97jCO9ExTrg4B70WEvvHhX2Awl+l+fEeEorIGlGdwOMJJisKv/ qY8iE2E8AyGxLtYVEOU1nypW1HYiYXgLJTEMmc9L3H6EEBY6hQ== X-Google-Smtp-Source: AGRyM1swucke39HXIT744l208xZ+bVFBQYSAyQovM/adYKgRvuseEhpUUWK4tzH30RCcXrtICOzKrB7VukJFxQTdEPQ= X-Received: by 2002:a25:5cc:0:b0:66c:eddc:de7d with SMTP id 195-20020a2505cc000000b0066ceddcde7dmr10387177ybf.461.1656442963606; Tue, 28 Jun 2022 12:02:43 -0700 (PDT) MIME-Version: 1.0 References: <20220628185620.2957852-1-vigneshv@google.com> In-Reply-To: <20220628185620.2957852-1-vigneshv@google.com> From: James Zern Date: Tue, 28 Jun 2022 12:02:32 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jun 28, 2022 at 11:56 AM Vignesh Venkatasubramanian wrote: > > Update the still AVIF parser to only read the primary item. With this > patch, AVIF still images with exif/icc/alpha channel will no longer > fail to parse. > > For example, this patch enables parsing of files in: > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > Adding two fate tests: > 1) demuxing of still image with 1 item - this test will pass regardlesss > of this patch. > 2) demuxing of still image with 2 items - this test will fail without > this patch and will pass with patch applied. > > Partially fixes trac ticket #7621 > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/isom.h | 1 + > libavformat/mov.c | 41 ++++++++++--------- > tests/fate/mov.mak | 13 ++++++ > .../fate/mov-avif-demux-still-image-1-item | 11 +++++ > .../mov-avif-demux-still-image-multiple-items | 11 +++++ > 5 files changed, 57 insertions(+), 20 deletions(-) > create mode 100644 tests/ref/fate/mov-avif-demux-still-image-1-item > create mode 100644 tests/ref/fate/mov-avif-demux-still-image-multiple-items > lgtm. I'll submit this soon if there aren't any comments. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".