Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

[James Zern <jzern-at-google.com@ffmpeg.org>]

On Tue, Jun 28, 2022 at 11:56 AM Vignesh Venkatasubramanian
<vigneshv-at-google.com@ffmpeg.org> wrote:
>
> Update the still AVIF parser to only read the primary item. With this
> patch, AVIF still images with exif/icc/alpha channel will no longer
> fail to parse.
>
> For example, this patch enables parsing of files in:
> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft
>
> Adding two fate tests:
> 1) demuxing of still image with 1 item - this test will pass regardlesss
>    of this patch.
> 2) demuxing of still image with 2 items - this test will fail without
>    this patch and will pass with patch applied.
>
> Partially fixes trac ticket #7621
>
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> ---
>  libavformat/isom.h                            |  1 +
>  libavformat/mov.c                             | 41 ++++++++++---------
>  tests/fate/mov.mak                            | 13 ++++++
>  .../fate/mov-avif-demux-still-image-1-item    | 11 +++++
>  .../mov-avif-demux-still-image-multiple-items | 11 +++++
>  5 files changed, 57 insertions(+), 20 deletions(-)
>  create mode 100644 tests/ref/fate/mov-avif-demux-still-image-1-item
>  create mode 100644 tests/ref/fate/mov-avif-demux-still-image-multiple-items
>

lgtm. I'll submit this soon if there aren't any comments.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".