From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DF23542FEA for ; Tue, 17 May 2022 19:42:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E989468810E; Tue, 17 May 2022 22:42:47 +0300 (EEST) Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 93EB368AD28 for ; Tue, 17 May 2022 22:42:41 +0300 (EEST) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2fee9fe48c2so2183277b3.3 for ; Tue, 17 May 2022 12:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1WqNNq/lG87r5kRqkVXi+BF8nOlRFxdaEFAezGEh1TM=; b=EtolEVYjKCxBoFn7J4g01v+5rFgwRYXOQeuhgSq4OZGJiuB/MSpqPzG6aPMclwu3EI MJBy20p/4mZSUk3kHv5p8lRFng84Mb21wmVY9pKCpHZ0hgebI2rQsc6mfLTDm+RxbzWK awdmpJxhz/NvkOxu4c1HVnHk128+OzdePzJEfIZzKwMpvLk4eCigvYtmoUXvZzXFMa9P CUG0LR+UqHpM701cZQFKi7szh33ugkd2jf5d9+0xvvXyTIWfdA1G65QziJZN/Cru8X4F YAif1LR8oxsgaQPoZOn3LYY61AOGPpflcdUP0Qh4wJn7LnuDl4UQvJGsMyKFV+gIJADT MfAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1WqNNq/lG87r5kRqkVXi+BF8nOlRFxdaEFAezGEh1TM=; b=ANjQ0CCrVtmkqq+G0QA1yIui7X/DEqQQDr7kj37rY8r/HXVbEkExCbv+dHAYs3RgMk c8JCOmOnQglUQ5mC0PiAWQ6oS2mdRsvWXOHva2xZEhGtNMvRcdI/LEVJC3GxHvRrJ68v gBfqfSFvF9tWL76nMwPt89F5qJheTy/ySaQFM4akj/zjY/vnpzAutrcZtK/Hd9DfOlkI o76xCoHScm8Bxt/NtCmUIlCRErVZU+iYeCH7w1wMtciq//Q5KLsDR62K04plmHAN2fF2 hF5AlJ15klYUOpzxKtUvMrJUUVcdqwt53me/AP18LsNJsnPvrHnGijrChrYtZSapy5L4 tvvg== X-Gm-Message-State: AOAM532wuRmOLkAWDiogN2BccqdKyyX1n7TY7FSSbCsWeUMi5D0per8q 5CDOunl3JBsla2nptoEygKrA+k4FWnLVLBUzcShWAo63ppRIwg== X-Google-Smtp-Source: ABdhPJxpmVqbLH1vxLyF/sAyRRvLBRI86HVe/AEbSdVFGIdvfl27iYqp9C4O5raxfyCQlCDvBpPWpUCEejkYBr5j/us= X-Received: by 2002:a81:ac1:0:b0:2ff:14f1:af3a with SMTP id 184-20020a810ac1000000b002ff14f1af3amr9109895ywk.247.1652816559766; Tue, 17 May 2022 12:42:39 -0700 (PDT) MIME-Version: 1.0 References: <20220517182439.545198-1-vigneshv@google.com> In-Reply-To: <20220517182439.545198-1-vigneshv@google.com> From: James Zern Date: Tue, 17 May 2022 12:42:29 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vignesh Venkatasubramanian Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, May 17, 2022 at 11:24 AM Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > images. Expose that in the ffmpeg's wrapper. This is especially > useful for encoding still AVIF images. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavcodec/libaomenc.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > lgtm. It seems this was never documented in encoders.texi: http://ffmpeg.org/ffmpeg-codecs.html#libaom_002dav1 > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 0411773bbf..7a601c120e 100644 > --- a/libavcodec/libaomenc.c > +++ b/libavcodec/libaomenc.c > @@ -1298,8 +1298,11 @@ static const AVOption options[] = { > { "enable-intrabc", "Enable intra block copy prediction mode", OFFSET(enable_intrabc), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE}, > { "enable-restoration", "Enable Loop Restoration filtering", OFFSET(enable_restoration), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE}, > { "usage", "Quality and compression efficiency vs speed trade-off", OFFSET(usage), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "usage"}, > - { "good", "Good quality", 0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"}, > - { "realtime", "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */}, 0, 0, VE, "usage"}, > + { "good", "Good quality", 0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"}, > + { "realtime", "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */}, 0, 0, VE, "usage"}, > +#ifdef AOM_USAGE_ALL_INTRA > + { "allintra", "All Intra encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 2 /* AOM_USAGE_ALL_INTRA */}, 0, 0, VE, "usage"}, > +#endif > { "tune", "The metric that the encoder tunes for. Automatically chosen by the encoder by default", OFFSET(tune), AV_OPT_TYPE_INT, {.i64 = -1}, -1, AOM_TUNE_SSIM, VE, "tune"}, > { "psnr", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_PSNR}, 0, 0, VE, "tune"}, > { "ssim", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_SSIM}, 0, 0, VE, "tune"}, > -- > 2.36.0.550.gb090851708-goog > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".