Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

[James Zern <jzern-at-google.com@ffmpeg.org>]

On Thu, Jul 13, 2023 at 12:38 PM James Zern <jzern@google.com> wrote:
>
> On Fri, Jul 7, 2023 at 2:31 PM David Lemler <david@lemler.family> wrote:
> >
> > Prevent the fifo used in encoding VPx videos from filling up and
> > stopping encode when it reaches 21845 items, which happens when the
> > video has more than that number of frames.
> >
> > Incorporated suggestion from James Zern to prevent calling
> > frame_data_submit() at all when performing the first pass of a 2-pass
> > encode so the fifo is not filled at all; replaces original patch which
> > drained the fifo after filling to prevent it from becoming full.
> >
> > Fixes the regression originally introduced in
> > 5bda4ec6c3cb6f286bb40dee4457c3c26e0f78cb
> >
> > Co-authored-by: James Zern <jzern@google.com>
> > Signed-off-by: David Lemler <david@lemler.family>
> > ---
> >  libavcodec/libvpxenc.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
>
> lgtm. I'll submit this soon if there aren't any further comments.
> Note the patch is corrupt, but easily fixed. In the future try to use
> git send-email or attach the output of git format-patch.

Applied. Thanks for the patch.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".