From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 48591440AF for ; Thu, 25 Aug 2022 17:34:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E823868B988; Thu, 25 Aug 2022 20:34:39 +0300 (EEST) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B38C68B8C9 for ; Thu, 25 Aug 2022 20:34:34 +0300 (EEST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-33dbbf69b3dso62293867b3.1 for ; Thu, 25 Aug 2022 10:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=dTXeD6l8Fz5ldZiMvrEm6mgBSG1i2HKVtWWCxP1mobo=; b=b2zW9HEVICJ98g9PH3OHGU3Gf9Ix9vSj+1+57C4mVOLCGPPvfaM/il3POt+oZpYnGQ CEpRP9d/lC9ZbzKVL2EcmkxFZeoBkdK9xSyZt37XOnqQ/Xmnl/K+pufRryFjz1ZcCVvS HfqYcKDTNdE88JdZrxRqErZWT0aFpFPEcPNhoCPFbObUHfThOMf0ENw1wdox6yiqpK5d hgI4WL/hFcB7g8MNKBK3Ll6eU741oAhSU7wsz/dKV3DOi9UHxDxo96o4WxTD58z5u6MW qUyngEDTiKrCSet9pUI4KOl6otgfiCeUJTyggBkuf2E/O4Or/fjX8dRz56RgIhAAqvQH u9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=dTXeD6l8Fz5ldZiMvrEm6mgBSG1i2HKVtWWCxP1mobo=; b=f9grNCEb3gfic4m4q7WriFJZKUCvmiBXRvxodzjPpIMm/Vs0WEQf74zXYv0GFHf7P1 oRu2n15N4iEpwRj9Q2bIwbhffoAe16qxifCiFhcmoFu8TKmTJ1aE1PVecKxH1tdF8cBi okmpQGVKYjhrV9B1RTo31SMJ1MehJSA054vOujdzA3iXPkt8BgaQAQYvV4CAiinPCH4Q 4Eq/owE80WX6KCajAUkzK065zIbqv/RNgF9+cez+uGP/7ag5Ttyi/tu3CbFiBq3NvBs5 OlRpnb6dml4/3vQ/reyyZh7uLVJfwJXQMZjvfd1A1JMGp9UT5OO/+3fQP2Q9MKmtJ3RN B3ew== X-Gm-Message-State: ACgBeo1NL6bBWyc1w20A8H0D6ZqEaFbmCpC5Y4ulbHnZ9CPhi0qaU+p0 UkVsPmXBZN2hXnOe5vcvxKekzupKlPUOP2b7GbnbXXKNmkE= X-Google-Smtp-Source: AA6agR7J6marq16/49dFxMxKp1pRKwJifatkZKvq/rs+LInF2NnyUmgrzvNqqdfk14Sv4Ty2Huzu67i50XZoKtnA1YM= X-Received: by 2002:a81:5a82:0:b0:339:eab:f018 with SMTP id o124-20020a815a82000000b003390eabf018mr5077632ywb.313.1661448870615; Thu, 25 Aug 2022 10:34:30 -0700 (PDT) MIME-Version: 1.0 References: <20220825171618.1264-1-jamrial@gmail.com> In-Reply-To: <20220825171618.1264-1-jamrial@gmail.com> From: James Zern Date: Thu, 25 Aug 2022 10:34:19 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > > Signed-off-by: James Almer > --- > There doesn't seem to be any proper API to check if an encoder is open. > true. > libavcodec/libaomenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > lgtm. > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 485f554165..fb9a6ff8b2 100644 > --- a/libavcodec/libaomenc.c > +++ b/libavcodec/libaomenc.c > @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx) > #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \ > defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \ > defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX) > - if (!(avctx->flags & AV_CODEC_FLAG_PASS1)) { > + if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) { This check is fine, though the codec control call should fail if iface is null. > int num_operating_points; > int levels[32]; > int target_levels[32]; > @@ -1544,6 +1544,7 @@ FFCodec ff_libaom_av1_encoder = { > FF_CODEC_ENCODE_CB(aom_encode), > .close = aom_free, > .caps_internal = FF_CODEC_CAP_NOT_INIT_THREADSAFE | > + FF_CODEC_CAP_INIT_CLEANUP | > FF_CODEC_CAP_AUTO_THREADS, > .defaults = defaults, > .init_static_data = av1_init_static, > -- > 2.37.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".