From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F5C840BD8 for ; Thu, 24 Mar 2022 18:27:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C205768B178; Thu, 24 Mar 2022 20:27:39 +0200 (EET) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4C94968A545 for ; Thu, 24 Mar 2022 20:27:33 +0200 (EET) Received: by mail-yb1-f180.google.com with SMTP id e203so1117420ybc.12 for ; Thu, 24 Mar 2022 11:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3b6TKAhc8lzmcZ3VpmyMqy098uUhyr7qwN6XUV3nPXM=; b=pDT6MtE8vuTv1F2QJHkWPHftyB237g/IA/x9szZ5+j/cXD0FJnM9KgouW5z+3KLv8v sQZDUYAWS9POkthiUIJiRCfxyG8cutoly99k9l1ObwbguHUQim5BAbxtyLVdrHRZ1qV/ m+/UJH9OupdjYuqFr03UylPw6HnQP2L4ASCIPBB8oUi8Kkwzd7xCpiH5DGpAyzFH+CCM aQRp8kMMmKjQrcpgvtc2G51s2r2Zm2A82V2RKGkMKGC+XrRKIeXdcxVVVfKWRT27tygL OVV/vfRX3Gwd/Cl2Wi0dkwNPhF659+Dr83r/Z8Q0R/XxKIWGiZkAraAKIxoo9lDV1ww5 bUxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3b6TKAhc8lzmcZ3VpmyMqy098uUhyr7qwN6XUV3nPXM=; b=r2R/ZYdh1yU4VPcKT9yMgSNV5aVmgXNAQZnsPEvtU3JxnwiPe1jDkoVpq5/y+GPzDy Sp4o3C6nlTP53DznnrjGeKTwJVOrbMKy+nZD3U3evA2NQILVG2W43K1hduzeOvNFMWHn XEj1CI+2kHF4y1z9Vl72pXD0fVYyWC2vluhnUxeUzM0bJEo7y0M5xwsWW8KONQaGfG0+ wy5DGC3mbPVteibez4DBZIcFsBVe+6+lsGJ4tkPQV5rVCCm/on5urZKJ1J8ec37RYkjz uFemgJTUQajUOYU4fW1HlGc0rjSj9WarMymnTsJWWIK4S/TeFsFLqwLxl+wxt/kSH275 qx3A== X-Gm-Message-State: AOAM531C85Qmp8EMvky/Rh330CjCZQa6W7eQgSCxfR44AqP/sZ6evd+9 Ur7NeP2TpsF3AQmIchRfDACBazI/1dHMRk0AgY7Rs8m2XO+tKw== X-Google-Smtp-Source: ABdhPJzUDxgpaIsx8pTf6SA6TPduYiBJwTlvCnXMnfdsiIFuSRnS4icslUiFgtEhL6ce7Sk1tWU6L3Y2/NHK7xBqZXg= X-Received: by 2002:a05:6902:110a:b0:638:ee4e:9347 with SMTP id o10-20020a056902110a00b00638ee4e9347mr2647387ybu.346.1648146451498; Thu, 24 Mar 2022 11:27:31 -0700 (PDT) MIME-Version: 1.0 References: <20220316120759.2292546-1-danilchap@google.com> <20220324131116.825587-1-danilchap@google.com> In-Reply-To: <20220324131116.825587-1-danilchap@google.com> From: James Zern Date: Thu, 24 Mar 2022 11:27:20 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Danil Chapovalov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Mar 24, 2022 at 6:12 AM Danil Chapovalov wrote: > > --- > libavcodec/libvpxenc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index dff1d06b0e..463a658bb0 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -1625,6 +1625,12 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, > vpx_svc_layer_id_t layer_id; > int layer_id_valid = 0; > > + if (avctx->qmax >= 0 && enccfg->rc_max_quantizer != avctx->qmax) { > + struct vpx_codec_enc_cfg cfg = *enccfg; > + cfg.rc_max_quantizer = avctx->qmax; > + vpx_codec_enc_config_set(&ctx->encoder, &cfg); > + } > + Jan, I think this was what you were suggesting, no? The docs could be updated to note qmax can be changed per-frame [1][2]. Saying that, it does seem a bit unbalanced to only do qmax here. [1] https://ffmpeg.org/ffmpeg-codecs.html#libvpx [2] https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/doc/encoders.texi#l2000 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".