From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 35B04408A1 for ; Wed, 30 Nov 2022 20:19:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C465468B48D; Wed, 30 Nov 2022 22:19:08 +0200 (EET) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15DB96807B4 for ; Wed, 30 Nov 2022 22:19:03 +0200 (EET) Received: by mail-ej1-f54.google.com with SMTP id ud5so44072955ejc.4 for ; Wed, 30 Nov 2022 12:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8fro5g2D4TPVhencMAz8nbjot2G/sWjEGumVS6qrWYs=; b=UJDW7RqRuWtXz/tYQ4iWgFJKw3hwqpIkgYM8K7kKhT8dbuyjL2QqiLOb0EF+MEA3OE 31YOtduqLUoNPsCiHHKtjBtTUbuKm44lx2YbY2FrqPq84h+HHplDti1NEXT5fKDMNgBG JRdNtZsIp2e2ebqa2JErOO1KJx/f6hsykeD0sWWENfh63ShQ+oj+Q6MpbaO2bx5lnfZK 7k9mhi8kHvdcY5cTM6hxOlJbGizgJLv1xBUOdfXd1yfMSAFtfVxrRSqkKgya6LvquXXL GKuwgppgQtd3CuUKIDVSX/9AJpowi57rVdUMISJtDpLltIL33l5GCWrt39CUQ38XGRWy Rwug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8fro5g2D4TPVhencMAz8nbjot2G/sWjEGumVS6qrWYs=; b=3upl4tzHZUWygfYjmkdmYoL6ufGX4KNH7vNNSRipBr7YwDXsHvgv1rzznrG5AXALDj SwRgpTidE8OBwiFtMPA2RO7NlmStRa5TZMdfndTNAfeC9FYUOnkKsLq9odnGKY1f3+k1 8BWKLxVrbXXmh0/2pkYjYpLVaJqpg7vyvRknt0dALt8Eyk2B1n6qg1Ho7kqtSOc1/5zV KN1VObbSiw5Q2mWakB4yezHAnhsm5ZfDxmmwp+Jdo5wB8DtaaYQ1o8hgYC391dYKwP1G v5ovGzK56mNvb8R76d4qI0gLkWwFq/AdyGWpSs4d0fZxxkGVoPwI+EN7/M5YPQ/zWVba p+SQ== X-Gm-Message-State: ANoB5plvZPo7UfKMSWiIngR6Lbvo6gqrgRrImwqkE7gikb5G/JtmRACS GphmpLHsIhOH/i2izURC4Xvu7ODXV9XWGgVL/Qgdq4rTKR8= X-Google-Smtp-Source: AA0mqf40sUurDXJiIY4+Lw/o41MbkHrlDEwRi2nxV2Qa3Y9CXKSOMI5OyOXMmBkwYYiDSA45fab/ykCoizhMZyZa6KA= X-Received: by 2002:a17:906:fcc2:b0:78d:8b75:b161 with SMTP id qx2-20020a170906fcc200b0078d8b75b161mr55541761ejb.385.1669839540792; Wed, 30 Nov 2022 12:19:00 -0800 (PST) MIME-Version: 1.0 References: <20221125013046.40904-1-epirat07@gmail.com> <20221126144648.73162-1-epirat07@gmail.com> <20221126144648.73162-6-epirat07@gmail.com> In-Reply-To: <20221126144648.73162-6-epirat07@gmail.com> From: James Zern Date: Wed, 30 Nov 2022 12:18:47 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 05/31] avcodec/libvpxenc: use av_dict_iterate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marvin Scholz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Nov 26, 2022 at 6:47 AM Marvin Scholz wrote: > > --- > libavcodec/libvpxenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm. > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 667cffc200..9aa5510c28 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -900,7 +900,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, > vpx_codec_caps_t codec_caps = vpx_codec_get_caps(iface); > vpx_svc_extra_cfg_t svc_params; > #endif > - AVDictionaryEntry* en = NULL; > + const AVDictionaryEntry* en = NULL; > > av_log(avctx, AV_LOG_INFO, "%s\n", vpx_codec_version_str()); > av_log(avctx, AV_LOG_VERBOSE, "%s\n", vpx_codec_build_config()); > @@ -1072,7 +1072,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, > > enccfg.g_error_resilient = ctx->error_resilient || ctx->flags & VP8F_ERROR_RESILIENT; > > - while ((en = av_dict_get(ctx->vpx_ts_parameters, "", en, AV_DICT_IGNORE_SUFFIX))) { > + while ((en = av_dict_iterate(ctx->vpx_ts_parameters, en))) { > if (vpx_ts_param_parse(ctx, &enccfg, en->key, en->value, avctx->codec_id) < 0) > av_log(avctx, AV_LOG_WARNING, > "Error parsing option '%s = %s'.\n", > -- > 2.37.0 (Apple Git-136) > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".