From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E2F9440C0 for ; Thu, 25 Aug 2022 19:32:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E49BE68B981; Thu, 25 Aug 2022 22:32:20 +0300 (EEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4DEC568B5CD for ; Thu, 25 Aug 2022 22:32:14 +0300 (EEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-324ec5a9e97so567074077b3.7 for ; Thu, 25 Aug 2022 12:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=dsmc/ivxaOOVNSC3vsE62GDDZtuixIIKHwS7sWhC9tY=; b=H/6dv2/8EQuP9wMHc98/SLbTGmiyqM6F0Kxh6qTTuUzlL3hVo0EWNEnddEZDjuwTiZ 3Cbvva6tNHR/dXXNKBv6QTKhY8Tz33SJfn23f8SLHQbDpxik+9MXQDUcaF/kxEFbPSFy dOJhMrzNbBuws3P2Lk1i8/2nX0aP56CLPIqHl2z/rqL2yhp8wJe7s2SeLVdRmJPdWrEI l3P2OuyUzgXDc+P4K4ANMh38GhKxnb+D78y0NXyMN3NHblEP0BruATgmHTrAeRvl/sAB n54JQVgRYeY1X/ZNNfnKAmC/x70KzqiqVUjhoomM0Mromh4h6YAR5qY9tMmYyVQKaRlj BkIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=dsmc/ivxaOOVNSC3vsE62GDDZtuixIIKHwS7sWhC9tY=; b=KcR6k6sLHymbhOxeIZ84ipxTd3g5cmTr193FW18eX2tPXTg4Cgc4zAlTpgY3y/b2s2 PpoBMo9xwWOkBPfkX1xk7eGvXuHCUaC2MQwT56A1mVtDO017Rl6iFaUxYMMnSRf58/Bf kDYwKE/h1YvE6uILi8RkCMrnRvbYPTfmuhOMeMu0ribi8Fadp6HjSYsCmML4z6kNxmL3 S3lEPjx2TsY0/6WwoyX+PzSzNjDM2YxNGyhzLxAsxcu1kXk1HJnBhd3McpaYOdvcporA XUEXXxgpb5kDpfxgTryKl4CJ6MSQJ9yjHUMOidE74/Cm+hxQtow3dd9P4VJ/1dzPx44p tBoA== X-Gm-Message-State: ACgBeo0AfSRbrvG2SaWg5kRvEYH6ega9/sGH/lZ9GyxeG6fDi1DtIyK8 S/uH8HzkWg13e4RsJgu1zLW8fJNOR+yK1h1ei0HQsDXRPLo= X-Google-Smtp-Source: AA6agR75gkXovhsodxev+pbYzkwpNx4h+EHNVhub8VA4nYsEnrJgpk6qH+ia5rCpOtJ4I7tZrf5ClNYG+diPC2aJYOQ= X-Received: by 2002:a25:d85:0:b0:695:b3ce:915c with SMTP id 127-20020a250d85000000b00695b3ce915cmr4694792ybn.334.1661455932418; Thu, 25 Aug 2022 12:32:12 -0700 (PDT) MIME-Version: 1.0 References: <20220825171618.1264-1-jamrial@gmail.com> <11620435-fb87-7dba-f761-411bb0bb683b@gmail.com> In-Reply-To: From: James Zern Date: Thu, 25 Aug 2022 12:32:01 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Aug 25, 2022 at 12:28 PM James Almer wrote: > > On 8/25/2022 4:21 PM, James Zern wrote: > > On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote: > >> > >> On 8/25/2022 2:34 PM, James Zern wrote: > >>> On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > >>>> > >>>> Signed-off-by: James Almer > >>>> --- > >>>> There doesn't seem to be any proper API to check if an encoder is open. > >>>> > >>> > >>> true. > >>> > >>>> libavcodec/libaomenc.c | 3 ++- > >>>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>>> > >>> > >>> lgtm. > >> > >> Will apply, thanks. > >> > >>> > >>>> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > >>>> index 485f554165..fb9a6ff8b2 100644 > >>>> --- a/libavcodec/libaomenc.c > >>>> +++ b/libavcodec/libaomenc.c > >>>> @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx) > >>>> #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \ > >>>> defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \ > >>>> defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX) > >>>> - if (!(avctx->flags & AV_CODEC_FLAG_PASS1)) { > >>>> + if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) { > > > > I missed this, it should be 'ctx->encoder.iface'. > > Huh. When were those three defines above added? Guess they are not in > any tagged release? > > Fixed in any case. Thanks. > Thanks, you beat me to it. You're right, they're not in a tagged release yet. 3.5.0 will have them. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".