Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

[James Zern <jzern-at-google.com@ffmpeg.org>]

On Thu, Aug 25, 2022 at 12:28 PM James Almer <jamrial@gmail.com> wrote:
>
> On 8/25/2022 4:21 PM, James Zern wrote:
> > On Thu, Aug 25, 2022 at 10:39 AM James Almer <jamrial@gmail.com> wrote:
> >>
> >> On 8/25/2022 2:34 PM, James Zern wrote:
> >>> On Thu, Aug 25, 2022 at 10:16 AM James Almer <jamrial@gmail.com> wrote:
> >>>>
> >>>> Signed-off-by: James Almer <jamrial@gmail.com>
> >>>> ---
> >>>> There doesn't seem to be any proper API to check if an encoder is open.
> >>>>
> >>>
> >>> true.
> >>>
> >>>>    libavcodec/libaomenc.c | 3 ++-
> >>>>    1 file changed, 2 insertions(+), 1 deletion(-)
> >>>>
> >>>
> >>> lgtm.
> >>
> >> Will apply, thanks.
> >>
> >>>
> >>>> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
> >>>> index 485f554165..fb9a6ff8b2 100644
> >>>> --- a/libavcodec/libaomenc.c
> >>>> +++ b/libavcodec/libaomenc.c
> >>>> @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx)
> >>>>    #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \
> >>>>        defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \
> >>>>        defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX)
> >>>> -    if (!(avctx->flags & AV_CODEC_FLAG_PASS1)) {
> >>>> +    if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) {
> >
> > I missed this, it should be 'ctx->encoder.iface'.
>
> Huh. When were those three defines above added? Guess they are not in
> any tagged release?
>
> Fixed in any case. Thanks.
>

Thanks, you beat me to it. You're right, they're not in a tagged
release yet. 3.5.0 will have them.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".