From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6247F43754 for ; Mon, 27 Jun 2022 19:47:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7B4C68B8D6; Mon, 27 Jun 2022 22:46:59 +0300 (EEST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AE8768B8BA for ; Mon, 27 Jun 2022 22:46:53 +0300 (EEST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-3178acf2a92so95959337b3.6 for ; Mon, 27 Jun 2022 12:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=MApOMdw0+Rnpa+rvW3ReBc5HuGaSyqx1jFzKptxH21A=; b=K2MfTuueKOFKBHubRw2xafpt5fjbaVjjkvFTWm5G3l7Wdaj3Xa2ZgEGk8Cgxz+i139 KSMEgOjbqksJbJtJgcfEbGE1wHuh9JcRA+p03Zco/vsREE2eDvjqQWie4NBU7VZKUdbB i9qcLS3QaiertOCl2VuiokzEh0LJV1CuCP0ETrnP/w7Fffce8HOiY0kM0yO992CTg/ot imSVDDxulu3X2vmpZ275syFKRw08JlOK1cQzgp16g3t72derCoqBx/Ws9ZUSqn4Uo/R/ OWHCWv+wqcdRY212ApRloYm+f0TiMBM0yhF12at53KApGylzGR6SWyFxrup1RfKPoLbM HR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=MApOMdw0+Rnpa+rvW3ReBc5HuGaSyqx1jFzKptxH21A=; b=vn3lIPZFd1QnmMxi7glzxfROBJyEZCqE3w/IDLs6ikhsS0JlCMhzK+DUrAoB81FPn4 rKavhcvMwJAnscGbtkf0iwnDDfBBYoAhuWdZWdzGiP976cB0K1nwqvBtTKvxM8XyTTfd LYdY/VhWUIrjXENHit4EmP8uV7Oj6sk/jElIWvs363aLkPEhTU1SaUB7OlgR5qg8QVio Tk5sNj2EEPfVU8g8Mvuk++4rxwUQOKY3MteZSchrcr1t0tk37YqzL/DMHYA9Fr78DJsJ VEgfyXMUXtAmESgPixDKOr8cOXvK/DRfL16gUcGbfQtuURXFKDPN4myJLCgK5ILAAW1P 2X5g== X-Gm-Message-State: AJIora+nMGROU66q+8WUD9a7d6QyVJisUDc/KhQwKdPjFE0xT8VgbUR4 /C2OmmWNct5jaLplmhx7bTQe+DjZMR+8qqSpeqGd1upS9T3KDQ== X-Google-Smtp-Source: AGRyM1vVizH7gyUDsncMhspkZ+X+tRsA03MJw3GzTKKpfq7AFSq6LlQ/rX0CW1rGt40i1AhPd70sCnvoEJrqsG8a4Q0= X-Received: by 2002:a81:7c54:0:b0:317:d4a4:daf0 with SMTP id x81-20020a817c54000000b00317d4a4daf0mr16054398ywc.247.1656359211682; Mon, 27 Jun 2022 12:46:51 -0700 (PDT) MIME-Version: 1.0 References: <20220601180556.949526-1-vigneshv@google.com> In-Reply-To: From: James Zern Date: Mon, 27 Jun 2022 12:46:40 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jun 27, 2022 at 9:48 AM James Almer wrote: > > On 6/27/2022 1:43 PM, Vignesh Venkatasubramanian wrote: > > On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian > > wrote: > >> > >> On Mon, Jun 13, 2022 at 10:17 AM James Zern > >> wrote: > >>> > >>> On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian > >>> wrote: > >>>> > >>>> AVIF specification allows for alpha channel as an auxiliary item (in > >>>> case of still images) or as an auxiliary track (in case of animated > >>>> images). Add support for both of these. The AVIF muxer will take > >>>> exactly two streams (when alpha is present) as input (first one being > >>>> the YUV planes and the second one being the alpha plane). > >>>> > >>>> The input has to come from two different images (one of it color and > >>>> the other one being alpha), or it can come from a single file > >>>> source with the alpha channel extracted using the "alphaextract" > >>>> filter. > >>>> > >>>> Example using alphaextract: > >>>> ffmpeg -i rgba.png -filter_complex "[0:v]alphaextract[a]" -map 0 -map "[a]" -still-picture 1 avif_with_alpha.avif > >>>> > >>>> Example using two sources (first source can be in any pixel format and > >>>> the second source has to be in monochrome grey pixel format): > >>>> ffmpeg -i color.avif -i grey.avif -map 0 -map 1 -c copy avif_with_alpha.avif > >>>> > >>>> The generated files pass the compliance checks in Compliance Warden: > >>>> https://github.com/gpac/ComplianceWarden > >>>> > >>>> libavif (the reference avif library) is able to decode the files > >>>> generated using this patch. > >>>> > >>>> They also play back properly (with transparent background) in: > >>>> 1) Chrome > >>>> 2) Firefox (only still AVIF, no animation support) > >>>> > >>>> Signed-off-by: Vignesh Venkatasubramanian > >>>> --- > >>>> libavformat/movenc.c | 188 +++++++++++++++++++++++++++++-------------- > >>>> libavformat/movenc.h | 4 +- > >>>> 2 files changed, 130 insertions(+), 62 deletions(-) > >>>> > >>> > >>> lgtm. > >>> _______________________________________________ > >>> ffmpeg-devel mailing list > >>> ffmpeg-devel@ffmpeg.org > >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >>> > >>> To unsubscribe, visit link above, or email > >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > >> Any more comments on this? If not can this be merged please? :) > >> > > > > Another ping on this please. > > > >> -- > >> Vignesh > > I thought James Zern had push access, which is why i didn't apply it as > soon as he reviewed it. Sorry. > > Pushed it now. > Sorry for the confusion James. I held off because I'm not a maintainer of this file, so I wanted to make sure there was another reviewer. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".