Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option - James Zern via ffmpeg-devel

From: James Zern via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "James Zern" <jzern@google.com>,
	"Dariusz Marcinkiewicz" <darekm@google.com>,
	"Erik Språng" <sprang@webrtc.org>
Subject: Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option
Date: Tue, 13 Feb 2024 19:26:49 -0800
Message-ID: <CABWgkX+_7071L19Zqn_H_-JSU-hBdJW8JWC8nw3nW1o-LBrbag@mail.gmail.com> (raw)
In-Reply-To: <20240213063409.2167597-1-darekm@google.com>

On Mon, Feb 12, 2024 at 10:34 PM Dariusz Marcinkiewicz via
ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
> This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx.
>
> Co-authored-by: Erik Språng <sprang@webrtc.org>
> Signed-off-by: Dariusz Marcinkiewicz <darekm@google.com>
> ---
>  doc/encoders.texi      |  6 ++++++
>  libavcodec/libvpxenc.c | 13 +++++++++++++
>  libavcodec/version.h   |  2 +-
>  3 files changed, 20 insertions(+), 1 deletion(-)
>

lgtm. I'll submit this soon if there are no other comments.

> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index c9fe6d6143..13a7084512 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -2237,6 +2237,12 @@ the two temporal layer 2 frames within the temporal period.
>  @end table
>  @end table
>
> +@item VP8-specific options
> +@table @option
> +@item screen-content-mode
> +Screen content mode, one of: (0) off, (1) screen, (2) screen with more aggressive rate control.

I swapped the ()s: 0 (off) ...
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".