From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5183344D74 for ; Mon, 21 Nov 2022 17:34:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3178568B43E; Mon, 21 Nov 2022 19:34:29 +0200 (EET) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D0A4068AFEB for ; Mon, 21 Nov 2022 19:34:22 +0200 (EET) Received: by mail-lj1-f178.google.com with SMTP id s24so15242887ljs.11 for ; Mon, 21 Nov 2022 09:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=wH8A7brPP6mk7YzVuJ9DYm4hx6VL4uVzSoiUu6dn/yM=; b=F3RW2Vxl4G6VGhM6MXEi7ghIYS1AbtiEOS/hMwi3ye007rJ73VVc+ljg/u7IUtv/Fq 0EbQWsYvLGnUvF0sQ0fizZonhRj3AYRnkQy2w262qN48wLxvPZYYD+DT/YJFX4RNznRP /SoXIFOFPjVkTP86L8UUVfX/00dUC7SwRFt76X868q/2QCdgh/XBajQ/uq/rJIkG1OwF peidZundZM6bsR8IszrUF5xtZHp58pKrvODDXcPCQmZy/+JTfTTGe/rINp8eibaXhqS/ JQHoTs2BzT1K4xpjewgcNbJ7bCpWBQJp99vAM6G1OE+uOzYSu8PZDV6jUXQoBpWWgAES BkdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wH8A7brPP6mk7YzVuJ9DYm4hx6VL4uVzSoiUu6dn/yM=; b=zZEo3cJF+62+6y927DT0fSgpZRjq3T1RT9ptScbUkyom8evH5CdH3UGb/Ae1YW4Get h5/pGldeUsle5YBtT8rZm9PTLB6jgYd3UNl6WDvXjg+4rLrxIpF8XxYoAvAhp+XhFYDJ MJV0Z/PERfgEXXLW5wxJWB3FeURnlhpUrp2IQwShIIpZpuC/6r8TgigcpknR1bwlu33m 89gZtjLoEst6WCDEmM3QxLSieJI0S0m+snjsDlbug3CXwEFi0hjXpINMzixEFssTZCGF M0W4Uv+1LCTFUzdZt2oRpyNHoJnO1gRdcXJAwDCzXu3zAzGhpVFZs1iYzV2dD5sSURyw 3fgQ== X-Gm-Message-State: ANoB5pmYIcck7Qq9IHLx7SOGikKTIFPWV2agbcOcd6yePM1IRZqpmcEE 8diDt2atLzpvqlazFA38FNdg9tALE1I3/e6kMwdgVs1BZQQ= X-Google-Smtp-Source: AA0mqf7ZrGguwTeiuNKrzmtCsxFyMcEdOostp4PQs4QuOc36SF6F3EUmxBZMUVrWs8R5fv5g2H9OA4+QXfDFvIFeqxs= X-Received: by 2002:a2e:2ac2:0:b0:26d:d55f:f1cf with SMTP id q185-20020a2e2ac2000000b0026dd55ff1cfmr5749648ljq.175.1669052061334; Mon, 21 Nov 2022 09:34:21 -0800 (PST) MIME-Version: 1.0 References: <20221006134959.771-1-ovchinnikov.dmitrii@gmail.com> In-Reply-To: From: James Zern Date: Mon, 21 Nov 2022 09:34:09 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Oct 25, 2022 at 8:56 AM Dmitrii Ovchinnikov wrote: > > >> Why do you still impose an upper limit unconditionally even if the > >>user has set his preferred number of threads? > Libvpx-vp9 does not support number of threads greater than 64, so we impose > an upper limit of 64. > E.g. if we set it any higher we get the following execution error: > [libvpx-vp9 @ 0x2f631c0] Failed to initialize encoder: Invalid parameter > [libvpx-vp9 @ 0x2f631c0] Additional information: g_threads out of range > [..64] > Error initializing output stream 0:0 -- Error while opening encoder for > output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, > width or height > Deferring the check to libvpx should be fine and would mean less maintenance of this wrapper if there are any changes made there. > >>According to > https://ffmpeg.org/pipermail/ffmpeg-devel/2018-November/236406.html the > >>maximum of 16 has not been chosen because of H.264, but because there > >>was some form of restriction in libvpx. Or at least there was belief in > >>the existence of such a restriction. > There is a restriction of maximum 64 threads, not 16. > > >>This code potentially calls av_cpu_count() twice. > Can you please clarify how it calls it twice? Thanks. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".