From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B60AD424AD for ; Wed, 16 Mar 2022 23:53:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 910E768B06C; Thu, 17 Mar 2022 01:53:34 +0200 (EET) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A70C368A7B8 for ; Thu, 17 Mar 2022 01:53:27 +0200 (EET) Received: by mail-yb1-f181.google.com with SMTP id l2so7313208ybe.8 for ; Wed, 16 Mar 2022 16:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=v5MVJ+q0tkqlCDzEpksFd4AQG9vAExJoZDQl4sJviZ8=; b=oO608wdWB3+7eIEI/a6LkkqXHMBcjHHVd/0CkYQLOm3NGBF8+yHwyCSAXW5X7P5dDF tNcagOaBh4eudBVyaz0p91BBf8tm9fcSplr8o3dfF0PkocyuWIaXQ8PjwOMtXmpjI5a+ dhVpr/UTO7liRrSPLb2GtzLVupTzpPL9agEIs4/Jyk8Y25kwJIVqRKKgGVSJzZAAJt7k h7SxWJYcYD8E5RJ/FeK0KGixUBfWJf/mW35/0TwpgYAtDC2MV8Vfj9Ezf/tX9hB0Ojar oAPFxPricu2zpm0rvemkDF+ksXZIGa9udKVkyRfXtQ+YejdnI+gkHem+i5zdChsbG6e+ mkqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=v5MVJ+q0tkqlCDzEpksFd4AQG9vAExJoZDQl4sJviZ8=; b=r3Q8GgNXL4AM7bsPse/F6KdqAyyCslHvDQmsDp4eNyRqJafckVua5/8mPCDvyKkuqT sfR0YLTB6d83prqlQUtVkrY5Hj3YAsUkFEDhFQII9J78AuKoN4aplVu9rAdnlv/xhfxj qbiPGO+pHEvPINSUbBygFBGcDGy+4kYd4DV6u5wEelRWrMDEjEMYtrhXRgI2NJqujKiJ DZe2MinV4v4eKvEjrCbF1xUUUUhjC931gxpKdVeuhKhxBHkd3AoEseo11Yyr5OJApXGk 09TVmMtpn1tpu1hGqOqyzN/5+3+FiTKb1qmgt8bvspHH5bqVqrmCEAIy+iJEbGnm8V9r 5CFw== X-Gm-Message-State: AOAM5324EQhO5/gE0I6OjXH4io/7v2vFZn/q0NeQOptkLkVcITne433f pIkCE2hW2A8gW7Ei/2hVa47rSOMK+/ylRku4ciIb1mmF9hI= X-Google-Smtp-Source: ABdhPJxT+SQ6//m59mhfZYRdWGQ/P/lXIxfS7Vi1PS2HUnfLXa6Z4HUKM8sO8cTEgakabkcL8KlAAKCzfn4btANrgX0= X-Received: by 2002:a25:3c86:0:b0:633:1cff:2bb1 with SMTP id j128-20020a253c86000000b006331cff2bb1mr2653690yba.334.1647474805348; Wed, 16 Mar 2022 16:53:25 -0700 (PDT) MIME-Version: 1.0 References: <20220316120759.2292546-1-danilchap@google.com> In-Reply-To: From: James Zern Date: Wed, 16 Mar 2022 16:53:14 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne, On Wed, Mar 16, 2022 at 5:39 AM Lynne wrote: > > 16 Mar 2022, 13:07 by danilchap-at-google.com@ffmpeg.org: > > > --- > > libavcodec/libvpxenc.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index 8f94ba15dc..45baeed435 100644 > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -1658,6 +1658,13 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, > > flags |= strtoul(en->value, NULL, 10); > > } > > > > + en = av_dict_get(frame->metadata, "max-quantizer", NULL, 0); > > + if (en) { > > + struct vpx_codec_enc_cfg cfg = *enccfg; > > + cfg.rc_max_quantizer = strtoul(en->value, NULL, 10); > > + vpx_codec_enc_config_set(&ctx->encoder, &cfg); > > + } > > > > I was going to NAK the earlier patch, but forgot. > Please think of a better way than stuffing random data in > inappropriate fields, and fix the earlier patch that was mistakenly > merged to not do that. I agree this isn't great. Would you suggest updating the qmax setting and checking it / all options on a per-frame basis or is there a better way to reconfigure the codec on the fly? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".