Re: [FFmpeg-devel] [PATCH v6 3/9] libavformat/oggparsevorbis.c: Don't append new metadata.

[Romain Beauxis <romain.beauxis@gmail.com>]

Le lun. 24 févr. 2025 à 00:19, Romain Beauxis
<romain.beauxis@gmail.com> a écrit :
>
> Le dim. 23 févr. 2025 à 20:43, Michael Niedermayer
> <michael@niedermayer.cc> a écrit :
> >
> > On Tue, Feb 18, 2025 at 11:24:39PM -0600, Romain Beauxis wrote:
> > > See before/after vorbis tests in following patch.
> > >
> > > ---
> > >  libavformat/oggparsevorbis.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > This breaks:
> >
> > ./ffprobe -hide_banner multi-performer.ogg 2>&1 | grep 'performer '
> >
> >
> >       performer       : prophetik (saxophone);Usa (percussion)
> > vs.
> >       performer       : Usa (percussion)
>
> Do you have a sample/file you can share to reproduce this?

Ok I see, it's in the specs:

Field names are not required to be unique (occur once) within a
comment header. As an example, assume a track was recorded by three
well know artists; the following is permissible, and encouraged:

              ARTIST=Dizzy Gillespie
              ARTIST=Sonny Rollins
              ARTIST=Sonny Stitt

https://xiph.org/vorbis/doc/v-comment.html

Thanks for pointing out, I'll address and will send an updated patch set.

Any other feedback meanwhile?

-- Romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".