From: Romain Beauxis <romain.beauxis@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v6 3/4] ogg/vorbis: implement header packet skip in chained ogg bitstreams.
Date: Tue, 20 May 2025 17:45:01 -0500
Message-ID: <CABWZ6OSyX19T0UgF_nWB09x8qWXCd4TkshOPaBrGUdAC+X8RqQ@mail.gmail.com> (raw)
In-Reply-To: <20250520214549.GJ29660@pb2>
Le mar. 20 mai 2025 à 16:46, Michael Niedermayer
<michael@niedermayer.cc> a écrit :
>
> On Mon, May 19, 2025 at 09:46:38AM -0500, Romain Beauxis wrote:
> > ---
> > libavcodec/vorbis_parser.h | 11 ++++
> > libavcodec/vorbisdec.c | 76 +++++++++++++---------
> > libavformat/oggparsevorbis.c | 63 +++++++++++++++++-
> > tests/ref/fate/ogg-vorbis-chained-meta.txt | 3 -
> > 4 files changed, 116 insertions(+), 37 deletions(-)
>
> breaks fate here (normal x86-64 ubuntu)
>
> --- ./tests/ref/fate/ogg-vorbis-chained-meta.txt 2025-05-20 23:42:32.043927021 +0200
> +++ tests/data/fate/ogg-vorbis-chained-meta 2025-05-20 23:43:07.908216645 +0200
> @@ -7,8 +7,4 @@
> Stream ID: 0, frame PTS: 704, metadata: N/A
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, new metadata: encoder=Lavc61.19.100 libvorbis:title=Second Stream
> -Stream ID: 0, frame PTS: 0, metadata: N/A
> Stream ID: 0, packet PTS: 128, packet DTS: 128
> -Stream ID: 0, frame PTS: 128, metadata: N/A
> -Stream ID: 0, packet PTS: 704, packet DTS: 704
> -Stream ID: 0, frame PTS: 704, metadata: N/A
> Test ogg-vorbis-chained-meta failed. Look at tests/data/fate/ogg-vorbis-chained-meta.err for details.
> make: *** [tests/Makefile:316: fate-ogg-vorbis-chained-meta] Error 1
I'm not sure what I'm looking at. Is that the output of running the FATE tests?
This diff is already included in the patch:
```
% git show 37370e99451cf0750d5304764ba9031b80e5b3e0 tests/
commit 37370e99451cf0750d5304764ba9031b80e5b3e0 (HEAD)
Author: Romain Beauxis <romain.beauxis@gmail.com>
Date: Sat May 17 12:59:40 2025 -0500
ogg/vorbis: implement header packet skip in chained ogg bitstreams.
diff --git a/tests/ref/fate/ogg-vorbis-chained-meta.txt
b/tests/ref/fate/ogg-vorbis-chained-meta.txt
index b7a97c90e2..1206f86c1f 100644
--- a/tests/ref/fate/ogg-vorbis-chained-meta.txt
+++ b/tests/ref/fate/ogg-vorbis-chained-meta.txt
@@ -6,10 +6,7 @@ Stream ID: 0, frame PTS: 128, metadata: N/A
Stream ID: 0, packet PTS: 704, packet DTS: 704
Stream ID: 0, frame PTS: 704, metadata: N/A
Stream ID: 0, packet PTS: 0, packet DTS: 0
-Stream ID: 0, packet PTS: 0, packet DTS: 0
Stream ID: 0, new metadata: encoder=Lavc61.19.100 libvorbis:title=Second Stream
-Stream ID: 0, packet PTS: 0, packet DTS: 0
-Stream ID: 0, packet PTS: 0, packet DTS: 0
Stream ID: 0, frame PTS: 0, metadata: N/A
Stream ID: 0, packet PTS: 128, packet DTS: 128
Stream ID: 0, frame PTS: 128, metadata: N/A
```
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
> questions about the command line tools should be sent to the ffmpeg-user ML.
> And questions about how to use libav* should be sent to the libav-user ML.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-20 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 14:46 [FFmpeg-devel] [PATCH v6 0/4] Remove chained ogg stream header packets from the demuxer Romain Beauxis
2025-05-19 14:46 ` [FFmpeg-devel] [PATCH v6 1/4] libavformat/oggdec.{c, h}: Add new_extradata, use it to pass extradata to the next decoded packet Romain Beauxis
2025-05-19 14:46 ` [FFmpeg-devel] [PATCH v6 2/4] ogg/vorbis: factor out header processing logic Romain Beauxis
2025-05-19 14:46 ` [FFmpeg-devel] [PATCH v6 3/4] ogg/vorbis: implement header packet skip in chained ogg bitstreams Romain Beauxis
2025-05-20 21:45 ` Michael Niedermayer
2025-05-20 22:45 ` Romain Beauxis [this message]
2025-05-21 7:53 ` Michael Niedermayer
2025-05-21 14:51 ` Romain Beauxis
2025-05-19 14:46 ` [FFmpeg-devel] [PATCH v6 4/4] libavformat/oggdec.h: Change paket function documentation to return 1 on header packets only Romain Beauxis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABWZ6OSyX19T0UgF_nWB09x8qWXCd4TkshOPaBrGUdAC+X8RqQ@mail.gmail.com \
--to=romain.beauxis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git