* [FFmpeg-devel] [RFC] Experiment: enable github pull requests
@ 2025-02-12 18:06 Michael Niedermayer
2025-02-12 18:49 ` Lynne
0 siblings, 1 reply; 12+ messages in thread
From: Michael Niedermayer @ 2025-02-12 18:06 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]
Hi all
I propose, that we enable github pull requests
github is the most widely used development platform and has the lowest barrier
of entry.
after ~1-3 Month, we then evaluate how many new developers this attracted,
how many new contributions it attracted.
What the ratios of reviewed vs ignored vs applied vs rejected patches are compared to the ML
This information should help the community make decissions about the use of
web based git development vs the mailing list.
Thx
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 18:06 [FFmpeg-devel] [RFC] Experiment: enable github pull requests Michael Niedermayer
@ 2025-02-12 18:49 ` Lynne
2025-02-12 18:53 ` Romain Beauxis
2025-02-12 20:38 ` Michael Niedermayer
0 siblings, 2 replies; 12+ messages in thread
From: Lynne @ 2025-02-12 18:49 UTC (permalink / raw)
To: ffmpeg-devel
[-- Attachment #1.1.1.1: Type: text/plain, Size: 1490 bytes --]
On 12/02/2025 19:06, Michael Niedermayer wrote:
> Hi all
>
> I propose, that we enable github pull requests
>
> github is the most widely used development platform and has the lowest barrier
> of entry.
>
> after ~1-3 Month, we then evaluate how many new developers this attracted,
> how many new contributions it attracted.
> What the ratios of reviewed vs ignored vs applied vs rejected patches are compared to the ML
Those are rather arbitrary statistics.
> This information should help the community make decissions about the use of
> web based git development vs the mailing list.
Every one of us is already familiar with the benefits of having a platform.
This is just slowing down and delaying what we ought to do, which is to
switch as soon as possible.
Finally, without CI, it doesn't really show the potential.
We all know that github will not be the platform we move to, so instead
of getting used to a temporary workflow, I'd rather we test a likely
final workflow that we could potentially be using.
Instead of github, I want to use the current test Forgejo instance. It
already has CI working and over 10 developers have registered.
Some have doubts about whether it would slow down with more users, or
bugs would appear, and it would be good to demonstrate the platform can
handle our workflow, and fix any remaining issues.
Users can already login to the instance with their github accounts, so
there's no barrier to entry.
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 18:49 ` Lynne
@ 2025-02-12 18:53 ` Romain Beauxis
2025-02-12 19:23 ` Lynne
2025-02-12 20:38 ` Michael Niedermayer
1 sibling, 1 reply; 12+ messages in thread
From: Romain Beauxis @ 2025-02-12 18:53 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
>
> On 12/02/2025 19:06, Michael Niedermayer wrote:
> > Hi all
Hi!
>
> > I propose, that we enable github pull requests
> >
> > github is the most widely used development platform and has the lowest barrier
> > of entry.
> >
> > after ~1-3 Month, we then evaluate how many new developers this attracted,
> > how many new contributions it attracted.
> > What the ratios of reviewed vs ignored vs applied vs rejected patches are compared to the ML
>
> Those are rather arbitrary statistics.
>
> > This information should help the community make decissions about the use of
> > web based git development vs the mailing list.
>
> Every one of us is already familiar with the benefits of having a platform.
> This is just slowing down and delaying what we ought to do, which is to
> switch as soon as possible.
> Finally, without CI, it doesn't really show the potential.
>
> We all know that github will not be the platform we move to, so instead
> of getting used to a temporary workflow, I'd rather we test a likely
> final workflow that we could potentially be using.
>
> Instead of github, I want to use the current test Forgejo instance. It
> already has CI working and over 10 developers have registered.
> Some have doubts about whether it would slow down with more users, or
> bugs would appear, and it would be good to demonstrate the platform can
> handle our workflow, and fix any remaining issues.
>
> Users can already login to the instance with their github accounts, so
> there's no barrier to entry.
Would you mind sharing the url? A quick search didn't reveal anything.
Thanks,
-- Romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 18:53 ` Romain Beauxis
@ 2025-02-12 19:23 ` Lynne
2025-02-12 21:22 ` Stephen Hutchinson
0 siblings, 1 reply; 12+ messages in thread
From: Lynne @ 2025-02-12 19:23 UTC (permalink / raw)
To: ffmpeg-devel
[-- Attachment #1.1.1.1: Type: text/plain, Size: 1810 bytes --]
On 12/02/2025 19:53, Romain Beauxis wrote:
> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
>>
>> On 12/02/2025 19:06, Michael Niedermayer wrote:
>>> Hi all
>
> Hi!
>
>>
>>> I propose, that we enable github pull requests
>>>
>>> github is the most widely used development platform and has the lowest barrier
>>> of entry.
>>>
>>> after ~1-3 Month, we then evaluate how many new developers this attracted,
>>> how many new contributions it attracted.
>>> What the ratios of reviewed vs ignored vs applied vs rejected patches are compared to the ML
>>
>> Those are rather arbitrary statistics.
>>
>>> This information should help the community make decissions about the use of
>>> web based git development vs the mailing list.
>>
>> Every one of us is already familiar with the benefits of having a platform.
>> This is just slowing down and delaying what we ought to do, which is to
>> switch as soon as possible.
>> Finally, without CI, it doesn't really show the potential.
>>
>> We all know that github will not be the platform we move to, so instead
>> of getting used to a temporary workflow, I'd rather we test a likely
>> final workflow that we could potentially be using.
>>
>> Instead of github, I want to use the current test Forgejo instance. It
>> already has CI working and over 10 developers have registered.
>> Some have doubts about whether it would slow down with more users, or
>> bugs would appear, and it would be good to demonstrate the platform can
>> handle our workflow, and fix any remaining issues.
>>
>> Users can already login to the instance with their github accounts, so
>> there's no barrier to entry.
>
> Would you mind sharing the url? A quick search didn't reveal anything.
Sure
https://code.ffmpeg.org/
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 18:49 ` Lynne
2025-02-12 18:53 ` Romain Beauxis
@ 2025-02-12 20:38 ` Michael Niedermayer
1 sibling, 0 replies; 12+ messages in thread
From: Michael Niedermayer @ 2025-02-12 20:38 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1077 bytes --]
On Wed, Feb 12, 2025 at 07:49:20PM +0100, Lynne wrote:
> On 12/02/2025 19:06, Michael Niedermayer wrote:
> > Hi all
> >
> > I propose, that we enable github pull requests
> >
> > github is the most widely used development platform and has the lowest barrier
> > of entry.
> >
> > after ~1-3 Month, we then evaluate how many new developers this attracted,
> > how many new contributions it attracted.
> > What the ratios of reviewed vs ignored vs applied vs rejected patches are compared to the ML
>
> Those are rather arbitrary statistics.
Some people claimed these statistics would improve. I do think we should
compare some statistics (obviously not limited to these)
[...]
> Users can already login to the instance with their github accounts, so
> there's no barrier to entry.
Thats cool, then forgejo is probably better for this experiment (if we do it)
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 19:23 ` Lynne
@ 2025-02-12 21:22 ` Stephen Hutchinson
2025-02-12 21:32 ` Timo Rothenpieler
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Hutchinson @ 2025-02-12 21:22 UTC (permalink / raw)
To: ffmpeg-devel
On 2/12/25 2:23 PM, Lynne wrote:
>
>
> On 12/02/2025 19:53, Romain Beauxis wrote:
>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
>>>
>>> Users can already login to the instance with their github accounts, so
>>> there's no barrier to entry.
>>
>> Would you mind sharing the url? A quick search didn't reveal anything.
>
> Sure
> https://code.ffmpeg.org/
>
Are all accounts restricted to owning a maximum of 0 repositories by
default, or is it set to 0 only for those that sign up through one of
the external logins?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 21:22 ` Stephen Hutchinson
@ 2025-02-12 21:32 ` Timo Rothenpieler
2025-02-12 21:37 ` Soft Works
2025-02-12 22:12 ` Romain Beauxis
0 siblings, 2 replies; 12+ messages in thread
From: Timo Rothenpieler @ 2025-02-12 21:32 UTC (permalink / raw)
To: ffmpeg-devel
On 12.02.2025 22:22, Stephen Hutchinson wrote:
> On 2/12/25 2:23 PM, Lynne wrote:
>>
>>
>> On 12/02/2025 19:53, Romain Beauxis wrote:
>>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
>>>>
>>>> Users can already login to the instance with their github accounts, so
>>>> there's no barrier to entry.
>>>
>>> Would you mind sharing the url? A quick search didn't reveal anything.
>>
>> Sure
>> https://code.ffmpeg.org/
>>
>
> Are all accounts restricted to owning a maximum of 0 repositories by
> default, or is it set to 0 only for those that sign up through one of
> the external logins?
It's set to 0 by default, to avoid spammers uploading junk, or just
people (ab)using it for non-ffmpeg things.
You can open issues and comment on existing PRs.
And also create PRs using the AGit workflow:
https://forgejo.org/docs/latest/user/agit-support/
The repo limit can manually be lifted per user. I preferred that
approach vs. the Videolan approach of completely locking down the
instance, and requiring admin approval for every single new user, which
imo is more detrimental to new contributors than a ML.
Timo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 21:32 ` Timo Rothenpieler
@ 2025-02-12 21:37 ` Soft Works
2025-02-12 21:51 ` Timo Rothenpieler
2025-02-12 22:12 ` Romain Beauxis
1 sibling, 1 reply; 12+ messages in thread
From: Soft Works @ 2025-02-12 21:37 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Timo
> Rothenpieler
> Sent: Mittwoch, 12. Februar 2025 22:33
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
>
> On 12.02.2025 22:22, Stephen Hutchinson wrote:
> > On 2/12/25 2:23 PM, Lynne wrote:
> >>
> >>
> >> On 12/02/2025 19:53, Romain Beauxis wrote:
> >>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
> >>>>
> >>>> Users can already login to the instance with their github accounts, so
> >>>> there's no barrier to entry.
> >>>
> >>> Would you mind sharing the url? A quick search didn't reveal anything.
> >>
> >> Sure
> >> https://code.ffmpeg.org/
> >>
> >
> > Are all accounts restricted to owning a maximum of 0 repositories by
> > default, or is it set to 0 only for those that sign up through one of
> > the external logins?
>
> It's set to 0 by default, to avoid spammers uploading junk, or just
> people (ab)using it for non-ffmpeg things.
>
> You can open issues and comment on existing PRs.
> And also create PRs using the AGit workflow:
> https://forgejo.org/docs/latest/user/agit-support/
>
> The repo limit can manually be lifted per user. I preferred that
> approach vs. the Videolan approach of completely locking down the
> instance, and requiring admin approval for every single new user, which
> imo is more detrimental to new contributors than a ML.
Hi Timo,
Does that mean that you cannot create forks and create PRs from that forked repo like on GitHub?
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 21:37 ` Soft Works
@ 2025-02-12 21:51 ` Timo Rothenpieler
2025-02-12 22:01 ` Soft Works
0 siblings, 1 reply; 12+ messages in thread
From: Timo Rothenpieler @ 2025-02-12 21:51 UTC (permalink / raw)
To: ffmpeg-devel
On 12.02.2025 22:37, Soft Works wrote:
>
>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Timo
>> Rothenpieler
>> Sent: Mittwoch, 12. Februar 2025 22:33
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
>>
>> On 12.02.2025 22:22, Stephen Hutchinson wrote:
>>> On 2/12/25 2:23 PM, Lynne wrote:
>>>>
>>>>
>>>> On 12/02/2025 19:53, Romain Beauxis wrote:
>>>>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
>>>>>>
>>>>>> Users can already login to the instance with their github accounts, so
>>>>>> there's no barrier to entry.
>>>>>
>>>>> Would you mind sharing the url? A quick search didn't reveal anything.
>>>>
>>>> Sure
>>>> https://code.ffmpeg.org/
>>>>
>>>
>>> Are all accounts restricted to owning a maximum of 0 repositories by
>>> default, or is it set to 0 only for those that sign up through one of
>>> the external logins?
>>
>> It's set to 0 by default, to avoid spammers uploading junk, or just
>> people (ab)using it for non-ffmpeg things.
>>
>> You can open issues and comment on existing PRs.
>> And also create PRs using the AGit workflow:
>> https://forgejo.org/docs/latest/user/agit-support/
>>
>> The repo limit can manually be lifted per user. I preferred that
>> approach vs. the Videolan approach of completely locking down the
>> instance, and requiring admin approval for every single new user, which
>> imo is more detrimental to new contributors than a ML.
>
> Hi Timo,
>
> Does that mean that you cannot create forks and create PRs from that forked repo like on GitHub?
>
Not sure what you mean, you need "admin approval" to be allowed to
create repos, including forks.
Just to avoid abuse. Obviously you can then PR from that fork once you
got one.
Or you can submit PRs without a fork as stated above.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 21:51 ` Timo Rothenpieler
@ 2025-02-12 22:01 ` Soft Works
2025-02-12 22:05 ` Timo Rothenpieler
0 siblings, 1 reply; 12+ messages in thread
From: Soft Works @ 2025-02-12 22:01 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Timo
> Rothenpieler
> Sent: Mittwoch, 12. Februar 2025 22:51
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
>
> On 12.02.2025 22:37, Soft Works wrote:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Timo
> >> Rothenpieler
> >> Sent: Mittwoch, 12. Februar 2025 22:33
> >> To: ffmpeg-devel@ffmpeg.org
> >> Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
> >>
> >> On 12.02.2025 22:22, Stephen Hutchinson wrote:
> >>> On 2/12/25 2:23 PM, Lynne wrote:
> >>>>
> >>>>
> >>>> On 12/02/2025 19:53, Romain Beauxis wrote:
> >>>>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
> >>>>>>
> >>>>>> Users can already login to the instance with their github accounts, so
> >>>>>> there's no barrier to entry.
> >>>>>
> >>>>> Would you mind sharing the url? A quick search didn't reveal anything.
> >>>>
> >>>> Sure
> >>>> https://code.ffmpeg.org/
> >>>>
> >>>
> >>> Are all accounts restricted to owning a maximum of 0 repositories by
> >>> default, or is it set to 0 only for those that sign up through one of
> >>> the external logins?
> >>
> >> It's set to 0 by default, to avoid spammers uploading junk, or just
> >> people (ab)using it for non-ffmpeg things.
> >>
> >> You can open issues and comment on existing PRs.
> >> And also create PRs using the AGit workflow:
> >> https://forgejo.org/docs/latest/user/agit-support/
> >>
> >> The repo limit can manually be lifted per user. I preferred that
> >> approach vs. the Videolan approach of completely locking down the
> >> instance, and requiring admin approval for every single new user, which
> >> imo is more detrimental to new contributors than a ML.
> >
> > Hi Timo,
> >
> > Does that mean that you cannot create forks and create PRs from that forked
> repo like on GitHub?
> >
> Not sure what you mean, you need "admin approval" to be allowed to
> create repos, including forks.
I don't think it's a good idea to build such entry bars.
> Just to avoid abuse. Obviously you can then PR from that fork once you
> got one.
> Or you can submit PRs without a fork as stated above.
That's a workflow I've never heard about - same like most other contributors. Again, that is building an entry bar.
I think people should be able to use a procedure they are familiar with.
Is it possible to create PRs from a fork on GitHub?
Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 22:01 ` Soft Works
@ 2025-02-12 22:05 ` Timo Rothenpieler
0 siblings, 0 replies; 12+ messages in thread
From: Timo Rothenpieler @ 2025-02-12 22:05 UTC (permalink / raw)
To: ffmpeg-devel
On 12.02.2025 23:01, Soft Works wrote:
>
>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Timo
>> Rothenpieler
>> Sent: Mittwoch, 12. Februar 2025 22:51
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
>>
>> On 12.02.2025 22:37, Soft Works wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Timo
>>>> Rothenpieler
>>>> Sent: Mittwoch, 12. Februar 2025 22:33
>>>> To: ffmpeg-devel@ffmpeg.org
>>>> Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
>>>>
>>>> On 12.02.2025 22:22, Stephen Hutchinson wrote:
>>>>> On 2/12/25 2:23 PM, Lynne wrote:
>>>>>>
>>>>>>
>>>>>> On 12/02/2025 19:53, Romain Beauxis wrote:
>>>>>>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
>>>>>>>>
>>>>>>>> Users can already login to the instance with their github accounts, so
>>>>>>>> there's no barrier to entry.
>>>>>>>
>>>>>>> Would you mind sharing the url? A quick search didn't reveal anything.
>>>>>>
>>>>>> Sure
>>>>>> https://code.ffmpeg.org/
>>>>>>
>>>>>
>>>>> Are all accounts restricted to owning a maximum of 0 repositories by
>>>>> default, or is it set to 0 only for those that sign up through one of
>>>>> the external logins?
>>>>
>>>> It's set to 0 by default, to avoid spammers uploading junk, or just
>>>> people (ab)using it for non-ffmpeg things.
>>>>
>>>> You can open issues and comment on existing PRs.
>>>> And also create PRs using the AGit workflow:
>>>> https://forgejo.org/docs/latest/user/agit-support/
>>>>
>>>> The repo limit can manually be lifted per user. I preferred that
>>>> approach vs. the Videolan approach of completely locking down the
>>>> instance, and requiring admin approval for every single new user, which
>>>> imo is more detrimental to new contributors than a ML.
>>>
>>> Hi Timo,
>>>
>>> Does that mean that you cannot create forks and create PRs from that forked
>> repo like on GitHub?
>>>
>> Not sure what you mean, you need "admin approval" to be allowed to
>> create repos, including forks.
>
> I don't think it's a good idea to build such entry bars.
>
>> Just to avoid abuse. Obviously you can then PR from that fork once you
>> got one.
>> Or you can submit PRs without a fork as stated above.
>
> That's a workflow I've never heard about - same like most other contributors. Again, that is building an entry bar.
>
> I think people should be able to use a procedure they are familiar with.
> Is it possible to create PRs from a fork on GitHub?
>
I'm really not sure what you're asking.
PRs are not restricted. Creating repos is.
And there is no way to NOT restrict it, unless you want to pay several
hundred Euros a month in hosting fees extra, and constantly be on the
lookout for hosting illegal/harmful things.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests
2025-02-12 21:32 ` Timo Rothenpieler
2025-02-12 21:37 ` Soft Works
@ 2025-02-12 22:12 ` Romain Beauxis
1 sibling, 0 replies; 12+ messages in thread
From: Romain Beauxis @ 2025-02-12 22:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Le mer. 12 févr. 2025 à 15:32, Timo Rothenpieler <timo@rothenpieler.org> a
écrit :
>
> On 12.02.2025 22:22, Stephen Hutchinson wrote:
> > On 2/12/25 2:23 PM, Lynne wrote:
> >>
> >>
> >> On 12/02/2025 19:53, Romain Beauxis wrote:
> >>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
> >>>>
> >>>> Users can already login to the instance with their github accounts,
so
> >>>> there's no barrier to entry.
> >>>
> >>> Would you mind sharing the url? A quick search didn't reveal anything.
> >>
> >> Sure
> >> https://code.ffmpeg.org/
> >>
> >
> > Are all accounts restricted to owning a maximum of 0 repositories by
> > default, or is it set to 0 only for those that sign up through one of
> > the external logins?
>
> It's set to 0 by default, to avoid spammers uploading junk, or just
> people (ab)using it for non-ffmpeg things.
>
> You can open issues and comment on existing PRs.
> And also create PRs using the AGit workflow:
> https://forgejo.org/docs/latest/user/agit-support/
>
> The repo limit can manually be lifted per user. I preferred that
> approach vs. the Videolan approach of completely locking down the
> instance, and requiring admin approval for every single new user, which
> imo is more detrimental to new contributors than a ML.
I totally understand the concern.
The procedure for creating PRs using AGit is a bit arcane but I'll give it
a try.
It would be nice to have this document big and bold when users register, I
was quite lost after registration seeing I couldn't fork.
I'm gonna try to think about how to split patches from the ML perspective
to a PR perspective.
Is there any opinion on this? Typically the series I have has a section for
flac and one for opus, do y'all think one general PR for the base work then
one PR for flac and one PR for opus or one single PR with the patch series
like in the ML?
Thanks,
-- romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-02-12 22:13 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-12 18:06 [FFmpeg-devel] [RFC] Experiment: enable github pull requests Michael Niedermayer
2025-02-12 18:49 ` Lynne
2025-02-12 18:53 ` Romain Beauxis
2025-02-12 19:23 ` Lynne
2025-02-12 21:22 ` Stephen Hutchinson
2025-02-12 21:32 ` Timo Rothenpieler
2025-02-12 21:37 ` Soft Works
2025-02-12 21:51 ` Timo Rothenpieler
2025-02-12 22:01 ` Soft Works
2025-02-12 22:05 ` Timo Rothenpieler
2025-02-12 22:12 ` Romain Beauxis
2025-02-12 20:38 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git