From: Romain Beauxis <romain.beauxis@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v10 8/8] tests: Add chained ogg/opus stream dump test.
Date: Fri, 4 Apr 2025 15:53:33 -0500
Message-ID: <CABWZ6OSiy69LihHME2h6buUxk4f1ei+vpGCpwRjwwWaM83dAEA@mail.gmail.com> (raw)
In-Reply-To: <20250404204728.GY4991@pb2>
Le ven. 4 avr. 2025 à 15:47, Michael Niedermayer
<michael@niedermayer.cc> a écrit :
>
> Hi
>
> On Wed, Apr 02, 2025 at 01:29:40PM -0500, Romain Beauxis wrote:
> > ---
> > tests/Makefile | 1 +
> > tests/fate/ogg-opus.mak | 11 ++++++++++
> > tests/ref/fate/ogg-opus-chained-meta.txt | 27 ++++++++++++++++++++++++
> > 3 files changed, 39 insertions(+)
> > create mode 100644 tests/fate/ogg-opus.mak
> > create mode 100644 tests/ref/fate/ogg-opus-chained-meta.txt
>
> Applying: tests: Add chained ogg/opus stream dump test.
> .git/rebase-apply/patch:47: trailing whitespace.
> Stream ID: 0, frame PTS: -312, metadata:
> .git/rebase-apply/patch:49: trailing whitespace.
> Stream ID: 0, frame PTS: 648, metadata:
> .git/rebase-apply/patch:51: trailing whitespace.
> Stream ID: 0, frame PTS: 1608, metadata:
> .git/rebase-apply/patch:53: trailing whitespace.
> Stream ID: 0, frame PTS: 2568, metadata:
> .git/rebase-apply/patch:55: trailing whitespace.
> Stream ID: 0, frame PTS: 3528, metadata:
> warning: squelched 6 whitespace errors
> warning: 11 lines add whitespace errors.
>
> same question as previous tests, are these needed for the test
> or can they be removed ?
These are intentional!
> thx
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If a bugfix only changes things apparently unrelated to the bug with no
> further explanation, that is a good sign that the bugfix is wrong.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-04-04 20:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 18:29 [FFmpeg-devel] [PATCH v10 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 1/8] libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame with the same PTS Romain Beauxis
2025-04-04 20:39 ` Michael Niedermayer
2025-04-04 20:56 ` Romain Beauxis
2025-04-04 21:24 ` Michael Niedermayer
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 2/8] tests: Add stream dump test API util Romain Beauxis
2025-04-04 20:40 ` Michael Niedermayer
2025-04-04 20:55 ` Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 3/8] tests: Add chained ogg/vorbis stream dump test Romain Beauxis
2025-04-04 20:44 ` Michael Niedermayer
2025-04-04 20:53 ` Romain Beauxis
2025-04-04 21:00 ` Michael Niedermayer
2025-04-04 21:01 ` Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 4/8] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 5/8] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 6/8] tests: Add chained ogg/flac stream dump test Romain Beauxis
2025-04-04 20:45 ` Michael Niedermayer
2025-04-04 20:52 ` Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 7/8] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis
2025-04-02 18:29 ` [FFmpeg-devel] [PATCH v10 8/8] tests: Add chained ogg/opus stream dump test Romain Beauxis
2025-04-04 20:47 ` Michael Niedermayer
2025-04-04 20:53 ` Romain Beauxis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABWZ6OSiy69LihHME2h6buUxk4f1ei+vpGCpwRjwwWaM83dAEA@mail.gmail.com \
--to=romain.beauxis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git