Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

[Romain Beauxis <romain.beauxis@gmail.com>]

Le dim. 27 juil. 2025 à 19:22, Michael Niedermayer <michael@niedermayer.cc>
a écrit :
>
> Hi Romain
>
> On Wed, Jul 23, 2025 at 02:06:07PM -0500, Romain Beauxis wrote:
> > Le sam. 21 juin 2025 à 16:59, Michael Niedermayer <
michael@niedermayer.cc>
> > a écrit :
> > >
> > > On Sat, Jun 21, 2025 at 10:45:32AM +0200, Romain Beauxis wrote:
> > > > Le dim. 15 juin 2025 à 00:57, Michael Niedermayer
> > > > <michael@niedermayer.cc> a écrit :
> > > > >
> > > > > On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote:
> > > > > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013
using a
> > flat
> > > > > > memory storage for the extradata.
> > > > > >
> > > > > > PR review comments addressed:
> > > > > > * Use flat memory bytestream
> > > > > > * Re-use existing xiph extradata layout
> > > > > >
> > > > > > ---
> > > > >
> > > > > >  libavcodec/vorbisdec.c                     | 42 ++++++++---
> > > > > >  libavformat/oggparsevorbis.c               | 83
> > +++++++++++++++++++++-
> > > > >
> > > > > patches that change both libraries at the same time are suspect
> > > > >
> > > > > if one depends on changes in the other it needs
> > > > > minor API version bump and seperate patches so extension of
> > > > > API and use of it are properly tracked and testable
> > > >
> > > > If I remember well, according to Andreas Rheinhardt there's no need
> > > > for an API bump here since the patch is re-using existing extradata
> > > > bitstream structures.
> > >
> > > If there is really no API extension then the micro versions should be
> > bumped
> > > so a user knows if the specific version he uses has teh fix.
> > > Also it may be usefull in bugreports about ogg to know if its prior or
> > > after this change
> >
> > Hi Michael,
> >
> > I have created a PR on code.ffmpeg.org here:
> > https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026
> >
>
> > Would you have a minute to have a look?
>
> I do not have time, ive made a dumb mistake in configuring my inbox
> so iam about a week behind with emails without realizing it.
> thats on top of release, security, and other things
>
> maybe someome else can look into this one
> replying here so noone waits for a review from me

Thanks for letting me know and sorry about your issues with your email
inbox.

Do you have any advice on how to look for a reviewer for this path?

> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Any man who breaks a law that conscience tells him is unjust and willingly
> accepts the penalty by staying in jail in order to arouse the conscience
of
> the community on the injustice of the law is at that moment expressing the
> very highest respect for law. - Martin Luther King Jr
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".