From: Romain Beauxis <romain.beauxis@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v6 7/9] tests: Add chained ogg/flac stream dump test.
Date: Fri, 21 Feb 2025 09:40:58 -0600
Message-ID: <CABWZ6ORi1dC5g4Twb9G1z=mShcPcV+rKd2d3uNmiD4YsXqSm4g@mail.gmail.com> (raw)
In-Reply-To: <20250221110123.GM4991@pb2>
Le ven. 21 févr. 2025 à 05:01, Michael Niedermayer
<michael@niedermayer.cc> a écrit :
>
> On Tue, Feb 18, 2025 at 11:24:43PM -0600, Romain Beauxis wrote:
> > Before:
> > Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 0, metadata:
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 0, metadata:
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> >
> > After:
> > Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 0, metadata:
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, frame PTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> > Stream ID: 0, frame PTS: 4608, metadata:
> >
> > ---
> > tests/Makefile | 1 +
> > tests/fate/ogg-flac.mak | 11 +++++++++++
> > 2 files changed, 12 insertions(+)
> > create mode 100644 tests/fate/ogg-flac.mak
>
> this fails fate:
>
> TEST ogg-flac-chained-meta
> --- fate-suite//ogg-flac/chained-meta.txt 2025-02-06 03:37:55.000000000 +0100
> +++ tests/data/fate/ogg-flac-chained-meta 2025-02-21 11:58:41.572340528 +0100
> @@ -1,11 +1,11 @@
> Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> Stream ID: 0, frame PTS: 0, metadata:
> -Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> +Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> Stream ID: 0, frame PTS: 4608, metadata:
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> -Stream ID: 0, packet PTS: 0, packet DTS: 0
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> +Stream ID: 0, packet PTS: 0, packet DTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> Stream ID: 0, frame PTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> -Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> +Stream ID: 0, packet PTS: 4608, packet DTS: 4608, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> Stream ID: 0, frame PTS: 4608, metadata:
> Test ogg-flac-chained-meta failed. Look at tests/data/fate/ogg-flac-chained-meta.err for details.
> make: *** [tests/Makefile:314: fate-ogg-flac-chained-meta] Error 1
Thanks for checking it and sorry I hadn't updated my remote files.
They are all up-to-date now.
I have also updated the PR here with a description of the most recent
changes and the fixed rebase commit:
https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/6
Thanks,
-- Romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-21 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 5:24 [FFmpeg-devel] [PATCH v6 0/9] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 1/9] libavcodec/decode.c: Add generic metadata injection using AV_PKT_DATA_METADATA_UPDATE Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 2/9] tests: Add stream dump test API util Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 3/9] libavformat/oggparsevorbis.c: Don't append new metadata Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 4/9] tests: Add chained ogg/vorbis stream dump test Romain Beauxis
2025-02-19 17:53 ` Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 5/9] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 6/9] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 7/9] tests: Add chained ogg/flac stream dump test Romain Beauxis
2025-02-21 11:01 ` Michael Niedermayer
2025-02-21 15:40 ` Romain Beauxis [this message]
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 8/9] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis
2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 9/9] tests: Add chained ogg/opus stream dump test Romain Beauxis
2025-02-19 18:17 ` [FFmpeg-devel] [PATCH v6 0/9] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Lynne
2025-02-19 18:57 ` Romain Beauxis
2025-02-21 15:41 ` Romain Beauxis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABWZ6ORi1dC5g4Twb9G1z=mShcPcV+rKd2d3uNmiD4YsXqSm4g@mail.gmail.com' \
--to=romain.beauxis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git