Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

[Romain Beauxis <romain.beauxis-at-gmail.com@ffmpeg.org>]

Le dim. 15 juin 2025 à 00:57, Michael Niedermayer
<michael@niedermayer.cc> a écrit :
>
> On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote:
> > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a flat
> > memory storage for the extradata.
> >
> > PR review comments addressed:
> > * Use flat memory bytestream
> > * Re-use existing xiph extradata layout
> >
> > ---
>
> >  libavcodec/vorbisdec.c                     | 42 ++++++++---
> >  libavformat/oggparsevorbis.c               | 83 +++++++++++++++++++++-
>
> patches that change both libraries at the same time are suspect
>
> if one depends on changes in the other it needs
> minor API version bump and seperate patches so extension of
> API and use of it are properly tracked and testable

If I remember well, according to Andreas Rheinhardt there's no need
for an API bump here since the patch is re-using existing extradata
bitstream structures.

> have not reveiwed the rest of the patch
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The real ebay dictionary, page 1
> "Used only once"    - "Some unspecified defect prevented a second use"
> "In good condition" - "Can be repaird by experienced expert"
> "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".