Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

[Romain Beauxis <romain.beauxis@gmail.com>]

Le mer. 12 févr. 2025 à 16:12, Romain Beauxis
<romain.beauxis@gmail.com> a écrit :
>
>
>
>
> Le mer. 12 févr. 2025 à 15:32, Timo Rothenpieler <timo@rothenpieler.org> a écrit :
> >
> > On 12.02.2025 22:22, Stephen Hutchinson wrote:
> > > On 2/12/25 2:23 PM, Lynne wrote:
> > >>
> > >>
> > >> On 12/02/2025 19:53, Romain Beauxis wrote:
> > >>> Le mer. 12 févr. 2025 à 12:49, Lynne <dev@lynne.ee> a écrit :
> > >>>>
> > >>>> Users can already login to the instance with their github accounts, so
> > >>>> there's no barrier to entry.
> > >>>
> > >>> Would you mind sharing the url? A quick search didn't reveal anything.
> > >>
> > >> Sure
> > >> https://code.ffmpeg.org/
> > >>
> > >
> > > Are all accounts restricted to owning a maximum of 0 repositories by
> > > default, or is it set to 0 only for those that sign up through one of
> > > the external logins?
> >
> > It's set to 0 by default, to avoid spammers uploading junk, or just
> > people (ab)using it for non-ffmpeg things.
> >
> > You can open issues and comment on existing PRs.
> > And also create PRs using the AGit workflow:
> > https://forgejo.org/docs/latest/user/agit-support/
> >
> > The repo limit can manually be lifted per user. I preferred that
> > approach vs. the Videolan approach of completely locking down the
> > instance, and requiring admin approval for every single new user, which
> > imo is more detrimental to new contributors than a ML.
>
> I totally understand the concern.
>
> The procedure for creating PRs using AGit is a bit arcane but I'll give it a try.
>
> It would be nice to have this document big and bold when users register, I was quite lost after registration seeing I couldn't fork.
>
> I'm gonna try to think about how to split patches from the ML perspective to a PR perspective.
>
> Is there any opinion on this? Typically the series I have has a section for flac and one for opus, do y'all think one general PR for the base work then one PR for flac and one PR for opus or one single PR with the patch series like in the ML?

I went ahead and submitted one of two recent patch series:
https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/6

The process was pretty easy once you've figured out the base setup
(SSH key, rebase against the actual repo `master` branch, command line
arguments).

Hopefully this will help get the patchset reviewed!
-- Romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".