From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1147A4B16C for ; Sat, 19 Jul 2025 14:09:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 261ED68C187; Sat, 19 Jul 2025 17:09:50 +0300 (EEST) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6035D68BD10 for ; Sat, 19 Jul 2025 17:09:43 +0300 (EEST) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-60867565fb5so4838688a12.3 for ; Sat, 19 Jul 2025 07:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752934182; x=1753538982; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=EH/LlWXhwAPOwcgpk+jKJWRlEbCX+kJa8Fjg1vjtHWo=; b=DXexpgfoSZ7muDEvkhHzSufqfD3StvzkeZM89HALw6WngI++bkLOGRHl9jdzAdPvPE VMQWI9F1ryN+swGeUUGmN9lONBXkChR6m4gl8PlRQdQK2drFENMDWoMcZXrocWy75595 ULc/8bc0VjIVaVvBYKyvaHEALZ0h96s4b/iZG0BVDQGCmDiLa3E3GV/ksImTXhALFs47 kYtknaFZBrPIg9ThtpNIqHyMELNVFbxBJ/WkVOzUSqY1iZJwmXoPjtHsbUzFMbrGcWtp o7qsAaH5z8+0wOcROv3TukJjYrjfDdhwlUnLY4Qv3plT0z8ex3TTKJAVAmDbOa1hdTLn r2rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752934182; x=1753538982; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EH/LlWXhwAPOwcgpk+jKJWRlEbCX+kJa8Fjg1vjtHWo=; b=BUuMYMUWf+vj7rCcmbwhp7VuVTYZE7Zdygmjug0x/N8GrrMS88v6nF9jUzz76wRJx2 4fwfJVGgGq3hwpAjb3DVnNpJE0N2eTuMpLEOPZD6+iXzyYF7MrJxzUfOmlx/TPL++/OL QCR7Y+xaSKyGV3u8qMV7ZvWJJRmhCNj3jkfOf5WqU4SsW0arBQDpxUg8zphMGbjw7E5U UJBEnlhlV0DdaQrxtUGFOcvUiL2brx2Q387i/qqBs/3zyVh4bRx7wCJmejE7k8ysDIO5 W+NK0a/NIDZ5FsAijMRRRFsln9XkHdzD6HcXAv+9RHItC26rP7QXITsH0Z7s0n0binQQ k0MQ== X-Gm-Message-State: AOJu0YyO+W9QL0OidiPW5tRsp1qJZbECRngxPujB1NneviiPCV0qPl75 T6YD9N7i39M/LD53PI2XIVm8fKwc0Bf99D31CoBk3oEn538XgnHZOVrkfPNDFRURGzZVB4/7Bpd Z1Bl9+S0YMJnaUK7Psm0YCAbQvNUuX3Xqh/7c X-Gm-Gg: ASbGncvNnwLbkjjShfjxjgCienaXw/M1GN/LXAVn7R0DRk387pnEe0IGQ5+oFy7renc EpEKCmyKUBLe/kIKGdNdh71HK75n2fZIcHl6ZKNm7vVbUTUmG6+y7Xspzzp9ohs/G5qdCnlK5dR YKuK6u0eoVdScu36HAqvkHl8uSxx3VX2n513TtRkOaqpQeYe+KkShJpLO8HvJK1B4GnywzQGC7a 0x3 X-Google-Smtp-Source: AGHT+IHwKLhAjFLHerCevY6xEor9mYMzc9sjkK71eUYWZuEEbaJ0Ppme86lgafMtLOMwN1GGMIJKQ14s7mLjoegP7eE= X-Received: by 2002:a05:6402:35d0:b0:612:d8db:ec8e with SMTP id 4fb4d7f45d1cf-612d8dbedc9mr4519072a12.19.1752934181822; Sat, 19 Jul 2025 07:09:41 -0700 (PDT) MIME-Version: 1.0 References: <20250714221451.GQ29660@pb2> <20250715133310.1976-1-jamrial@gmail.com> <20250718230122.GN29660@pb2> <551aa05c-6558-4c62-a333-d5f4ad720732@gmail.com> In-Reply-To: <551aa05c-6558-4c62-a333-d5f4ad720732@gmail.com> From: Kacper Michajlow Date: Sat, 19 Jul 2025 16:09:09 +0200 X-Gm-Features: Ac12FXwqt6_-qbvMpCyCObts2yyacc4dF2zG53FaMp-Wse0M3ETkLIro237M3Ec Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 19 Jul 2025 at 02:27, James Almer wrote: > On 7/18/2025 8:01 PM, Michael Niedermayer wrote: > > On Tue, Jul 15, 2025 at 10:33:10AM -0300, James Almer wrote: > >> Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero > offset to null pointer > >> Signed-off-by: James Almer > >> --- > >> libavcodec/motion_est.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c > >> index 93be712cc0..3273451f9a 100644 > >> --- a/libavcodec/motion_est.c > >> +++ b/libavcodec/motion_est.c > >> @@ -91,12 +91,12 @@ static inline void init_ref(MotionEstContext *c, > uint8_t *const src[3], > >> }; > >> int i; > >> for(i=0; i<3; i++){ > >> - c->src[0][i]= src [i] + offset[i]; > >> - c->ref[0][i]= ref [i] + offset[i]; > >> + c->src[0][i]= src[i] ? FF_PTR_ADD(src[i], offset[i]) : NULL; > >> + c->ref[0][i]= ref[i] ? FF_PTR_ADD(ref[i], offset[i]) : NULL; > > > > why does this need FF_PTR_ADD() when the pointer is not NULL ? > > FF_PTR_ADD() checks the offset, not the pointer. I don't know if it can > be 0 or not here, so better safe than sorry. > > If you can confirm offset[i] is never 0, then i'll remove it. Does it matter? Adding 0 to a non-null pointer is valid. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".