From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9196149424 for ; Sun, 22 Jun 2025 14:55:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id CB1FC68BE56; Sun, 22 Jun 2025 17:55:43 +0300 (EEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 59DE8687DF0 for ; Sun, 22 Jun 2025 17:55:37 +0300 (EEST) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-606b58241c9so5185499a12.3 for ; Sun, 22 Jun 2025 07:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750604136; x=1751208936; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=QKQRNJa0JvI1MnK1BWHaI+H2XOqrOjhhfYLow4z+/Ag=; b=d8TNQO6Y8C1k6Qe4JxYxkg82kYAxC7b6UNV3qZCfA8B14DxPjMWJHAUvCyjfnL5Ggd xiWARAeOsZI8dYYRDlS6IDkvoQngbW0tgwXFsWhk4DpE2J10dJ0Niy24CYtwr7qsTz07 Gn3naAfMQs4IGgWnoaOvDfrYZTtC4zI8RSR8pIftDncvEae7KAWFZsv6fuTQ3r0sPbP0 lj3glG7F1yGvAff4td9xf4MNxeD+a7jcdYj2jkS+K1hdDzoJRy3zHeYmZW6jJa/M7r1d bKYlWNEGIQzkY6plGvddyN17YpGABn6jTXywBQ3h0wgj0R3WJtxaNjEmxE6JbWh4HU1S kSEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750604136; x=1751208936; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QKQRNJa0JvI1MnK1BWHaI+H2XOqrOjhhfYLow4z+/Ag=; b=F/3FRzj921hAJrlzKe/A8p9crzIUD2JBiQbjK/EEfwF6NchdL03ozLT7mLmfmHzIJw LfRN1kJ7+CJxOWGSvCNWy6imgSHRMp96llASzNCGkw/BODLwVZ2eZuYJE9zCU0/7V6oH 6dPCXMVA8RgxiQ5bVA6LA8Q5pN6Dh+LHy571hwO8qgQ6SQJZ26geR372cZrdJsBDJQ+5 rt6+H0dD33WIA4S981RyMgwPjDi6wqewinaZj0dTZxaUi4E67Xv2hkUBD5bWq3tWnleh xHex3xMyJb37azzAR8fRYdXDyhE0FfOh5VRZmwFxYXHn4u31ORWLVGxPfaptIyPKx8YO GpJA== X-Gm-Message-State: AOJu0YzbewsJTsmegn6aZQeQDuNdkzQMunu1yScI207friDMxxKj0Igs ud2rHS6OhTH2XqqRI15r74wJI0OnYHmzdyzbsTQ/V/SMy7F0fH1U7GC/As3XNpnkc6GD/tYDOA1 L1rt1f+23evbOqfvKMojbmFMFTwmhv1XX/mZT X-Gm-Gg: ASbGncu8JhaUkpCI54zR2xymx0ZgMvGHErU6S7bUgXf0xV5R6nIpHUxXnpHm+qFZhxa /RF/X2VEYqtyCLBmup52AkoQJ1yDDBI2swpDaMfZfNt14CxW5sjyWc0gV+FMgouHImzQjhDi+JR dp+vInyk1dU/xSDDBe4iwVuLV6IDLM/Y2x4EyFceV8 X-Google-Smtp-Source: AGHT+IGu28sVF9OIKtn7GUBrRGPewjyLwwc7MFjY7jiMmH6r+s7hisMJB6eOiyKKNwZ3SddqJXvzAUMJSEY0XtK/sLY= X-Received: by 2002:a05:6402:35cd:b0:607:28c9:c3c9 with SMTP id 4fb4d7f45d1cf-60a1ccad9dbmr8912996a12.6.1750604135548; Sun, 22 Jun 2025 07:55:35 -0700 (PDT) MIME-Version: 1.0 References: <20250622134927.1212-1-jamrial@gmail.com> In-Reply-To: From: Kacper Michajlow Date: Sun, 22 Jun 2025 16:55:14 +0200 X-Gm-Features: Ac12FXxguvZTWGLtyJRpzqHnhvPasdQGoFuTPeMWZsYqMiO0aoS7imc7ZRDP8jM Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc_template: use FF_PTR_ADD to add offsets to a pointer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 22 Jun 2025 at 16:50, Kacper Michajlow wrote: > > On Sun, 22 Jun 2025 at 15:49, James Almer > wrote: > > > > Fixes: libavcodec\ffv1enc_template.c:75:79: runtime error: applying zero offset to null pointer > > Signed-off-by: James Almer > > --- > > Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in > clang-usan also reproduces this on Linux x86_64. > > > https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clang-cl-msvc-asan > > > > libavcodec/ffv1enc_template.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/ffv1enc_template.c b/libavcodec/ffv1enc_template.c > > index aaf82159ee..7edfd2dc0f 100644 > > --- a/libavcodec/ffv1enc_template.c > > +++ b/libavcodec/ffv1enc_template.c > > @@ -72,7 +72,7 @@ RENAME(encode_line)(FFV1Context *f, FFV1SliceContext *sc, > > int diff, context; > > > > context = RENAME(get_context)(f->quant_tables[p->quant_table_index], > > - sample[0] + x, sample[1] + x, sample[2] + x); > > + sample[0] + x, sample[1] + x, FF_PTR_ADD(sample[2], x)); > > Doesn't work. FF_PTR_ADD checks offset (x) only, but the issue here is > that sample[2]==NULL. To be more precise, the patch fixes, "applying zero offset to null pointer", but on next iteration it complains about: ffv1enc_template.c:75:69: runtime error: applying non-zero offset 2 to null pointer - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".