From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2D6054B34A for ; Mon, 5 Aug 2024 00:08:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD7BB68D96E; Mon, 5 Aug 2024 03:08:26 +0300 (EEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 66D3868D7F6 for ; Mon, 5 Aug 2024 03:08:20 +0300 (EEST) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a7a8553db90so1269914966b.2 for ; Sun, 04 Aug 2024 17:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722816499; x=1723421299; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=NoNOOHXiLSMCPQBLOSSQ01LsralBg7eumR5KYUUQl6o=; b=QC1uNVkXqHHwQesRgJbmeNp5t8HpSzwZawmTEIDX9TF8P19ImX/gtKwR+8OwW7r80d MPQTl6+WgqxBXkTPmKsoLDZOoeh41v778Damup5XnYDxa/oyycSIQB+V/c2AxAKvKkmD rIl6baLI5InvCWn2jDYSNNfMoh/j2sdINExsWaHD2HTstnkMNarjgI96RV5yOukrVzKF 2u7l+N1O65jg9MeOtJ7NRqkgcF0HRykS4lVlGWHJBbKJmnFYgDwfYw2ykRcyFGmlZG8d bo+KRbt8jlI6KTjdmcekjyGEly1IykeKQY7642t2qMyO94ws3kuo1pZ2U30S1Mf6KiF9 i1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722816499; x=1723421299; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NoNOOHXiLSMCPQBLOSSQ01LsralBg7eumR5KYUUQl6o=; b=RjcCSce+9C/KgztHCkM4syd+j1I9xuqfIixGgCH6Pp6sE9v+ggqgUL2iqvkBbsvWv9 lx3wbx4WC1ilnGNaPdjk1l81Zo7UZq1K7Ftipd2U6iaWNi3I+u6HuTf5LpfgOo3WSKiQ 0Cay6PR1ULPbAy8BvvQR8Nb4mhxKaq7btAjan+ijJhLaitfvDeeYghaREmfREUtZMFJH ZzJtlk9UUE1h0LXrta/lyQ/v7ZircY9lr6AQE4QFxY4Ydhep7TfdVb5hHVw/30Cng1DT oB3uSdNCExau9TnrgOe7e+S6SwSUmj1S+J2nDsZXcyCAniQKKNkhBIQ28VcZj8sHyNju 9xuA== X-Gm-Message-State: AOJu0YztZGapUckcWvfZfqqxEobD7AJFd+bpZswQIq0BXigYQPUSeuWr 4Jh37dZJSUG7DDuD7zomRYBXNJLM58TIwRUj6zqt4n2qFzSm/jefZhmrMYOMfbE3EY8ucfw9jRo /EI3vPdgx7viRzHStT3xI1uSZDg4IO9Y9DKQ= X-Google-Smtp-Source: AGHT+IHJ1QFpEPu2s7sN73gggHHkL0hWiZNK5mRJXyB/WGrDK5PqvJQFMIseljJq7MdVDi1Xr0xONa3YmVuNi3FXEeY= X-Received: by 2002:a17:907:3e1a:b0:a75:2781:a5c4 with SMTP id a640c23a62f3a-a7dc4ea9ebdmr672639766b.29.1722816499082; Sun, 04 Aug 2024 17:08:19 -0700 (PDT) MIME-Version: 1.0 References: <20240804142315.1430389-1-michael@niedermayer.cc> <20240804142315.1430389-2-michael@niedermayer.cc> In-Reply-To: <20240804142315.1430389-2-michael@niedermayer.cc> From: Kacper Michajlow Date: Mon, 5 Aug 2024 02:08:06 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/4] avformat/jpegxl_anim_dec: initialize bit buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 4 Aug 2024 at 16:23, Michael Niedermayer wrote: > > Fixes: use-of-uninitialized-value > Fixes: 70837/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5089407768526848 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/jpegxl_anim_dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_anim_dec.c > index ac95d3b9617..3045167e1f9 100644 > --- a/libavformat/jpegxl_anim_dec.c > +++ b/libavformat/jpegxl_anim_dec.c > @@ -77,7 +77,7 @@ static int jpegxl_anim_read_header(AVFormatContext *s) > JXLAnimDemuxContext *ctx = s->priv_data; > AVIOContext *pb = s->pb; > AVStream *st; > - uint8_t head[256 + AV_INPUT_BUFFER_PADDING_SIZE]; > + uint8_t head[256 + AV_INPUT_BUFFER_PADDING_SIZE] = {0}; > const int sizeofhead = sizeof(head) - AV_INPUT_BUFFER_PADDING_SIZE; > int headsize = 0, ret; > FFJXLMetadata meta = { 0 }; > -- > 2.45.2 Not sure it is required to zero the whole buffer. I sent an alternative patch some time ago, which clears only the relevant area. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240627004037.1336-4-kasper93@gmail.com/ - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".