From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68B684AF9A for ; Sat, 25 May 2024 11:49:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5046A68D545; Sat, 25 May 2024 14:49:48 +0300 (EEST) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 65F6768D2A3 for ; Sat, 25 May 2024 14:49:41 +0300 (EEST) Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5b295d6b7fbso4742522eaf.0 for ; Sat, 25 May 2024 04:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716637779; x=1717242579; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=MsIFPTiIJOBp447TiHrkpxN+QQnesc9W4ACQwXGb6gk=; b=SfkO1ZcOYQr+54GeVVIERJdNouORTyHZWS/clKwFJq+M5p5BD+s4pe5jPAwfKbNllh iDykdeSjwjjdDJtcTpSb3ZG0YuLTB2zGzLGgBmA8HupTg/8GqnZxIoVNNzl3ZE9rKsxZ SAwPuGdcfNRmFKWiuUc3uP1PcOd2ldINj0XJT+3MNF+XfTSwIWURBYxgCl35Q6kd3FK5 Q7Qy513zRfNxzajgbyNvIILwklEVwOBVhNP6tnO6ogJ9XWIXJULpfOcWBX3S3Uixitke cK8gaSnRKZmFi8dazjpGNc0+Utfr7rt+xQ8J3eLG/r5NwwOXsPmPitpDB9YUc6nJK1dV 0A8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716637779; x=1717242579; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MsIFPTiIJOBp447TiHrkpxN+QQnesc9W4ACQwXGb6gk=; b=IGIQhC7TYHk/1I7Vu5nbHwUUQpP9ai2mXXdhyXiyXW6qcJoUJKp5FH+9wsZBJTsdTH 1/3Oet0ciAUHFL95OXO++qGLK3g2z5zWbL1mMSMzXVCNTyTAnKkCh5ktOC0zTnKwgMxS +nMWY7gONVUib5/f4M8z1y/5jdnQli1YnQInPOmF8O7wYiICoB7Vo5+cTo44s9i67wN3 /GTPYJPPqd+lgt3IO08AKS9jJU9AV9nsKlWXONahi5/u0vZDCIPe+Dd+6dVsqT1Q8Arc baxM04+t56VK1AEq0+f60Awghv5SEhUlKkINMilBlBLOsG+kdxvxY32XecF4+dgRW937 M+xQ== X-Gm-Message-State: AOJu0YwHdW0KnLtLVaJC/27rEy5dKAjyF8kJYJWZvEM5jTfew/4bBHBo Bmw4wWQOpnTAgtoDPEoRObuV9Y0+uue5GM28/arTzL0VAvQC9z7HwFtL+ALlWyhR0IZVL1u4Tz4 x3tnQnLoOIhFIh/T2zGOShaH86WfKSg== X-Google-Smtp-Source: AGHT+IHSPSS2RWM39s5fXPezpSQlVCzaOhhdK/FBrYqLmCrkSdXziMePe18uicuARzqsbgTJLjhLzI23sSo+oNxXTsY= X-Received: by 2002:a05:6870:70a3:b0:245:40a3:963d with SMTP id 586e51a60fabf-24ca151b843mr5087153fac.37.1716637778792; Sat, 25 May 2024 04:49:38 -0700 (PDT) MIME-Version: 1.0 References: <20240525113612.17093-1-ffmpeg@haasn.xyz> In-Reply-To: <20240525113612.17093-1-ffmpeg@haasn.xyz> From: Kacper Michajlow Date: Sat, 25 May 2024 13:48:40 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h2645_sei: loosen up min luminance requirements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 25 May 2024 at 13:36, Niklas Haas wrote: > > From: Niklas Haas > > The H.265 specification is quite clear on this case: > > > When min_display_mastering_luminance is not in the range of 1 to > > 50000, the nominal maximum display luminance of the mastering display > > is unknown or unspecified or specified by other means not specified in > > this Specification. > > And so the current code is correct in marking luminance data as invalid > if min luminance is set to 0. However, this breaks playback of at least > several real-world Blu-ray releases, for example La La Land, Planet of > the Apes, and quite possibly a lot more. These come with ostensibly > valid max_luminance tags (1000 nits), but min_luminance set to 0. > > Loosen up this requirement by guarding it behind FF_COMPLIANCE_STRICT. > We still reject blatantly invalid metadata (wrong value range on > luminance, max set to 0, max below min, min above 50 nits etc.), so this > shouldn't cause any unintended regressions. > > Fixes: https://github.com/mpv-player/mpv/issues/14177 > --- > libavcodec/h2645_sei.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c > index 1deb76c765..7c83747cd0 100644 > --- a/libavcodec/h2645_sei.c > +++ b/libavcodec/h2645_sei.c > @@ -619,11 +619,15 @@ static int h2645_sei_to_side_data(AVCodecContext *avctx, H2645SEI *sei, > > metadata->min_luminance.num = sei->mastering_display.min_luminance; > metadata->min_luminance.den = luma_den; > - metadata->has_luminance &= sei->mastering_display.min_luminance >= 1 && > - sei->mastering_display.min_luminance <= 50000 && > + metadata->has_luminance &= sei->mastering_display.min_luminance <= 50000 && > sei->mastering_display.min_luminance < > sei->mastering_display.max_luminance; > > + /* Real (blu-ray) releases in the wild come with minimum luminance > + * values of 0.000 cd/m2, so permit this edge case */ > + if (avctx->strict_std_compliance >= FF_COMPLIANCE_STRICT) > + metadata->has_luminance &= sei->mastering_display.min_luminance >= 1; > + > if (metadata->has_luminance || metadata->has_primaries) > av_log(avctx, AV_LOG_DEBUG, "Mastering Display Metadata:\n"); > if (metadata->has_primaries) { > -- > 2.45.0 LGTM - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".