Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[Kacper Michajlow <kasper93@gmail.com>]

On Fri, 18 Jul 2025 at 18:53, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Fri, Jul 18, 2025 at 06:49:24PM +0200, Kacper Michajlow wrote:
> > On Fri, 18 Jul 2025 at 18:28, Michael Niedermayer <
> michael@niedermayer.cc>
> > wrote:
> >
> > > On Thu, Jul 17, 2025 at 04:04:38AM +0200, Kacper Michajłow wrote:
> > > > For example this allows --toolchain=clang-asan-usan.
> > > >
> > > > Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> > > > ---
> > > >  configure | 13 +++++++++++--
> > > >  1 file changed, 11 insertions(+), 2 deletions(-)
> > >
> > > does this need some documentation to be updated ?
> >
> >
> > I can update configure help, but not sure what would be a good format.
> > Currently it just lists all possible selections, but this wouldn't work
> now.
> >
> > Would something like this work?
> >
> > --- a/configure
> > +++ b/configure
> > @@ -381,10 +381,10 @@ Toolchain options:
> >    --target-samples=DIR     path to samples directory on target
> >    --tempprefix=PATH        force fixed dir/prefix instead of mktemp for
> > checks
> >    --toolchain=NAME         set tool defaults according to NAME
> > -                           (gcc-asan, clang-asan, gcc-msan, clang-msan,
> > -                           gcc-tsan, clang-tsan, gcc-usan, clang-usan,
> > -                           valgrind-massif, valgrind-memcheck,
> > -                           msvc, icl, gcov, llvm-cov, hardened)
> > +                          (<tool>[-sanitizer[-...]], e.g.
> clang-asan-usan
> > +                          tools: gcc, clang, msvc, icl, gcov, llvm-cov,
> > +                                 valgrind-memcheck,
> valgrind-massif,hardened
> > +                          sanitizers: asan, msan, tsan, usan)
>
> LGTM
>
> thx


Applied patchset, thanks.

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".