From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 928884BAA0 for ; Tue, 22 Jul 2025 19:21:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1CBC668D52C; Tue, 22 Jul 2025 22:21:45 +0300 (EEST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8E92D68D51E for ; Tue, 22 Jul 2025 22:21:38 +0300 (EEST) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-606b58241c9so9642883a12.3 for ; Tue, 22 Jul 2025 12:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753212097; x=1753816897; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=eURrPyPvU224AbFiwo/aEYLvTdzZu00ULM9DC2DJaMc=; b=MLw2ZnBc/nOJzy0cvIxTZUP664j71VT2sCYXahArOvcpdO6+ggL8KYuJNvUevQC+bj s9plIRLOe74xFfGO15y6Qo9GotKj4V3X7WrBhgg8GPR2YLti0shEhYqWmqRAStIrq2XQ 1Zt/ZbfjDSouV7vzalVHQLiNZqlDWeaNJdldh3KParPYeL6SDnEf5qWcD8YNSyxjSlxY uuhp0tXRYCF/4XYcIzYK47T+NjeyBBtbKgqtlwK8Iag1IVBZQMvcqMbQIGBVEzPjj3/M 0pmIVf5BVTLm41L2Y1IOgFQ9snux6IkzM+RMFtRzSIq4Op00qcdxMYf2T43F581qaIBl KiNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753212097; x=1753816897; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eURrPyPvU224AbFiwo/aEYLvTdzZu00ULM9DC2DJaMc=; b=A3hYb7OQbRcjwzjm+VVgEHXe60U061a/ko+Qpe4EXGNCe7BbImI1HnMKspJL+SRBnQ eB+knKo+/zD+AXnf/rOk4SSfYY8tFsOBCdp93JulEFZgPeulw8tKGgrioSKPQj9ELREk qpMn+4Gzj2AODkyXIURq3GmW3USedZVoPi4f3cEI9BOUfYwXzleQumP1yeqXPl2Y7mjO GW76UsG9zWPRF1SrMZGQ4O1SrdEgu0G4AHfAv2nsaEnYHQZ+QeXr+Gkm1z5ar6wUXow1 n9xd2sPaXmEUnc3Ipd8iekZk26PzIiJ3uLiC1u9RReg/TGLG2tmcApZH7RqWg95J7RjZ x/3A== X-Gm-Message-State: AOJu0Yw73NJZh68OBeayXBp0p1go/uwbG2gim1Eq4rbbt4KIDfgX5rBH J3mJymrLP10pJOvtvDJ7Wu8yTpH8QFjCQph3sELR7GETzQDUFZo1Zw3b4S60IBE3XkcTdaSFTMY ToyuPmsLALlDEeypxEfkOB6gA1Y7EmpLA2w== X-Gm-Gg: ASbGncvRCbbuh5l8uF/uDQxd5P4jvNxUxjnEFHqKZt4J2DQFUAunhlOt+NYYwepUnJY D+qtTL16eAQPAHtwabR8/mPJ3tCmp8Ex5NJYInc36IYXuNr0sSW0Vjmtc3uLdBYjEFFChywUkr8 WU5ia0S6K6ccPekU594gNobBBIYWLXL2U+uDwXrOFQNM8HuisUz0dw+orZYm5qGcnLh0JIhor+u T03 X-Google-Smtp-Source: AGHT+IHxVsPsFlfq8IZMM7t1Cret5/69Z/KWq3+i/PFj4YmhulgGEGd3Ghgx5eAa63m8xzyptPWvhwjYb0/IZiNolYw= X-Received: by 2002:a50:a459:0:b0:5fb:e868:8730 with SMTP id 4fb4d7f45d1cf-6149b42fe8emr101529a12.10.1753212097047; Tue, 22 Jul 2025 12:21:37 -0700 (PDT) MIME-Version: 1.0 References: <20250722162432.3328-1-jamrial@gmail.com> In-Reply-To: <20250722162432.3328-1-jamrial@gmail.com> From: Kacper Michajlow Date: Tue, 22 Jul 2025 21:21:03 +0200 X-Gm-Features: Ac12FXzoaorfhk186Hh0_2YIOca-2MK_pwjWg9siS-mB_F76_yqeZz9TvWlBNp8 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/opus/silk: don't assume stereo when calling silk_decode_frame() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 22 Jul 2025 at 18:25, James Almer wrote: > > Fixes use-of-uninitialized-value under MSAN. > > Signed-off-by: James Almer > --- > libavcodec/opus/silk.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/opus/silk.c b/libavcodec/opus/silk.c > index 97bb95037c..ffa2ec996b 100644 > --- a/libavcodec/opus/silk.c > +++ b/libavcodec/opus/silk.c > @@ -844,8 +844,10 @@ int ff_silk_decode_superframe(SilkContext *s, OpusRangeCoder *rc, > } > > for (i = 0; i < nb_frames; i++) { > - for (j = 0; j < coded_channels && !s->midonly; j++) > - silk_decode_frame(s, rc, i, j, coded_channels, active[j][i], active[1][i], 0); > + for (j = 0; j < coded_channels && !s->midonly; j++) { > + int active1 = coded_channels > 1 ? active[1][i] : 0; > + silk_decode_frame(s, rc, i, j, coded_channels, active[j][i], active1, 0); > + } > > /* reset the side channel if it is not coded */ > if (s->midonly && s->frame[1].coded) > -- > 2.50.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". LGTM - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".