From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 953D54CFAE for ; Tue, 12 Aug 2025 16:00:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 77A7B68CCF4; Tue, 12 Aug 2025 19:00:14 +0300 (EEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BC8BF68C2C3 for ; Tue, 12 Aug 2025 19:00:07 +0300 (EEST) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-61592ff5df8so7069164a12.1 for ; Tue, 12 Aug 2025 09:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755014406; x=1755619206; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rBF/EugNrHZdDtZo/Yd99mREu2sddEVpo99qJ9qxO1o=; b=RZ7i/YREMfEpqigQkTaWlh4jutIbgaeHM5EyWbY79Y6+GdfCl+mA+kD2OufzHnfOFP igSdM0CFj90AfhgeYxQGNf+2U0XzGdzQd235IaOf8H+MoOqfgjzTM+5iFecnHxtQjzKx 24CjpRDBvPH7SZWAA1xCPwuKHqgSQoiWsNv0J/g8LiOGYLEysv+kjev8NoRU1H1WP8ZC 0Z0q7AaHp09Rc/Us8pEzXQ6EPWzfmSqfAT6Q1GfuS01Is5UaTtwERzz+NnEYZ86EBsLW bHuO6fu7PC5PjUZL6GHXE7qtAZa6t4bzVgbacvGLOrf+44cA+4xHWfiIny61fZ4feuhB 1UJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755014406; x=1755619206; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rBF/EugNrHZdDtZo/Yd99mREu2sddEVpo99qJ9qxO1o=; b=vb9KNq/Gkz3mhyxPwBYB4goOqhPyG3ksDicIOLEKvCvsgB2qXfJYov/ORgZnnk042z GQnYAMxGpWjETVtHvIfJ+T8SfsO9gpMp3+hS8n4OdpnXW0WFNTcBE3Xf/fXID7Bw2SI+ GrFEcwqEdTBv6FWDUC931EVJkfv2Z95lSBmWAXlTN2nlPPfYSSFUHicXXwqwa16zsEvY et+zAQ5ybzYxTk47ykndMOsOOg2Ot/K2hn8mijWts84TjmX/KF7dUpOLPuK4iKVbuukr ae3DxSzOk/pPRy1ATz21F7kSPLF7Ni7qGt5MrgHROegbLUoZt+hQiguj0mQ5s9GP27t6 bAaA== X-Gm-Message-State: AOJu0YwjiAyWOubLDY+AMC190HZFHkngSnedew5RWVVLUSVkHQ5EUl4d llhGAzU7FnrXGc9r1X8fnqbscEbacszjxf6sdAyT5xBYqlOLRbejV6rZuB6piTPnj8zFnSd3BsI P5XPQHH2/QcWjaQ6DC0d7Rpz/2VnLeo0wK38x X-Gm-Gg: ASbGncu/kzFIQCsk6Cgsn/bG6Yad3OrIvNqDLys6yTSQi+ZLPEAdl3OOzyoil0C7HGU DQljhNaezTzaNe/rVyIW3JILmz5lbTZQcGNjPaLFsGyGmtL9GBiJ/fHfqarrPD3MAGNmiRpmrK/ BUIKtdV5f1dO6/Jl7v4RVlGIRokfL1x7wRodzP9dhm62jPl/qnZgr+/hKe2pEkQ0QHfpWlUsI7a Eb4 X-Google-Smtp-Source: AGHT+IHk+pLcDXjFX+D1goc0BdQXCDl9AEQCcjnzCdN9ocTkaLuhtb7l5WvVz2K2wj7F50Jo68GUtN/4XEXed+m/AmA= X-Received: by 2002:a05:6402:84a:b0:618:66c5:85e1 with SMTP id 4fb4d7f45d1cf-6186786f334mr258241a12.32.1755014406074; Tue, 12 Aug 2025 09:00:06 -0700 (PDT) MIME-Version: 1.0 References: <20250812090205.A5F4D68B0ED@ffbox0-bg.ffmpeg.org> <20250812113408.GB24045@haasn.xyz> <1bfcff88-d626-475b-a506-9d60feb5177e@gyani.pro> <20250812115108.GB29347@haasn.xyz> In-Reply-To: From: Kacper Michajlow Date: Tue, 12 Aug 2025 17:59:44 +0200 X-Gm-Features: Ac12FXzjIiwbS8EZlanXEYKIMF4p2F6lJQyAQm19T7Z5Rs4--XrqZkXfXupq7yo Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tristan Matthews Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 12 Aug 2025 at 14:35, Tristan Matthews via ffmpeg-devel wrote: > > > > > > Hi, > > On Tuesday, August 12th, 2025 at 5:51 AM, Niklas Haas wrote: > > > On Tue, 12 Aug 2025 15:08:10 +0530 Gyan Doshi ffmpeg@gyani.pro wrote: > > > > > On 2025-08-12 03:04 pm, Niklas Haas wrote: > > > > > > > On Tue, 12 Aug 2025 11:16:19 +0200 Nicolas George george@nsup.org wrote: > > > > > > > > > ffmpeg-git@ffmpeg.org (HE12025-08-12): > > > > > > > > > > > Author: Niklas Haas git@haasn.dev > > > > > > AuthorDate: Mon Aug 11 15:57:24 2025 +0200 > > > > > > Commit: Niklas Haas ffmpeg@haasn.dev > > > > > > CommitDate: Tue Aug 12 09:01:39 2025 +0000 > > > > > > Pushing after less than 24 hours without approval by the maintainer is > > > > > > absolutely unacceptable, forge or no forge, and a spit in my face for > > > > > > the time I invested into starting to look at the code, thankfully > > > > > > limited. > > > > > > In https://ffmpeg.org/developer.html#Patch-review-process it says: > > > > > > > > > After a patch is approved it will be committed to the repository. > > > > > I don't see anything about a time-frame requirement here. > > > > > > It's the last point in > > > https://ffmpeg.org/developer.html#Patches_002fCommitting > > > > > > I see that, but note: > > 1) the PR was approved > > 2) nobody is listed as a maintainer for these filters > > > > Regardless, I still think we should then just establish a clear pipeline > > here to prevent this sort of discussion from happening in the future. > > > > Timo, can something like the VLC merge bot be implemented in ForgeJo? > > > > For reference, that's https://code.videolan.org/Garf/homer-bot > Obviously that's gitlab specific but may help inform some choices here. Because of course there is homer-bot... I think everyone seen marge-bot too https://github.com/smarkets/marge-bot (also GitLab specific) Forgejo is API compatible with GitHub, so we could reuse solutions that work there. Also in general Forgejo itself is more basic in itself, doesn't support marge queues/trains, so any solution would have to be a custom bot. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".