From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 893944AB53 for ; Mon, 12 Aug 2024 00:34:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F86968D97D; Mon, 12 Aug 2024 03:34:23 +0300 (EEST) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E34A168D80D for ; Mon, 12 Aug 2024 03:34:16 +0300 (EEST) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2f149845fbaso40231771fa.3 for ; Sun, 11 Aug 2024 17:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723422856; x=1724027656; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=jKY0id7WhunckosHfbRF/3gWezN3Cdzbn6il9p+DD6s=; b=mihQXheORdUgKMqxJbjOfwfmGUxfElgqtn9Zs168DLPNjb3Gy+jMxOBC+q8BNcoyF2 SqZ8NsJDW7IQ6SYDKwQS4RjVBvgn2XtbW+YQ+iP/30fbC0aOWLpxigXPNcwEeYHVCx/R gkPTI4oZb3Ld9EtmloKw/k6HjcLsFP1ScA2dqrEN46XgXotnN4DHS+15IuqHoIJ5gKjc mOJ/PSB4w9cPCr6AUbOy9cb6E619zMQdxe60+TsPfHAFojjtM0CRSF4+28+tU57jOLmS pTSY6ngP6i/SV82SEtfCsRznUVsZVDSs1j9dDHRWAvaRUhKBdacuWjbFV30LrnoAaSEY Ln2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723422856; x=1724027656; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jKY0id7WhunckosHfbRF/3gWezN3Cdzbn6il9p+DD6s=; b=KjEs4FxugUXvNyF2ME6pTjdnDUl6sIIqRM3zqUFa0n6s2PWy/As3xIJt9FGgIKizVK td5l+oGYuw1QhXhRirYUcphqJWZSPByCOG9hw907c8trpSe0XsApC8nsFCnoeboYBeFU RQ0TmFtoQrQMmVk0QlpW+na6VerLlRoEQAaVXf9p8UHykBiauQfBQzhlPFNz9pFk04hY 4eGRJU5ZkbF8pT92ZqtI/Nv6t8/OCryRykdm520Mbs7Dsk4uJLXkssDhPQwYnUcCU9MV 9OtqcKvi8KpUYr6LroLijfVPUFgf/qmfe2pW+Anm+glBiNwy9j8t/pa24MGnzj+iuaz4 GddA== X-Gm-Message-State: AOJu0Yz1VI1sDK+qm1fKiHJ44IbMO1K3O+2QNgimqt1R2ZbFfpiwIpFj nniZC8EhPQX8pYfKRC5NzJZb3st5nVaz32Hq5NcXR/jdxmmhD+ziUdIzaeXkycKy6ph+5fODSjt iRKUhutLM2LCm5SYY/50j9P9Px4xhAy4grN0= X-Google-Smtp-Source: AGHT+IHE8Z4K4+K12mx1WPJSKnnHa/iLT15eeqjHwjX8gbV6o7i9cp4sX6l2trvOLKp/WVn8Jw+199ZBLcE0jvGxeUs= X-Received: by 2002:a05:6512:3d1f:b0:52c:dc6f:75a3 with SMTP id 2adb3069b0e04-530ee9d1aa6mr6234675e87.40.1723422855379; Sun, 11 Aug 2024 17:34:15 -0700 (PDT) MIME-Version: 1.0 References: <20240811085902.181819-1-michael@niedermayer.cc> In-Reply-To: From: Kacper Michajlow Date: Mon, 12 Aug 2024 02:33:57 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] tools/target_enc_fuzzer: Add slices and level for FFv1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 12 Aug 2024 at 02:06, Kacper Michajlow wrote: > > On Sun, 11 Aug 2024 at 10:59, Michael Niedermayer > wrote: > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > tools/target_enc_fuzzer.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/target_enc_fuzzer.c b/tools/target_enc_fuzzer.c > > index 059d7830710..59c2db4bb42 100644 > > --- a/tools/target_enc_fuzzer.c > > +++ b/tools/target_enc_fuzzer.c > > @@ -149,6 +149,8 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { > > av_dict_set_int(&opts, "coder", coder, 0); > > av_dict_set_int(&opts, "context", bytestream2_get_byte(&gbc)&1, 0); > > av_dict_set_int(&opts, "slicecrc", bytestream2_get_byte(&gbc)&1, 0); > > + ctx->slices = bytestream2_get_byte(&gbc); > > + ctx->level = bytestream2_get_byte(&gbc) % 6 - 1; > > Note sure that's correct. Depending on the codec numeric level value > may differ, but generally it has higher value. Like 62 for "6.2" in > h264 case, or 186 for "6.2" for h265 case. I would just remove `% 6 - > 1` and let fuzzer find interesting values for each codec. Oh, sorry. From the diff I couldn't see that it is in `case AV_CODEC_ID_FFV1`, so my remark is invalid. Still might be useful to also test invalid `level` values. > - Kacper > > > break;} > > } > > } > > -- > > 2.45.2 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".