From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 552E34F764 for ; Sun, 22 Jun 2025 14:58:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8C94B68BF86; Sun, 22 Jun 2025 17:58:10 +0300 (EEST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E520168AF3B for ; Sun, 22 Jun 2025 17:58:04 +0300 (EEST) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-607ea238c37so6647868a12.2 for ; Sun, 22 Jun 2025 07:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750604283; x=1751209083; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=cZ2Fl+FPr+zAv2enPJqCOz4BnTSTBhCmSxdciMJFl3g=; b=A0xoqAgIBsmDnTC8Qh6XE/4BxbvJoiqbOlfe691kAavJJl35XYxFNBOJY2qC2wKYs4 G8JQJu4vdjLavf2/UZiDUCFwKY0al22OzTvwUD1XUiwgVfRY7WGFXmXQJnaa1JCxsN9L eqoKjGZDBm16ylsTEfXSKZjomu0P1HEsnHPp98zTI37oMMLfUmjmWYEVOl8RBcbez4yy QC6mGDNcYxKIKGD5Bk+NMlhIyorSUvALbRp3nhy6Xysz65Nfi77wAPQp8vRCYPPzrUYQ tQKs49X7nq33T5X99DGU3WcyGCYPZwtdtxHzb84l5lB8AmxzfV86zt2AnDfqbbBi8dV1 Sztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750604283; x=1751209083; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cZ2Fl+FPr+zAv2enPJqCOz4BnTSTBhCmSxdciMJFl3g=; b=CAfBe2X1NRX7U7E2Ab6Ei0pd5Us4y1q9hqu7t3tZ7EffjoiauX2qWGT3U11LIyuysz +VTf9EW+kwd+hR0M+glGZ9vCVbb5BT4DJsBpeXEuHTptvE9T3GU2dllEQihQyU6oZtyE /nnOpZ+qO93lGswivsSWnTWqqDfFETxN519QyrOtV24Wfsk5F+rD8V6xrm8Ke7dPVlip /oUpr12B6fltbMrmX9+0uBXEvpUcZefLVOVspIhtEunYwfyl+JvXIMx4D019Vk33XzBl JaGrZt4ZC5ECFu5/7mpEx3C3vhy8ZqjnFiEglIYFGHD4jdES+AyXniA6X6I46YF8H96M dK7Q== X-Gm-Message-State: AOJu0Yx84Tae/aa+ibLBrESD/1DHyYdkaWPxLmjsAlNJHBAD7cYf4ha9 IWduSbrnPyqiEmpH1dajEC55ZA/nUur4QKkXBi/9BDYs/cYdUAsreEtzLTUnSuMcj1XR7EKu9vj VRCPcUhzFV0d0H1yX0deCIo4AiB2MYtuzXzJd X-Gm-Gg: ASbGncvIcugH/ra5yHdnXDDfyMf5cr2CK+t3LFrAX7qJhasmlHKIiBTyE4ihsHuchvT XfJIMidddhJ6ecBuWjL1L/cd2C9kEmfBD2RjoNdWWjco8jmVgASlNpy+269+ikF0c7afUakpTti CE0OgHv3PI2Ny2heB6g5tqxkXTCQZRxuK0cug0YHdk X-Google-Smtp-Source: AGHT+IGx6GVxCAvEk7qPoQsV8NDU7QDIBjsxnwfWqFjR2ONPso/v6Psee8fVWimVHRUzzmW8/LOPBwoeuoYJNNBMD3M= X-Received: by 2002:a05:6402:518f:b0:607:35d8:4cf4 with SMTP id 4fb4d7f45d1cf-60a1cd3258emr9123885a12.25.1750604283155; Sun, 22 Jun 2025 07:58:03 -0700 (PDT) MIME-Version: 1.0 References: <20250622135208.1229-1-jamrial@gmail.com> <20250622135440.1287-1-jamrial@gmail.com> In-Reply-To: <20250622135440.1287-1-jamrial@gmail.com> From: Kacper Michajlow Date: Sun, 22 Jun 2025 16:57:42 +0200 X-Gm-Features: Ac12FXwNAXk_OzBSqmb2vc8cCw0k0g3B5W2dyD_DDWAwTe5_DiLEzp5vrsieBgQ Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/mss2dsp: use FF_PTR_ADD to add offsets to a pointer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 22 Jun 2025 at 15:54, James Almer wrote: > > Fixes: libavcodec/mss2dsp.c:59:14: runtime error: applying zero offset to null pointer > > Signed-off-by: James Almer > --- > Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can be seen in > https://fate.ffmpeg.org/report.cgi?time=20250622122557&slot=amd64-clang-cl-msvc-asan > > libavcodec/mss2dsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mss2dsp.c b/libavcodec/mss2dsp.c > index cc39dd637f..ace92ef9c7 100644 > --- a/libavcodec/mss2dsp.c > +++ b/libavcodec/mss2dsp.c > @@ -56,7 +56,7 @@ static av_always_inline void mss2_blit_wmv9_template(uint8_t *dst, > } > } > } > - mask += mask_stride; > + mask = FF_PTR_ADD(mask, mask_stride); I can confirm this fixes the mss2-region test. Though I didn't check the code if similar to other example wouldn't "non-zero offset" warning come up. At least the test passes. Thanks. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".