From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 21EED4B370 for ; Mon, 5 Aug 2024 00:10:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 502FD68D97D; Mon, 5 Aug 2024 03:10:39 +0300 (EEST) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B83E68D956 for ; Mon, 5 Aug 2024 03:10:32 +0300 (EEST) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2f16767830dso23013271fa.0 for ; Sun, 04 Aug 2024 17:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722816631; x=1723421431; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=FqB236IQYiPg/mCwCGcSyz8+CzxhHzYQUBhhwbpevkE=; b=JkXooMnM0IxvkdqH+XkNW/attZ7NrijB+ETyr3unbexCglVnARCjVYQZANlLkG0sFZ 6uaMkkc25IfmSZVYjMOgOJuGkFPossBFAbgTdWGIiFMlJO7QTOXQRPfupk+IZN5X1X30 waRXqdk4C6lqLTdJ52UjNqMltoN5vlAvJ4TI517PA1oUdKr67Um2+GvG5ixzXnKQs+ce xhiWlYknH/MzWsoJhTk9MeEJca7A9qQWPco/0+TQk+L69wW+nqlhrBtVFpvhQn0Kk7Da 3gEMtLYaIqBR2qcjL008FnhjNMrNRQu3SmsxYoNiMJXFRCesVdO5h2+8UMOmStwvyhQi bvIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722816631; x=1723421431; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FqB236IQYiPg/mCwCGcSyz8+CzxhHzYQUBhhwbpevkE=; b=QN7+OoWlQmWvMGwxANbUR3KEBWC2Kefb6pBG6wESdI0DZmH4O6YTVjLMy1w/Oeeg0s axgqVyU3wPUJvV/dlNvLb9MP/kv3jzwi9vlw5RZUuZZQNIz3RXGD4HyhRqav5mIlriyx IDUACqxPS5c1NJRYl0vAeV5FVv4yUbUbRVw/8fqi1ILvzng++HolT0a7NkvoxrXKblrK /hPrhvj+hsln/iKuJUYIDx1N2NULXf/zjD30640crZjj/rar3XLC8tcuZFUb0V300T/Q C+A2pvGvvDISwmCvoPHg5H5Tyu1nkDa4IlnTcchargktKq3ckp3zcTfQH6EoACYHyqWc lidg== X-Gm-Message-State: AOJu0YzHVFOYgIuA73F974W1BbxtCjwWk2WsVSXStpHylM3hDfEAe3ns si0NF0lD7QGyWvXE6if1CW52tJ+TK/Hq7oLS6c1S5LK0eowiuDkhxmeAAGNTTmE2aF1DySlKLbE Q+tfIuO42HMBi+j9Y7l0cfAWCzDboyCTK6Oo= X-Google-Smtp-Source: AGHT+IHT6jcw51kpjk3e+iCMzkOZHHdJ2FtAWVwlJc+sh4x8DVu8Oi2ofs9v0AmHMcHwOVbUjLJAFPZ8oFZz0SaCwZc= X-Received: by 2002:a2e:4941:0:b0:2ef:28d2:39cc with SMTP id 38308e7fff4ca-2f15aa7187bmr67451411fa.3.1722816631007; Sun, 04 Aug 2024 17:10:31 -0700 (PDT) MIME-Version: 1.0 References: <20240804205309.1978196-1-michael@niedermayer.cc> <20240804205309.1978196-3-michael@niedermayer.cc> In-Reply-To: <20240804205309.1978196-3-michael@niedermayer.cc> From: Kacper Michajlow Date: Mon, 5 Aug 2024 02:10:18 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 3/8] avformat/img2dec: Clear padding data after EOF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 4 Aug 2024 at 23:01, Michael Niedermayer wrote: > > Fixes: use-of-uninitialized-value > Fixes: 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5179190066872320 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/img2dec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index 20b1bc31f6a..3389fa818e9 100644 > --- a/libavformat/img2dec.c > +++ b/libavformat/img2dec.c > @@ -563,6 +563,7 @@ int ff_img_read_packet(AVFormatContext *s1, AVPacket *pkt) > } > goto fail; > } else { > + memset(pkt->data + pkt->size, 0, AV_INPUT_BUFFER_PADDING_SIZE); > s->img_count++; > s->img_number++; > s->pts++; > -- > 2.45.2 I've also had this one (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240627004037.1336-3-kasper93@gmail.com/), but probably it is better to do it only in the else branch here. So, LGTM. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".