* [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs @ 2024-02-07 2:10 Kacper Michajłow 2024-02-07 2:47 ` Lynne 0 siblings, 1 reply; 3+ messages in thread From: Kacper Michajłow @ 2024-02-07 2:10 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Kacper Michajłow Drop per frame decode messages to AV_LOG_TRACE level. Signed-off-by: Kacper Michajłow <kasper93@gmail.com> --- libavcodec/vulkan_av1.c | 2 +- libavcodec/vulkan_h264.c | 2 +- libavcodec/vulkan_hevc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c index 9730e4b08d..c7d5a54012 100644 --- a/libavcodec/vulkan_av1.c +++ b/libavcodec/vulkan_av1.c @@ -530,7 +530,7 @@ static int vk_av1_end_frame(AVCodecContext *avctx) rav[i] = ap->ref_src[i]->f; } - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n", + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n", vp->slices_size, ap->tile_list.nb_tiles); return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp); diff --git a/libavcodec/vulkan_h264.c b/libavcodec/vulkan_h264.c index 39c123ddca..c918dbaa13 100644 --- a/libavcodec/vulkan_h264.c +++ b/libavcodec/vulkan_h264.c @@ -529,7 +529,7 @@ static int vk_h264_end_frame(AVCodecContext *avctx) rav[i] = hp->ref_src[i]->f; } - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", vp->slices_size, hp->h264_pic_info.sliceCount); return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp); diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c index 033172cbd6..0f6f2e775b 100644 --- a/libavcodec/vulkan_hevc.c +++ b/libavcodec/vulkan_hevc.c @@ -903,7 +903,7 @@ static int vk_hevc_end_frame(AVCodecContext *avctx) rvp[i] = &rfhp->vp; } - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", vp->slices_size, hp->h265_pic_info.sliceSegmentCount); return ff_vk_decode_frame(avctx, pic->frame, vp, rav, rvp); -- 2.42.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs 2024-02-07 2:10 [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs Kacper Michajłow @ 2024-02-07 2:47 ` Lynne 2024-02-07 14:34 ` Kacper Michajlow 0 siblings, 1 reply; 3+ messages in thread From: Lynne @ 2024-02-07 2:47 UTC (permalink / raw) To: FFmpeg development discussions and patches Feb 7, 2024, 03:11 by kasper93@gmail.com: > Drop per frame decode messages to AV_LOG_TRACE level. > > Signed-off-by: Kacper Michajłow <kasper93@gmail.com> > --- > libavcodec/vulkan_av1.c | 2 +- > libavcodec/vulkan_h264.c | 2 +- > libavcodec/vulkan_hevc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c > index 9730e4b08d..c7d5a54012 100644 > --- a/libavcodec/vulkan_av1.c > +++ b/libavcodec/vulkan_av1.c > @@ -530,7 +530,7 @@ static int vk_av1_end_frame(AVCodecContext *avctx) > rav[i] = ap->ref_src[i]->f; > } > > - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n", > + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n", > vp->slices_size, ap->tile_list.nb_tiles); > > return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp); > diff --git a/libavcodec/vulkan_h264.c b/libavcodec/vulkan_h264.c > index 39c123ddca..c918dbaa13 100644 > --- a/libavcodec/vulkan_h264.c > +++ b/libavcodec/vulkan_h264.c > @@ -529,7 +529,7 @@ static int vk_h264_end_frame(AVCodecContext *avctx) > rav[i] = hp->ref_src[i]->f; > } > > - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > vp->slices_size, hp->h264_pic_info.sliceCount); > > return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp); > diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c > index 033172cbd6..0f6f2e775b 100644 > --- a/libavcodec/vulkan_hevc.c > +++ b/libavcodec/vulkan_hevc.c > @@ -903,7 +903,7 @@ static int vk_hevc_end_frame(AVCodecContext *avctx) > rvp[i] = &rfhp->vp; > } > > - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > vp->slices_size, hp->h265_pic_info.sliceSegmentCount); > > return ff_vk_decode_frame(avctx, pic->frame, vp, rav, rvp); > I don't agree with this, without this print, you have no idea if hardware decoding is even being used. MP4 parsing is far too noisy than a single print per frame. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs 2024-02-07 2:47 ` Lynne @ 2024-02-07 14:34 ` Kacper Michajlow 0 siblings, 0 replies; 3+ messages in thread From: Kacper Michajlow @ 2024-02-07 14:34 UTC (permalink / raw) To: FFmpeg development discussions and patches On Wed, 7 Feb 2024 at 03:47, Lynne <dev@lynne.ee> wrote: > > Feb 7, 2024, 03:11 by kasper93@gmail.com: > > > Drop per frame decode messages to AV_LOG_TRACE level. > > > > Signed-off-by: Kacper Michajłow <kasper93@gmail.com> > > --- > > libavcodec/vulkan_av1.c | 2 +- > > libavcodec/vulkan_h264.c | 2 +- > > libavcodec/vulkan_hevc.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c > > index 9730e4b08d..c7d5a54012 100644 > > --- a/libavcodec/vulkan_av1.c > > +++ b/libavcodec/vulkan_av1.c > > @@ -530,7 +530,7 @@ static int vk_av1_end_frame(AVCodecContext *avctx) > > rav[i] = ap->ref_src[i]->f; > > } > > > > - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n", > > + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n", > > vp->slices_size, ap->tile_list.nb_tiles); > > > > return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp); > > diff --git a/libavcodec/vulkan_h264.c b/libavcodec/vulkan_h264.c > > index 39c123ddca..c918dbaa13 100644 > > --- a/libavcodec/vulkan_h264.c > > +++ b/libavcodec/vulkan_h264.c > > @@ -529,7 +529,7 @@ static int vk_h264_end_frame(AVCodecContext *avctx) > > rav[i] = hp->ref_src[i]->f; > > } > > > > - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > > + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > > vp->slices_size, hp->h264_pic_info.sliceCount); > > > > return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp); > > diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c > > index 033172cbd6..0f6f2e775b 100644 > > --- a/libavcodec/vulkan_hevc.c > > +++ b/libavcodec/vulkan_hevc.c > > @@ -903,7 +903,7 @@ static int vk_hevc_end_frame(AVCodecContext *avctx) > > rvp[i] = &rfhp->vp; > > } > > > > - av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > > + av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n", > > vp->slices_size, hp->h265_pic_info.sliceSegmentCount); > > > > return ff_vk_decode_frame(avctx, pic->frame, vp, rav, rvp); > > > > I don't agree with this, without this print, > you have no idea if hardware decoding is even being used. With this print you have no idea either. Unless you know only Vulkan decoder prints those messages, (that alone is a reason to remove them), there is nothing indicative about Vulkan or even hardware decoding in those messages, AVClass item_name is just "h264". [ffmpeg/video] h264: Decoding frame, 15808 bytes, 1 slices [ffmpeg/video] h264: Decoding frame, 17203 bytes, 1 slices [ffmpeg/video] h264: Decoding frame, 16862 bytes, 1 slices [ffmpeg/video] h264: Decoding frame, 15989 bytes, 1 slices Also debugging if something like hw decoding is working is precisely AV_LOG_TRACE or AV_LOG_DEBUG, not AV_LOG_VERBOSE, which in my opinion should be still useful information for the end user, not only for tracing purposes. "Using Vulkan hwdec on device foo" can be printed once at the beginning of decode... "Decoding frame" messages are in general not useful at all. > MP4 parsing is far too noisy than a single print per frame. "They are bad, so I can be bad too." is non-argument. Also I don't see exactly what you are referring to, in my experience MP4 is less noisy than a "Decoding frame" per each frame. It really shadows valid information in the log during decoding. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-07 14:35 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-02-07 2:10 [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs Kacper Michajłow 2024-02-07 2:47 ` Lynne 2024-02-07 14:34 ` Kacper Michajlow
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git