Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

[Kacper Michajlow <kasper93-at-gmail.com@ffmpeg.org>]

On Sat, 28 Jun 2025 at 16:35, Kacper Michajlow <kasper93@gmail.com> wrote:
>
> On Mon, 2 Jun 2025 at 17:06, Rémi Denis-Courmont <remi@remlab.net> wrote:
> >
> >
> >
> > Le 31 mai 2025 20:40:40 GMT+03:00, Marton Balint <cus@passwd.hu> a écrit :
> > >
> > >
> > >On Sat, 31 May 2025, Michael Niedermayer wrote:
> > >
> > >> This allows adjusting them to exactly match whatever is fastest on
> > >> a given CPU for each type.
> > >
> > >Did you use some tool to make this patch, or it was just manual work?
> > >
> > >Can't you use C11 generics to make this somewhat automatic?
> >
> > So I tried to do exactly that, but you need multiple levels of generics. In the end, either the compiler crashed or my entire build system crashed because the compiler consumed too much memory.
>
> Could you elaborate on the problem? I too think that _Generic is the
> way to go here, instead error-prone manual dispatch of the MIN/MAX
> functions. Also with _Generic we can substitute with an inline
> function to fix double evaluation issues. (and whole patch would be
> few lines instead of changing whole source tree)
>
> If you let us help you fix the problem you were facing, I think we can
> arrive at a good solution for the problem here.

That being said, what's wrong with that solution?
https://godbolt.org/z/To3hvf577 Of course this won't work for const
initializers in C, but I suspect those can be handled differently if
needed and it's not a big deal.

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".