From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 70BA947508 for ; Mon, 11 Dec 2023 04:20:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81C4768D192; Mon, 11 Dec 2023 06:20:30 +0200 (EET) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A9CC68D0C4 for ; Mon, 11 Dec 2023 06:20:23 +0200 (EET) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-1fb14047fe7so2441228fac.1 for ; Sun, 10 Dec 2023 20:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702268421; x=1702873221; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=L9zuC9eOjJlr2umW5ZIiX+LuC/wNoy2QEV7tqSLqfVo=; b=BEUx7hUrC9DBCxiLSDAwXIMjyppFEpWLreljWez70LmE9UTES/nX8AHrSQJvq7wmXe mrzL/0DVF9xLD7EDp1TWu2wO4AU3ZTGeqAU55J/oqwPM0dX+fXoctlJzLePOdZDYraCI l3ELrfzfAj8GjRBP2GlHaeK3gzOv+2N+HEesUMtJU2f03MsR13FTq0WRTNjDn6KJlwkA lYKVAzpzf3LwozH98B98n8YdMHmWxECx/7XemCG3pgjRuAxGAKVTsbwNnaRcQRN5STST 5zlvDoqL+9Mz5Vfp+Z+b1GM7XT+DeSQtBGi2H5OPHnl7QWg5rnd+4EGQaiZ5rXtkYpAm ypVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702268421; x=1702873221; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L9zuC9eOjJlr2umW5ZIiX+LuC/wNoy2QEV7tqSLqfVo=; b=UuiEyCHMGv/Tk+fzpEPz9pv1IBHhobK9rY6Ewh+DPUjIpTQ/1aUZle/amgy7e27X99 7s9aTT3tWLVPlu5HyEbeECgkts7Afuy9HCtHDDLzECcN1GndskhM0v4XRGbyXnG94PTP odeKyD10rK1zapbbaOYlGGLOji88udgwU4wzekUJeOKD0MS/8C2rXOW1FIa40TJkIN/o HjZ97+uFO/n4N5C8VE9la4uYkAeGM805tKwxlRdM3uCSMnsScImC0+nGyZLcRAakf+gY Ah8LqzLYOc0vFKJ7c/g7b1Ya62kZ3Ip9dRS8ofmjfjurDtLLpYwCW15H9+LrcFmtOFLI adWg== X-Gm-Message-State: AOJu0YxZOPAXVXdwTIALC3qpHEwYy5/3qgx+s6joIzrlirt8tm0FTQTK 30/yP4n8K6BRbl0hBYNZIBUJDRxKQfsHzH4V4WXmyyo1fS8= X-Google-Smtp-Source: AGHT+IGGup7+9nCODE0avr3p05LKIhwtmDPtj2QmhNW9HCgqFKjaeCv1Ryb6+COcNmIBZKikEF8ZFTWF9XTwUUdkPt4= X-Received: by 2002:a05:6870:1703:b0:1f9:e8b5:756 with SMTP id h3-20020a056870170300b001f9e8b50756mr1817288oae.11.1702268421430; Sun, 10 Dec 2023 20:20:21 -0800 (PST) MIME-Version: 1.0 References: <20230221223555.102670-1-leo.izen@gmail.com> <14122ab6-072a-6a53-0938-7f9e07270495@gmail.com> In-Reply-To: From: Kacper Michajlow Date: Mon, 11 Dec 2023 05:20:10 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: > > On 2/27/23 11:34, Leo Izen wrote: > > On 2/21/23 17:35, Leo Izen wrote: > >> These chunks are lightweight and it's useful information to have when > >> running ffmpeg -i or ffprobe, for example. > >> --- > >> libavcodec/pngdec.c | 136 ++++++++++++++++++++++------------- > >> tests/ref/fate/png-icc | 8 +-- > >> tests/ref/fate/png-side-data | 2 +- > >> 3 files changed, 91 insertions(+), 55 deletions(-) > >> > >> diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > > > > I will push this soon-ish if there's no other objections. > > > > - Leo Izen (thebombzen) > > > > > > Pushed as fadfa147f812a3fe9e68723347d37b9cccd6222d. Hi, Sorry for digging this old patch, but I'm curious. What does "unsupported tv-range cICP chunk\n" and "we only support pc-range RGB" mean? Before this patch the range was properly set: avctx->color_range = f->color_range = s->cicp_range == 0 ? AVCOL_RANGE_MPEG : AVCOL_RANGE_JPEG; Now it is ignored with a warning. Neither commit message, nor the comments in the code explain why the cICP range is now ignored in the decoder and the frames are no longer tagged with proper color range. As I understand the goal of the commit was to expose colorspace info when AVDISCARD_ALL. Was cICP range change intentional? Thanks, Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".