From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A2D0245AB7 for ; Sun, 14 May 2023 23:28:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8DAB368BF06; Mon, 15 May 2023 02:28:49 +0300 (EEST) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 830B268B680 for ; Mon, 15 May 2023 02:28:42 +0300 (EEST) Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-395a957a310so813573b6e.0 for ; Sun, 14 May 2023 16:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684106921; x=1686698921; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=t4ti88AczBUdZeZaeSidUhwTysAXaEo4vtolFA4c9fk=; b=I1yWg0CZbO2yFX3AbejMKdDORPDvnwH/9YHvcZjM++PR4Tf1m+QEehPiXSr5sEwuwZ E2CWk/VPEX5YCrpvUP5L7Hea+pnZl+OkPU5awAWi1i9yRCDeJAnHltwA0HolGYtEDTbz anh7iAQZQ3Usn5caTwSvG15N3VN7ENmeKFikBuk8WrUythj12Jr9hTo2B0Ju4j1JJMNf eHqwmIMXmZ7DljgCCZebIgYmVU0IG4uUgzmGKLE19qU1Npl0bYH1QbENwsEzAq6fVHuO KE05P+fLN7HXI6u5kJ9cQhWIJqGh7oQKMUmiaZRo+kr+s2gjC0QPhHfZRajEtyNXgnU3 Yr9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684106921; x=1686698921; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t4ti88AczBUdZeZaeSidUhwTysAXaEo4vtolFA4c9fk=; b=Mg7S73igETmqpg5ttm9q8KXezCJPDcG686iz3dn3NbaZYZqM4bX/XslJ1XzfRMZzCm srIjcK+DemY2stAeEJqBY9KunThh2XHL7ecQa24Tr5SEgwkvkrndSN2oCm5KZQNtlV29 LxHnEYcY61i9TJ66n9mCu9/WJ9eAWq2zdllAYGiMkLGDF/gpFk4fasj/MwqddMn6ssuR OC2WJCxpNxJxmSsw6iurgLvdKEImw5+Fzb4TntXKJMz66cmPsT4ZD0M5H1xYjFpV4dO0 D2STiXDAqQvDAM0qZKISchIGtc/+5y6pseea8rArGmJcI522T5MJQ20kTOH9B8ldIRtj TF7Q== X-Gm-Message-State: AC+VfDxRc47z2iawaPFGwxUNF9buVn3smbtk90Ca9NuANaQKdyHQNlrK 5LhSGF+2/DDsb6h+PWHaWCphPlW+YXON/lemt5SjQ3qqlZk= X-Google-Smtp-Source: ACHHUZ4A3tvnYgCoctV16kIYERPGrIx1TNSVs3tEDt9j7lFBcjdtsLqJrDMGNh9tS1SWuSqKIB7qShtB2vUj34q7R0g= X-Received: by 2002:a05:6808:2781:b0:38d:e3b7:7f14 with SMTP id es1-20020a056808278100b0038de3b77f14mr10037031oib.44.1684106920752; Sun, 14 May 2023 16:28:40 -0700 (PDT) MIME-Version: 1.0 References: <20230514194129.18840-1-anton@khirnov.net> <20230514213944.GK1391451@pb2> <20230514230617.GL1391451@pb2> In-Reply-To: <20230514230617.GL1391451@pb2> From: Kacper Michajlow Date: Mon, 15 May 2023 01:28:33 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 15 May 2023 at 01:06, Michael Niedermayer wrote: > > On Mon, May 15, 2023 at 12:40:50AM +0200, Kacper Michajlow wrote: > > On Sun, 14 May 2023 at 23:39, Michael Niedermayer > > wrote: > > > > > > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote: > > > > This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which > > > > broke many streams in the wild > > > > > > > > Fixes #10353. > > > > > > This change violates a SHOULD in rfc8216 4. Playlists > > > > > > Each Playlist file MUST be identifiable either by the path component > > > of its URI or by HTTP Content-Type. > > > > either/or > > > > > In the first case, the path MUST > > > end with either .m3u8 or .m3u. > > > > First case, path component with valid extention. > > > > > In the second, the HTTP Content-Type > > > MUST be "application/vnd.apple.mpegurl" or "audio/mpegurl". > > > > Second (OR) case for URI with Content-Type. > > > > So current FFmpeg HEAD violate RFC, as it should allow URI with Content-Type. > > yes, code is buggy, i didnt see teh report before today night, > and was doing too much non ffmpeg crap last 2-3 days so didnt see it before > > everyone is upset, noone mailed me, noone posted a good fix, noone reverted > > ill post something before going to sleep today probably but i likely > wont have the time to properly test it before bed > (testcases with ffmpeg / ffplay btw makes it easier to test than with > links to random webpages) > > thx > All good, take your time. I just wanted to clarify that current implementation is too strict/buggy. I think the upset comes from the fact that a lot of users started flooding issue trackers with the complaints that their favorite live stream doesn't work. And while the underlying issue is quite small regression, there were uncertainty at first what is going on and a lot of unnecessary comments and remarks were made. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".