Re: [FFmpeg-devel] [PATCH 1/2] configure: don't force specific C++ standard library linking

[Kacper Michajlow <kasper93@gmail.com>]

On Wed, 6 Sept 2023 at 00:17, Hendrik Leppkes <h.leppkes@gmail.com> wrote:
>
> On Wed, Sep 6, 2023 at 12:14 AM Kacper Michajłow <kasper93@gmail.com> wrote:
> >
> > Other C++ standard libraries exist. Also, this is not a proper way to
> > link the standard library anyway. Instead when a C++ dependency is
> > detected, switch to the C++ compiler driver to properly link everything.
> >
> > Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> > ---
> >  configure | 27 ++++++++++++++++++---------
> >  1 file changed, 18 insertions(+), 9 deletions(-)
> >
> > diff --git a/configure b/configure
> > index bd7f7697c8..90ee6e4f7d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3584,11 +3584,9 @@ bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr
> >  caca_outdev_deps="libcaca"
> >  decklink_deps_any="libdl LoadLibrary"
> >  decklink_indev_deps="decklink threads"
> > -decklink_indev_extralibs="-lstdc++"
> >  decklink_indev_suggest="libzvbi"
> >  decklink_outdev_deps="decklink threads"
> >  decklink_outdev_suggest="libklvanc"
> > -decklink_outdev_extralibs="-lstdc++"
> >  dshow_indev_deps="IBaseFilter"
> >  dshow_indev_extralibs="-lpsapi -lole32 -lstrmiids -luuid -loleaut32 -lshlwapi"
> >  fbdev_indev_deps="linux_fb_h"
> > @@ -4684,7 +4682,6 @@ msvc_common_flags(){
> >              -march=*)             ;;
> >              -lz)                  echo zlib.lib ;;
> >              -lx264)               echo libx264.lib ;;
> > -            -lstdc++)             ;;
> >              -l*)                  echo ${flag#-l}.lib ;;
> >              -LARGEADDRESSAWARE)   echo $flag ;;
> >              -L*)                  echo -libpath:${flag#-L} ;;
>
> Should probably keep this one, it may come from a pkg-config file or
> some other source, and you don't want it forwarded to cl.exe
>
> - Hendrik

Fair point. Doesn't harm to keep it I guess. Although on Windows a lot
of unsupported things may come from .pc files. In general pkg-config
on Windows is tricky.

I've sent a new version of the patch.

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".