From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5DDF94C903 for ; Thu, 15 Aug 2024 00:59:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A88968DAC2; Thu, 15 Aug 2024 03:59:23 +0300 (EEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BDFA468C2B8 for ; Thu, 15 Aug 2024 03:59:17 +0300 (EEST) Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52f01afa11cso499590e87.0 for ; Wed, 14 Aug 2024 17:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723683556; x=1724288356; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=zvMVwDFflvsnAmQatkkO804CNxSlwxIvROj+1lxRJ9U=; b=a6gCj5qqrBmhhnv7frX5BaH5VXkm7UVKw3HK0XqIvqlskJWdWAURkorlElWh5uBuD+ xs1OJmCOP5iwbPntVQGpNxcfvXgf4WrcEmbHUu5RHaXcC28kCtg5FTQBXP7bhg80Wbcg /kik14s4lXaqEimiGxaWauv/yYBswUuvqyzwBAA85+XKHfYAmXrvlICRfn8DqyImHzNm im169tn2lfrfDHQUZQ/ni/TfhOqjRW/XHhdpxPvdTAMpzTxbQw+ydSD8hmCQ0RSA8jSr 1eaNfxqAKbHbGNLKcXAU4NKfMwOAxRC3YtpnjPjS2HoOQshEqKfLjgMmjyQK60MtJ4KM X0sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723683556; x=1724288356; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zvMVwDFflvsnAmQatkkO804CNxSlwxIvROj+1lxRJ9U=; b=l5NPpXp/pC0HrVKzLi4nC+l7rMXZvKExqSPvGCJ8VrJKSG1BwzDiGOzmiULoEW2xSj /Zk5H16RfXXA5kqdaMzKNoV19Sk5sbMItiSBkWq6P0IbMsRJzYvMxWSIBgAKPDJukqZe RXIgVudkxgfDXAIXn1DbAfeOm6AhzXGR+hT5h4AX+0BZyilGy8puLP2NfleZeske83lf vxdadSw8vPhds6Q2PONSvf5yKBBiX/QXwaWkwUpwgmF+AECt68fdCA961vtalUCUMkun E/zb8UYxDXnuHpcdJv9fuM0VOEUoWIrULLX5jkTCPWrX0/bs1C7OOor1/GCIiD3hmcYz HCjA== X-Gm-Message-State: AOJu0YyqlisFtwzsNVvLxHWLlwEQOfhNerjBtJqvpWu9BgY6exUKwca/ a3lHQqZ3TDaFC9OfOVVj3TH/n2BacywO0uPQ8NupTmRrc/Mq3Ehu+cnwQ9wXvTJuJRlHpOByzhF VSaqT7rMDYFk3M6c24jXNNiLLNgnADW8ded8= X-Google-Smtp-Source: AGHT+IG69Ucvxl61Opqt7j35DajK6mCsc+d7FGZ2tJ9KGY/ZbpYFGsLRS2O+A+eLntF3ectayyM2ZiIA4AKkYdzjOy4= X-Received: by 2002:a05:6512:3c9c:b0:530:e1f6:6eca with SMTP id 2adb3069b0e04-532edbad9b1mr2685940e87.37.1723683556225; Wed, 14 Aug 2024 17:59:16 -0700 (PDT) MIME-Version: 1.0 References: <20240603021526.2372698-1-michael@niedermayer.cc> <20240603021526.2372698-9-michael@niedermayer.cc> In-Reply-To: <20240603021526.2372698-9-michael@niedermayer.cc> From: Kacper Michajlow Date: Thu, 15 Aug 2024 02:59:05 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 9/9] avformat/mov: Use int64_t in intermediate for corrected_dts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 3 Jun 2024 at 04:16, Michael Niedermayer wrote: > > Fixes: CID1500312 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index d15b7b70c50..93643304212 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -3386,7 +3386,7 @@ static int mov_read_stts(MOVContext *c, AVIOContext *pb, MOVAtom atom) > sc->stts_data[i].duration = 1; > corrected_dts += (delta_magnitude < 0 ? (int64_t)delta_magnitude : 1) * sample_count; > } else { > - corrected_dts += sample_duration * sample_count; > + corrected_dts += sample_duration * (int64_t)sample_count; > } > > current_dts += sc->stts_data[i].duration * (int64_t)sample_count; > -- > 2.45.1 This is not enough to guard the overflow, the addition can still overflow. mov.c:3500:27: runtime error: signed integer overflow: 3206437752653027430 + 8549083172438480532 cannot be represented in type 'int64_t' (aka 'long') - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".