From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 967974F236 for ; Mon, 16 Jun 2025 22:43:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5CF6368C4B3; Tue, 17 Jun 2025 01:43:54 +0300 (EEST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 512A368BFBA for ; Tue, 17 Jun 2025 01:43:47 +0300 (EEST) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-606b6dbe316so10673274a12.3 for ; Mon, 16 Jun 2025 15:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750113826; x=1750718626; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+BZEOoRzuH+1PaK+cb/jXtZXXQOr7CypEixVvSbgtbs=; b=Wy9N5hvf8fOTuwa+QrByKdePvZOogICmvBrw7wn78tAN5HSk/b7WuCmEhbSzG667Ef RvB04gSzEpXCKNH7x4GKvaufiFQHh1J0MbJcY6SsJtgJOCkaTr1QIwl8voP/vMJo2/HL kA7gDi9tqEJaNhgGPSTx+ECKZ/aGDDHHETyT+illiUGtRsOnLfPtDBexxCb8KN1Y/761 j5wA/cIwugwYdGofkjG+LcJLbdmTZbr3NIIjoOS961gr60goDwnNMk8XFI3WOqxwFgmX AyMQT48RIY5w1YsuRY/xlj6WiWW76Z3AQfd8E7blX8HhGnD685vkIZ5AzXKuqf7jhQnw TBtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750113826; x=1750718626; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+BZEOoRzuH+1PaK+cb/jXtZXXQOr7CypEixVvSbgtbs=; b=hWtI6QoPR5vhhjVqY1JkTgY6Z8JtiFKKNx5KQ+cwtNuCWs3Iy4ZzxMHiFPD5kwrvkL IVhJNdYpzvTsOFllbCcmc1wQV/aboZCb+gXp64yqH0J6tg7OnyFkwsFtVXcyLB3C+jFm oN1NvVXiRAKpkCE+zkd2cwBGQs4DVGaT8eHmTkrSwUwoiezto0X2tUxC1gspM2rJT+53 CXF0s6Aj6z2pYu+zM+HRKmmhW4Q+mFtsPU9wLYIMb/HuYurPvN0LBopJ4tc+EguOCfnV 5nqRNM+MML+jLZ+cGk02txpq04FUIyMAFc75xCmNw/1FKV7lsVSw+tWaBjjeebevg0Wb 9Egw== X-Gm-Message-State: AOJu0YxgLBPUwS5Bf0T73UHxbSxrqvms7LIGvEZNq9FHAtAOV0ZIdjec /iZqnm0BTveB96pCsAmi5VfRxPMI3vzOBiL0sGBAQ/Z3QvMgR4N75TJvFVK3i6iY9DHlvZsfRNm usrRO/4i7eg/Wgzi1FM7BMCxGM42SCp48xg== X-Gm-Gg: ASbGnctSdXFE9T5+pXoGOvg5DvSskJtuxjhpoo4uTRbN57gmMXK/JfFrcrFa0SoLQOU sqs7fKD5I9nr7uXG8KNLAIWFBrNQTtWLA11Ik5wbD28mgy8pcEgsyuXXTJkazcpdkzTSZ6gdGpk JqlAq8dOggE4VDzP3A2i4p8ORS5L4+NETJLdpU0xrI X-Google-Smtp-Source: AGHT+IFbDiBRBZAWG3LGkXrl9PPWqyAdkVgxTI/fb3tu2tpicVwa94K6uUjJRKn+yDcnok6ZDqpNMomyj9slbI/EuRA= X-Received: by 2002:a05:6402:28ae:b0:5f6:fab2:9128 with SMTP id 4fb4d7f45d1cf-608d09609fdmr7338297a12.19.1750113825515; Mon, 16 Jun 2025 15:43:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kacper Michajlow Date: Tue, 17 Jun 2025 00:43:35 +0200 X-Gm-Features: AX0GCFuBi1TEKg-G353KvIW7-HGXCLiN3jFugEVsqY_NO6I_cViwTA3Y2cfUWJE Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 12 May 2025 at 12:00, ffmpegagent wrote: > > When setting up the new Patchword builders I noticed some issues when > running FATE tests on Windows. Initially I had them suppressed on the > builders, but this patchset should finally fix it. > > softworkz (3): > tests/fate: Fix subtitle fate tests on Windows > tests/source-check: Fix make inclusion-guard check EOL-agnostic I think ffmpeg repositories should always be checked out with LF line endings, there is nothing that expects those sources to have CRLF. If you like you can set attributes to all files to LF (not only subs), but essentially this should already be done by the user when checking the repository. (autocrlf should be considered harmful, the was bad idea to make git tooling smarter for its own good) > tests/hevc: Fix concat input when running in MSYS2 shell This is more tricky, but frankly, I don't like injecting platform specific workarounds into makefile files like that. Either maintain it yourself or do it in a more generic way, not just in one hevc test, because what if someone else adds a concat test? Do you expect them to know that some MSYS2 specific handling is needed? It shouldn't be. Also if you like to fix "fate paths", it should be done fully. Currently only relative paths are working, because some tests are doing things like "$(input)[bla]" which also trips patch conversion, so full unix path doesn't work, because it won't get converted to Windows one, Windows path doesn't work, because it would be mangled because of not escaped `\`. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".