From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F5F147D6C for ; Sun, 24 Dec 2023 10:42:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7516A68D152; Sun, 24 Dec 2023 12:42:10 +0200 (EET) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9ED8868CDE3 for ; Sun, 24 Dec 2023 12:42:04 +0200 (EET) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-2041064831bso2311407fac.3 for ; Sun, 24 Dec 2023 02:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703414523; x=1704019323; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=EQKo+3cuq996k5Us5G3783J5meIUbvOsPzv7HVlQ9lk=; b=f9sYzMteRC6Hemd1lJY5KiBd2H3N09kvSHadRBM74T1DtbWkXP5esZtaZUNbOdMnhW ZKR36mH9JWPgfRGeNFd4CeUaanxx8+Q3/tF7YdOTBl+qaOf2kLTVIRLCDaSiaFo2QZnc jQr25Vn1glbcvMj3w1iUpOziXRli8aoKiWxrqfgx/ARFnnGtJWD5P5ZFVeAh0sjyEH1q U4fDzDBPOza0oj9U18FRMwH9vfABZGw6zGkURDyGbP1suLz+x9MTklf4uw1ggqt8JqfY 6B0RMJg7fizb7nbhaYEDoQhNVjaMRhLXeokixnNhY25TIy3PWr2wh2OlJY7l67eQnk5C ruSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703414523; x=1704019323; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EQKo+3cuq996k5Us5G3783J5meIUbvOsPzv7HVlQ9lk=; b=biaUADEf3vhWx0kodBRRdGDdKebgiDRsh4osDvN+qpIWXoSI3HtxztCElQU8MIrYtp z66trBzhcRXSQbWXqbbs4wi2gSNe6EOuqrIVYy6in0BLAhdg2Opymjo0iD7ldHU/53Gk 08SZxKwkVv7Mo0uEyTjB5iO5aTZUr4DRy/SZRwy602xNRWJJDkCsB7P0t9yIWIVOkKP7 dNM2E7Y+dvmo207SDxtQiKk6li3e45WeKX8uSeCcwvBvdyaLHBO1bTh4KCzSNgUqpASi 6jaCSrijE4NA5UN8HMFlL/OfrKu4jHb1au9OcqYpUQpvauL5kMDsmH1YMGhy2bohlNId 1v7w== X-Gm-Message-State: AOJu0YxlpW0NZBlb7j8uF53vVQT0o6gMNW2JdqdaNOGcvxNr1tFyVW3f TPCEa2Egg5uaeOPrJg/yehyxYjU18dY5/cfyYFI9ZmX6mFY= X-Google-Smtp-Source: AGHT+IG5bJ7K3NfxbUkmrxtKkfcHPKH32MUytvIQpA4wlL1vdHmAQg8WcJXwN1H/P4aJqWSEDcvBa8r5JauEm6bFLfk= X-Received: by 2002:a05:6870:96ac:b0:203:90ab:c17 with SMTP id o44-20020a05687096ac00b0020390ab0c17mr4533830oaq.95.1703414522608; Sun, 24 Dec 2023 02:42:02 -0800 (PST) MIME-Version: 1.0 References: <170325346626.8914.9027885551787528867@lain.khirnov.net> In-Reply-To: <170325346626.8914.9027885551787528867@lain.khirnov.net> From: Kacper Michajlow Date: Sun, 24 Dec 2023 11:41:52 +0100 Message-ID: To: FFmpeg development discussions and patches , Andreas Rheinhardt Subject: Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > > Avoids relocations. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > Maybe mention that it's not needed after > acf63d5350adeae551d412db699f8ca03f7e76b9. This is not the only user of this API, no? I have a question for my own curiosity. This is ABI (and API) breaking change, shouldn't there be a documentation change to indicate this item_name function pointer can be null now? Or otherwise a way to indicate that this should be updated in client applications? It is easy fix, but it is kinda surprising to break over 14 year old code like in mpv, see: https://github.com/mpv-player/mpv/pull/13154 - Kacper > LGTM otherwise. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".