From: Kacper Michajlow <kasper93@gmail.com>
To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>,
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value
Date: Sun, 24 Dec 2023 11:41:52 +0100
Message-ID: <CABPLASQcqzqM-oyaTREqvpuW5r4MJqs2tBAsb8uQW5mFD39yhA@mail.gmail.com> (raw)
In-Reply-To: <170325346626.8914.9027885551787528867@lain.khirnov.net>
On Fri, 22 Dec 2023 at 14:57, Anton Khirnov <anton@khirnov.net> wrote:
>
> Quoting Andreas Rheinhardt (2023-12-22 14:48:45)
> > Avoids relocations.
> >
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> > ---
>
> Maybe mention that it's not needed after
> acf63d5350adeae551d412db699f8ca03f7e76b9.
This is not the only user of this API, no?
I have a question for my own curiosity. This is ABI (and API) breaking
change, shouldn't there be a documentation change to indicate this
item_name function pointer can be null now? Or otherwise a way to
indicate that this should be updated in client applications?
It is easy fix, but it is kinda surprising to break over 14 year old
code like in mpv, see: https://github.com/mpv-player/mpv/pull/13154
- Kacper
> LGTM otherwise.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-24 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 13:48 Andreas Rheinhardt
2023-12-22 13:57 ` Anton Khirnov
2023-12-24 10:41 ` Kacper Michajlow [this message]
2023-12-25 8:38 ` Anton Khirnov
2023-12-25 9:27 ` Zhao Zhili
2023-12-25 10:21 ` Anton Khirnov
2023-12-25 10:47 ` Zhao Zhili
2023-12-27 14:19 ` Kacper Michajlow
2023-12-28 23:42 ` Marton Balint
2023-12-29 2:01 ` Zhao Zhili
2023-12-22 15:11 ` Rémi Denis-Courmont
2023-12-22 16:13 ` Andreas Rheinhardt
2023-12-22 16:20 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPLASQcqzqM-oyaTREqvpuW5r4MJqs2tBAsb8uQW5mFD39yhA@mail.gmail.com \
--to=kasper93@gmail.com \
--cc=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git