From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4A83D4E2CC for ; Sun, 8 Jun 2025 10:31:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3568668BDE5; Sun, 8 Jun 2025 13:31:03 +0300 (EEST) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D363A687C4E for ; Sun, 8 Jun 2025 13:30:55 +0300 (EEST) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-60700a745e5so3872789a12.3 for ; Sun, 08 Jun 2025 03:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749378653; x=1749983453; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=OEMeJUM8AGasBD/DrivcsLx3d6UelFenZc54qUtLS/I=; b=FOkEGPbKrswI8PnbJT2g9BBEo9vTW2Vf9ZYu8l2qmyudgr2fyTYIedh9N+woAsCooP 0y6uLuaMz6Y9qKpE4e8XppCj7Iweh0+rmrQaMyw7z1UuehO4gEx9S7oO2FvHxDPKrm5d uC4OryACSonVyB0pAOuWK3waMgXmfxi5SBjLFL1RNwzY1l/sdq0RG0suD2LrYFKDjWHc BSA1bTY3WjyHorREhsZA+CiaIzAvRWwpysjTAerM3ri/kpV8Aqt9OyvjopYtmbPKSL7X YsoWSr/qYjzgczh+OE82ZEYr/YGAUayQF24wyN9OLJITlmoS7gY1Z0ezOHitbMXBHtsd qDNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749378653; x=1749983453; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OEMeJUM8AGasBD/DrivcsLx3d6UelFenZc54qUtLS/I=; b=Ec0S/N9A+eMUQkf93IJ1OToEv59VxCGcGEqVh1Xb08sgljchVFoDGDWg3G/dxtDnhq zOcp6MpqYaCjoZANGQheulN5vRlWUZp7Fk1Y1FlYkeZ0M6T2himUavp36FXGsJShj03t 0DKKsFQQX5oj0e2oLWk6lJh6Wf3Ao074mnJaKx9zt+E9Fd5N8fXWmCv8H0VueJQiSQvH H8SFRLp8hErNTOAAFs6t9EqalP1dG8NOCt4wGFwN4IQ4xZzB8zOh6CY4+6hFqqahgdFs 0PxRJOEXNaUT98CwaDWUQV+ZyKZq0gLs3Nb5ON0GCVX+7wYyGFPTQYUjvOVR0HjOQqdL G7Aw== X-Gm-Message-State: AOJu0YzZVr3QDPQDfLtotAB3UV6d6r0ZQXT2TNd2FiU5GKvEug5kBoz3 4pg7Nqun7BzK4RtxxW1mJWYHP+8FKIWF/pmzkxJteoxAmCjoE1Q9cAkeCcv+dJgvMdLPJL7cWFv 01Kl5OSb+iG1XBPwIwehY1OoHi3197uw7U0f1 X-Gm-Gg: ASbGncuq/A5+GftqKGzur9KnaLP2uW9KL10qLTaGuwVgSdgNs/fV6R5Wu+gaevteLdz dSOazbZ50OauziRiFLx0G2ai3XROInOOtooBHhlqnxE3Nou11lzwNkHqO7ZAFLiXse5vSMhrGPS 2R56gr5JtgSrHQK/jcOLWJBLinmgaBzjlR77R9STTdU1pIhnuW9Yk= X-Google-Smtp-Source: AGHT+IFgCUtiV4/6TFaiEeBq9cVRDDqqfIUAulwCV1KflyQXmPI1QGUSC0bmL1a+ncnDPk1thjcoM8PdDlSBxuQDzVo= X-Received: by 2002:a05:6402:350e:b0:5e6:17e6:9510 with SMTP id 4fb4d7f45d1cf-6077341892cmr7991236a12.6.1749378653401; Sun, 08 Jun 2025 03:30:53 -0700 (PDT) MIME-Version: 1.0 References: <20250604102315.38134-1-ffmpeg@haasn.xyz> <20250604102315.38134-6-ffmpeg@haasn.xyz> In-Reply-To: <20250604102315.38134-6-ffmpeg@haasn.xyz> From: Kacper Michajlow Date: Sun, 8 Jun 2025 12:30:41 +0200 X-Gm-Features: AX0GCFsTeFQ0Nw3YuSvTZEiIz_fkfsAnY1qzf6x3O4VmH76CMyPRe9V4f1bCLKY Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v4 05/17] swscale: add SWS_UNSTABLE flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 4 Jun 2025 at 12:24, Niklas Haas wrote: > > From: Niklas Haas > > Give users and developers a way to opt in to the new format conversion code, > and more code from the swscale rewrite in general, even while development is > still ongoing. > --- > doc/APIchanges | 3 +++ > doc/scaler.texi | 4 ++++ > libswscale/options.c | 1 + > libswscale/swscale.h | 7 +++++++ > libswscale/version.h | 2 +- > 5 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 91710bb27d..ae5e4b366b 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2025-03-28 > > API changes, most recent first: > > +2025-04-xx - xxxxxxxxxx - lsws 9.1.100 - swscale.h > + Add SWS_UNSTABLE flag. > + > 2025-05-21 - xxxxxxxxxx - lavu 60.3.100 - avassert.h > Add av_unreachable() and av_assume() macros. > > diff --git a/doc/scaler.texi b/doc/scaler.texi > index eb045de6b7..42b2377761 100644 > --- a/doc/scaler.texi > +++ b/doc/scaler.texi > @@ -68,6 +68,10 @@ Select full chroma input. > > @item bitexact > Enable bitexact output. > + > +@item unstable > +Allow the use of experimental new code. May subtly affect the output or even > +produce wrong results. For testing only. > @end table > > @item srcw @var{(API only)} > diff --git a/libswscale/options.c b/libswscale/options.c > index feecae8c89..06e51dcfe9 100644 > --- a/libswscale/options.c > +++ b/libswscale/options.c > @@ -50,6 +50,7 @@ static const AVOption swscale_options[] = { > { "full_chroma_inp", "full chroma input", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_FULL_CHR_H_INP }, .flags = VE, .unit = "sws_flags" }, > { "bitexact", "bit-exact mode", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_BITEXACT }, .flags = VE, .unit = "sws_flags" }, > { "error_diffusion", "error diffusion dither", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_ERROR_DIFFUSION}, .flags = VE, .unit = "sws_flags" }, > + { "unstable", "allow experimental new code", 0, AV_OPT_TYPE_CONST, { .i64 = SWS_UNSTABLE }, .flags = VE, .unit = "sws_flags" }, > > { "param0", "scaler param 0", OFFSET(scaler_params[0]), AV_OPT_TYPE_DOUBLE, { .dbl = SWS_PARAM_DEFAULT }, INT_MIN, INT_MAX, VE }, > { "param1", "scaler param 1", OFFSET(scaler_params[1]), AV_OPT_TYPE_DOUBLE, { .dbl = SWS_PARAM_DEFAULT }, INT_MIN, INT_MAX, VE }, > diff --git a/libswscale/swscale.h b/libswscale/swscale.h > index b04aa182d2..4aa072009c 100644 > --- a/libswscale/swscale.h > +++ b/libswscale/swscale.h > @@ -155,6 +155,13 @@ typedef enum SwsFlags { > SWS_ACCURATE_RND = 1 << 18, > SWS_BITEXACT = 1 << 19, > > + /** > + * Allow using experimental new code paths. This may be faster, slower, > + * or produce different output, with semantics subject to change at any > + * point in time. For testing and debugging purposes only. > + */ > + SWS_UNSTABLE = 1 << 20, Add this flag also in the list in target_sws_fuzzer.c, so it will be tested after merge. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".