Re: [FFmpeg-devel] [PATCH v4 05/17] swscale: add SWS_UNSTABLE flag

From: Kacper Michajlow <kasper93-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 05/17] swscale: add SWS_UNSTABLE flag
Date: Sun, 8 Jun 2025 12:30:41 +0200
Message-ID: <CABPLASQQXj_N-FTnOFt73dX+Q7YZEGsES5Uxvsnv8Keead61GQ@mail.gmail.com> (raw)
In-Reply-To: <20250604102315.38134-6-ffmpeg@haasn.xyz>

On Wed, 4 Jun 2025 at 12:24, Niklas Haas <ffmpeg@haasn.xyz> wrote:
>
> From: Niklas Haas <git@haasn.dev>
>
> Give users and developers a way to opt in to the new format conversion code,
> and more code from the swscale rewrite in general, even while development is
> still ongoing.
> ---
>  doc/APIchanges       | 3 +++
>  doc/scaler.texi      | 4 ++++
>  libswscale/options.c | 1 +
>  libswscale/swscale.h | 7 +++++++
>  libswscale/version.h | 2 +-
>  5 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 91710bb27d..ae5e4b366b 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2025-03-28
>
>  API changes, most recent first:
>
> +2025-04-xx - xxxxxxxxxx - lsws 9.1.100 - swscale.h
> +  Add SWS_UNSTABLE flag.
> +
>  2025-05-21 - xxxxxxxxxx - lavu 60.3.100 - avassert.h
>    Add av_unreachable() and av_assume() macros.
>
> diff --git a/doc/scaler.texi b/doc/scaler.texi
> index eb045de6b7..42b2377761 100644
> --- a/doc/scaler.texi
> +++ b/doc/scaler.texi
> @@ -68,6 +68,10 @@ Select full chroma input.
>
>  @item bitexact
>  Enable bitexact output.
> +
> +@item unstable
> +Allow the use of experimental new code. May subtly affect the output or even
> +produce wrong results. For testing only.
>  @end table
>
>  @item srcw @var{(API only)}
> diff --git a/libswscale/options.c b/libswscale/options.c
> index feecae8c89..06e51dcfe9 100644
> --- a/libswscale/options.c
> +++ b/libswscale/options.c
> @@ -50,6 +50,7 @@ static const AVOption swscale_options[] = {
>          { "full_chroma_inp", "full chroma input",             0,  AV_OPT_TYPE_CONST, { .i64 = SWS_FULL_CHR_H_INP }, .flags = VE, .unit = "sws_flags" },
>          { "bitexact",        "bit-exact mode",                0,  AV_OPT_TYPE_CONST, { .i64 = SWS_BITEXACT       }, .flags = VE, .unit = "sws_flags" },
>          { "error_diffusion", "error diffusion dither",        0,  AV_OPT_TYPE_CONST, { .i64 = SWS_ERROR_DIFFUSION}, .flags = VE, .unit = "sws_flags" },
> +        { "unstable",        "allow experimental new code",   0,  AV_OPT_TYPE_CONST, { .i64 = SWS_UNSTABLE       }, .flags = VE, .unit = "sws_flags" },
>
>      { "param0",          "scaler param 0", OFFSET(scaler_params[0]), AV_OPT_TYPE_DOUBLE, { .dbl = SWS_PARAM_DEFAULT  }, INT_MIN, INT_MAX, VE },
>      { "param1",          "scaler param 1", OFFSET(scaler_params[1]), AV_OPT_TYPE_DOUBLE, { .dbl = SWS_PARAM_DEFAULT  }, INT_MIN, INT_MAX, VE },
> diff --git a/libswscale/swscale.h b/libswscale/swscale.h
> index b04aa182d2..4aa072009c 100644
> --- a/libswscale/swscale.h
> +++ b/libswscale/swscale.h
> @@ -155,6 +155,13 @@ typedef enum SwsFlags {
>      SWS_ACCURATE_RND   = 1 << 18,
>      SWS_BITEXACT       = 1 << 19,
>
> +    /**
> +     * Allow using experimental new code paths. This may be faster, slower,
> +     * or produce different output, with semantics subject to change at any
> +     * point in time. For testing and debugging purposes only.
> +     */
> +    SWS_UNSTABLE = 1 << 20,

Add this flag also in the list in target_sws_fuzzer.c, so it will be
tested after merge.

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".