From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EB299407B3 for ; Tue, 17 Jun 2025 15:59:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5BEBA68D4B8; Tue, 17 Jun 2025 18:59:52 +0300 (EEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7FA3568C30B for ; Tue, 17 Jun 2025 18:59:45 +0300 (EEST) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-606fdbd20afso11911396a12.1 for ; Tue, 17 Jun 2025 08:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750175985; x=1750780785; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vZQ7ZPE3cM2rVNJPPSxaJLGRmlVWCftSm9us3nHlgJ8=; b=UHTK4qwYcpbxh/MnFp3gVeRzT24IEd0rToLhHtVRBeh7uJ0+qwiGzRwP1k/lfpTSwh w4ncfXHs591I9dZeMrZBrRjJavHOzGCrzJrkPT2L7FQXpMfJgrqchSPxzZ5JDAKqnBS2 wmWJTrUmOPQfmlRS4oD6bYhFUVGSUKASQRjqIsKT6jk8uvV9opTMZraq5HsI5gjSsdDo lWYN5lyX/xB5Cl3CbscDVbenMwTQqv3oNNQ5lKPM/nnmhFmnJ5VBw9AFuMqMUkwHr1lS Ht9EF9aqjFob0F7cOyQO3ZjrxfCQdT4BLhAONZEFVSRlzduNTMXruWomYSW1UJfz6mtT vXEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750175985; x=1750780785; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vZQ7ZPE3cM2rVNJPPSxaJLGRmlVWCftSm9us3nHlgJ8=; b=g9gYdea839+KzTvc0xHyJc0w7i5kp+JNnCUIoSvOnqw9EaTdrIu5Vgsu9C6S6UPFzf nTU+zoUrkR3qrCx6kVuYCae37ctAm6U6CmH1ipaYR66WNkkNbm7LQBjibjoRobkHEcyT jinQxqwm6OoTGSNseK/mEJrnyG+J4NvAEnhhDiUCIcS7Av3yKGtKtoHEAOn9bZLzA/UI V8xehmz9ztmmprd1EX6m77l03iRgVDIKak5u/8+oB5j62eWjgjfniogatdotE3Wg3PVl MDBvVgecvIfprfPlouaU2h7IyH/k4lzph0Sw3yW52nNLSOBuyhLIytfUMx4Zu34H4bbV 86ng== X-Gm-Message-State: AOJu0Ywvo3zrXyezB0nzMIHRz4h6eV+xfnI0SeRUlgkgCPpqIHoMUT/o JFHWvdPSNfSjY6TIjD9GyuWN2/DuLt1zXf8/fbC5LVv3c+UID9DIIWv4IRY4R2ZvSnvbxVhISVX u7UgS+uV8s47d+FyTklxCWFQOv8LEtrA= X-Gm-Gg: ASbGncv7rAxeFo/4sgaiUbCgXqUgPONfqAMtYTPwYMm+o/WFQ/38BwJ6lXH5AV1ciYA vOg05k7RAN3hsXoy8cMx4S//nKLptTOqIjpsE+Dy1gIe5rAPX0DmTLEC6t0O7C1LG38E4RYSGri 7KWTvGGZuiwCEU3QpVJNl3XjjyeFD6gcIV4kZC0Jyu X-Google-Smtp-Source: AGHT+IE53ir1sgLMilLw93wQrufYAfPp1KGz2+Rh52Qde0jHgWxEXyez/k9CiJcSR6ef6Z5cw6on+T0HzC1gOVW4mzg= X-Received: by 2002:a05:6402:350f:b0:607:2d3b:4827 with SMTP id 4fb4d7f45d1cf-608d09ef402mr12800061a12.30.1750175984493; Tue, 17 Jun 2025 08:59:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kacper Michajlow Date: Tue, 17 Jun 2025 17:59:34 +0200 X-Gm-Features: AX0GCFsaJM9thFySz6SQ_m5Ma5KOjrBW_z3AFUhcf4kPYpa0f2mchq3oA5V8GWc Message-ID: To: "softworkz ." Subject: Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 17 Jun 2025 at 17:29, softworkz . wrote: > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > softworkz . > > Sent: Tuesday, June 17, 2025 4:13 PM > > To: Kacper Michajlow > > Cc: FFmpeg development discussions and patches > devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build > > > > > > > -----Original Message----- > > > From: Kacper Michajlow > > > Sent: Tuesday, June 17, 2025 4:06 PM > > > To: softworkz . > > > Cc: FFmpeg development discussions and patches > > devel@ffmpeg.org> > > > Subject: Re: graph.{html,css} embed failure on Windows build > > > > > > On Tue, 17 Jun 2025 at 15:10, Kacper Michajlow > > > wrote: > > > > > > > > On Tue, 17 Jun 2025 at 04:07, softworkz . > > wrote: > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Kacper Michajlow > > > > > > Sent: Sunday, June 15, 2025 12:49 AM > > > > > > To: FFmpeg development discussions and patches > > > > > devel@ffmpeg.org> > > > > > > Cc: softworkz@hotmail.com > > > > > > Subject: graph.{html,css} embed failure on Windows build > > > > > > > > > > > > Hello, > > > > > > > > > > > > Since the recent addition of resman.c and embedding of > > > > > > graph.{html,css} some of the Windows builds fail. There seems to > > > > > > be a regression in path joining, caused by \ / mismatch. > > > > > > > > > > > > Generally those issues were never a problem and I would prefer to > > > > > > keep it this way. This configuration has always been flaky and > > > undertested. > > > > > > I could set-up a pipeline to report to the fate server if that's > > > > > > something that would help stabilize it. > > > > > > > > > > > > Example of failure: > > > > > > ``` > > > > > > BIN2C fftoolsresourcesgraph.html.c BIN2C > > > > > > fftools/resources/graph.html.c SED fftoolsresourcesgraph.css.min > > > > > > sed: can't read /c/a/FFmpeg/FFmpeg/fftoolsresources/graph.css: No > > > > > > such file or directory SED fftools/resources/graph.css.min > > > > > > make: *** No rule to make target 'fftools\resources\graph.html.c', > > > > > > needed by 'fftools/resources/graph.html.o'. Stop. > > > > > > make: *** Waiting for unfinished jobs.... > > > > > > HOSTCC tests/videogen.o > > > > > > rm fftools\resources\graph.css.min fftools/resources/graph.html.c > > > > > > ``` > > > > > > > > > > > > Note that BIN2C is called twice, once with the correct path and > > > > > > with the wrong one. > > > > > > > > > > > > Removing resman.c fixes the build. This has to be done forcefully > > > > > > in the code, because there is no configure option to disable this > > html/css > > > embedding. > > > > > > > > > > > > You can see the details and whole failing build logs here: > > > > > > code: https://github.com/kasper93/FFmpeg/tree/gha > > > > > > build: > > > > > > > > > https://github.com/kasper93/FFmpeg/actions/runs/15653223193/job/44 > > > > > > 100 > > > > > > 735119 > > > > > > command: $ ../configure --enable-gpl --enable-version3 > > > > > > --enable-nonfree -- samples=../samples --enable-memory-poisoning > > > > > > --arch=amd64 --enable-w32threads --as=clang --ar=llvm-ar > > > > > > --cxx=clang++ -- ld=lld-link --windres=llvm-windres > > > > > > --strip=llvm-strip --cc=clang --nm=llvm-nm --extra-ldflags='msvcrt.lib > > > oldnames.lib' > > > > > > --host_extralibs='' --toolchain=msvc && make -j`nproc` && make > > > > > > -j`nproc` run-checkasm && make -j`nproc` fate-rsync && make > > > > > > -j`nproc` fate > > > > > > > > > > > > Here is exactly the same pipeline with removed graph.{html,css} > > > > > > https://github.com/kasper93/FFmpeg/tree/gha2 > > > > > > https://github.com/kasper93/FFmpeg/actions/runs/15656127992 > > > > > > Builds just fine. > > > > > > Ignore win32 (windows-11-arm, arm64, --toolchain=msvc) failure, as > > > > > > this is affected by unrelated regression in dxvenc.c on arm64 > > > > > > target, but the build itself is passing just fine. > > > > > > > > > > > > Any ideas how we can restore the ability to build ffmpeg on Windows? > > > > > > > > > > Hi Kasper, > > > > > > > > > > I was able to reproduce the issue by adding a new CI build (for PRs > > > > > to ffstaging/ffmpeg (on GitHub, not yet for Patchwork). > > > > > > > > > > It appears to be all about dir separators when building under MSYS2 > > > > > with Clang. Clang insists on using backslashes (unlike GCC and MSVC) > > > > > and that screws the Gnu make logic (pattern rules, dependency and > > > > > up-to-date checks). > > > > > > > > Why is Clang involved in .css conversion rules? It seems to fail at > > > > the `%.css.min: %.css` rule already, which shouldn't involve any C > > > > toolchain related bits. Is this propagated from the .o file? In which > > > > case why does the .o have "wrong" path separators? > > > > > > > > Isn't there an issue in vpath? Maybe we can make it somehow proper > > > > separators. Few days I briefly looked at this, but it wasn't obvious > > > > what would be the correct solution here. Changing vpath to extract > > > > only files in fftools/resources was improving things, but still not > > > > fully. > > > > > > > > Also vpath in fftools/resources/Makefile is setting search path in the > > > > whole SRC_PATH, while imho it should be restricted to the > > > > fftools/resources directory only. > > > > > > > > - Kacper > > > > > > Ok, Martin explained to me on IRC that Windows Clang is generating > > > dependency files with backward slashes, which is then choking because > > Make > > > ingest that, which when not escaped \\ makes paths all go wrong. > > > > > > There is no issue with llvm-mingw or alike, because Clang can be configured > > > during compile time to output forward slashes in dep files. > > > > > > So, probably a solution would be to postproc .d files. But I didn't look at the > > > issue closely, as you can see :) Or make Make work with backward slashes > > > where needed, but this may be tricky to cover all internal matching. > > > > > > Dunno, just wanted to correct my previous message. > > > > Hi Kasper, > > > > thanks a lot for the update. > > I had found this (path in dependency files) as a possible issue from research > > but disregarded it because I had already stopped creation of .d files for > > resources. > > > > BUT - now I realize: That change hasn't even been merged into master yet. > > > > Will run the CI with those changes included and report back. > > > > Thank you, > > sw > > Hi Kasper, > > my already submitted patchset indeed fixes the MSVC-CLang build configuration > which you had reported as failing: > > PR: > https://github.com/ffstaging/FFmpeg/pull/80 > > Build log: > https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=95960&view=logs&j=275f1d19-1bd8-5591-b06b-07d489ea915a > > I will wait for the remaining CI builds to succeed and submit the rebased > patchset to the ML then. > > Please let me know whether it fixes the build on your side as well. Yes, this fixes the build issue. Thanks. Note, I created a pipeline to upload this failing configuration to the fate server. So we have coverage of this config now. Things tend to break if something is not tested. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".