Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

[Kacper Michajlow <kasper93@gmail.com>]

On Wed, 30 Jul 2025 at 19:53, Nicolas George <george@nsup.org> wrote:
>
> Kacper Michajłow (HE12025-07-30):
> > > Note that BIO_get_new_index() can only be used 127 times before it
> > > returns an error.
> >
> > We cannot call it repeatedly, because it will fail eventually.
> >
> > To my understanding the index is not needed in our use and we could
> > safely use BIO_TYPE_NONE. Documentation states:
> >
> > > type can be set to either BIO_TYPE_NONE or via BIO_get_new_index() if
> > > a unique type is required for searching (See BIO_find_type(3))
> >
> > We don't use any search related functions.
>
> This should never have reached the commit message.

Sorry, if the commit description is not formal enough. I'm not native
English speaker, I tend to word things in uncommon ways. I gave
commentary there to excerpts from the OpenSSL documentation.

As for BIO_TYPE_NONE vs BIO_TYPE_SOURCE_SINK, there is no difference
in current or previous versions of OpenSSL, BIO_TYPE_SOURCE_SINK is
not actually used in any meaningful way. I didn't include the 2nd
commit to change to BIO_TYPE_NONE. As the main objective was to fix
regression only and restore the previous status quo is good for now.

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".