From: Kacper Michajlow <kasper93@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header
Date: Fri, 9 Aug 2024 02:38:19 +0200
Message-ID: <CABPLASQ0Cax3ajxAKXZ3NdVPcOwoxmaoZ6u_fPmJhfFbOqJVjA@mail.gmail.com> (raw)
In-Reply-To: <CAEu79SbiFagR+8SpgtjeDKpA4A8LopxH_p5rrkgUnKUvYxZ+qg@mail.gmail.com>
On Fri, 9 Aug 2024 at 00:04, Jan Ekström <jeebjp@gmail.com> wrote:
>
> On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow <kasper93@gmail.com> wrote:
> >
> > Fixes remaining \r\n is ASS header after 57c545090d.
> >
> > Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> > ---
>
> With an initial look this set looks good. If I understand correctly,
> the generic ASS encoder moved to outputting LF only in
> 7bf1b9b35769b37684dd2f18a54f01d852a540c8 and thus these modules which
> still output manual headers with CRLF cause mismatching endlines
> within a single document.
This patchest indeed fixes mismatched endlines, but the main thing it fixes is
libzvbi_teletextdec converter which currently always returns
AVERROR_BUG, because default style no longer matches (after 7bf1b9b35)
the `strstr` expectation.
https://github.com/FFmpeg/FFmpeg/blob/c390234da2e3c7a8884f5592f0b9b4928c482b3e/libavcodec/libzvbi-teletextdec.c#L94
event_pos = strstr(avctx->subtitle_header, "\r\n[Events]\r\n");
if (!event_pos)
return AVERROR_BUG;
- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-08-09 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 20:30 Kacper Michajłow
2024-05-10 20:30 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec/libaribcaption: " Kacper Michajłow
2024-05-10 20:30 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/libzvbi-teletextdec: " Kacper Michajłow
2024-08-08 22:03 ` [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: " Jan Ekström
2024-08-09 0:38 ` Kacper Michajlow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPLASQ0Cax3ajxAKXZ3NdVPcOwoxmaoZ6u_fPmJhfFbOqJVjA@mail.gmail.com \
--to=kasper93@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git