From: Ken McGaugh <ken@mcgaugh.co.uk>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avformat/mov.c: Fix to allow custom udta tags through when export_all option specified.
Date: Sat, 28 Jun 2025 12:46:09 +1200
Message-ID: <CABO4iZPGrV9K8CFmO7F8h+gnoPExdemYc7TbO+Bfdr9zH-Mz2g@mail.gmail.com> (raw)
Hi, first time contributing to ffmpeg so I hope I got this right. We use
custom udta tags in our pipeline but they were not coming through
correctly. Looks like they were incorrectly being routed through the code
path for "raw" data.
---
libavformat/mov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index bd6b23466b..1b17f52a16 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -484,7 +484,7 @@ retry:
return ret;
}
} else return 0;
- } else if (atom.size > 4 && key && !c->itunes_metadata && !raw) {
+ } else if (atom.size > 4 && !c->itunes_metadata && !raw) {
str_size = avio_rb16(pb); // string length
if (str_size > atom.size) {
raw = 1;
--
2.39.5 (Apple Git-154)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-06-28 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 0:46 Ken McGaugh [this message]
2025-06-28 1:51 ` Baptiste Coudurier
2025-06-28 8:04 ` Ken McGaugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABO4iZPGrV9K8CFmO7F8h+gnoPExdemYc7TbO+Bfdr9zH-Mz2g@mail.gmail.com \
--to=ken@mcgaugh.co.uk \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git