From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9858E43329 for ; Wed, 1 Jun 2022 15:13:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 417DA68B6DC; Wed, 1 Jun 2022 18:12:58 +0300 (EEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B37868B6B7 for ; Wed, 1 Jun 2022 18:12:51 +0300 (EEST) Received: by mail-pj1-f43.google.com with SMTP id d12-20020a17090abf8c00b001e2eb431ce4so2384974pjs.1 for ; Wed, 01 Jun 2022 08:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0iXI3J6vEDCAfGPlgYvFiihiZaOOuIDCjriZUzqStos=; b=QzNZ/7unBW3MnGiMf+DAp+woOHDTdvFRiTnIz8+FCOa3UYSdz5w2wGzJ77aQyQQWW0 OYRFd7r9IUvEsIc0Xpm/hXWzOwieO26ItXQ0DdUBXcTDYGubF2a6EkEJh2+k6WBcFish UESZnccTZO2r/CJU7/QoFvZMwyiKtX3OjktbNOtaU7rhte7kJ8qHLFkv4XzWQoqnrJRH Adh5VC5sq4rfmwB9QsAZBkQApHMi0yRQMLX0JCoU3ZnEpwlTMxwpQDDav6Ry8mDPMMCU OMIX5ZlXm7y5LqSlI1aQOrqWKbQKMVrhbWX+MoDGwGlfIeV8QpYoLTiL68c7L5FV7+ZB wlsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0iXI3J6vEDCAfGPlgYvFiihiZaOOuIDCjriZUzqStos=; b=InDHlPm6y2voIikGaDi/2UfRRUs78iUxdbiTiKSmccHPiKZoA2Z1qYpZMBXwtpjRQF fQC8etAG8KtNXRLAJXFINdEgdnkJdAMG76AMa3oaIV4X8DxUTjYTsBaHOL1Xsb6IzIvX rGcxKaRmW88IomApEdmXnQFse7X6n5jeVpPhfpeVAOhLT5lGAtHODbgBbtERuINtaImA dcVqBm7nUmFHS/2LVHXazeUa3crnvJQj7jeTgC0vTK65EQ6pw0Vb+OU1k0iuwkfrhsJA U8E2uEU6lN07+ccIlOn4nEH/mt75vZuJZtthOncetw7KZB9JOQb7bfozdBp7LdSTe6lb +Ufw== X-Gm-Message-State: AOAM531Quaj1qgD+NA4ECRGB4gurs4NO4ho/GpZLgLRcJ6BtCbWUjcjL W5e55aXgDXGTngoCRS7MbyB3lteDRFNU6Izyugl4nZ4jqQq+jg== X-Google-Smtp-Source: ABdhPJyHhkiUiyqZJHa1Q/ljZcsXU2ZHPjqMaZ1l1bwMaRjeIpUnPN3NIjwGgeeJ7G3AWOT6g5T6Cec6KD9YOvGXIjw= X-Received: by 2002:a17:90b:3506:b0:1e0:51a1:a8ee with SMTP id ls6-20020a17090b350600b001e051a1a8eemr112225pjb.112.1654096368850; Wed, 01 Jun 2022 08:12:48 -0700 (PDT) MIME-Version: 1.0 References: <20220519204215.3140970-1-izadi@google.com> In-Reply-To: From: Vittorio Giovara Date: Wed, 1 Jun 2022 17:12:37 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mohammad Izadi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, May 31, 2022 at 7:17 PM Ronald S. Bultje wrote: > Hi, > > On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi < > izadi-at-google.com@ffmpeg.org> wrote: > > > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only > support > > YCGCO as input. Added YCOCG to the inputs. > > --- > > libavfilter/vf_colorspace.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c > > index 3c8b3b20eb..bccd04528e 100644 > > --- a/libavfilter/vf_colorspace.c > > +++ b/libavfilter/vf_colorspace.c > > @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = { > > ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"), > > ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"), > > ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"), > > + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"), > > ENUM("gbr", AVCOL_SPC_RGB, "csp"), > > ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"), > > ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"), > > -- > > 2.36.1.124.g0e6072fb45-goog > > > > Could you elaborate on why you think AVCOL_SPC_YCGCO might be missing from > the LumaCoefficients table? Is this a typo/mixup? Should it be added? > from pixfmt.h AVCOL_SPC_YCGCO = 8, ///< used by Dirac / VC-2 and H.264 FRext, see ITU-T SG16 AVCOL_SPC_YCOCG = AVCOL_SPC_YCGCO, this input option seems redundant, in which use case do you strictly need it? thanks -- Vittorio _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".