[FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

[FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

[Vignesh Venkatasubramanian via ffmpeg-devel]

This is not allowed per the spec.

Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
---
 libavformat/mov.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 294c864fbd..a8f57f9281 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -4892,6 +4892,8 @@ static int avif_add_stream(MOVContext *c, int item_id)
 {
     MOVStreamContext *sc;
     AVStream *st;
+    if (c->fc->nb_streams)
+        return AVERROR_INVALIDDATA;
     int item_index = -1;
     for (int i = 0; i < c->avif_info_size; i++)
         if (c->avif_info[i].item_id == item_id) {
-- 
2.42.0.582.g8ccd20d70d-goog

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

[Vittorio Giovara]

On Tue, Oct 3, 2023 at 7:05 PM Vignesh Venkatasubramanian via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:

> This is not allowed per the spec.
>
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> ---
>  libavformat/mov.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 294c864fbd..a8f57f9281 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4892,6 +4892,8 @@ static int avif_add_stream(MOVContext *c, int
> item_id)
>  {
>      MOVStreamContext *sc;
>      AVStream *st;
> +    if (c->fc->nb_streams)
> +        return AVERROR_INVALIDDATA;
>      int item_index = -1;
>      for (int i = 0; i < c->avif_info_size; i++)
>          if (c->avif_info[i].item_id == item_id) {
> --
>

lgtm
-- 
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".