Re: [FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

From: Vittorio Giovara <vittorio.giovara@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Vignesh Venkatasubramanian <vigneshv@google.com>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF
Date: Tue, 3 Oct 2023 21:33:24 -0400
Message-ID: <CABLWnS_3RkLC1FiV4HyKnd77FeAEDRhCdWW1h=9VWxLHsJW3wg@mail.gmail.com> (raw)
In-Reply-To: <20231003230423.951161-1-vigneshv@google.com>

On Tue, Oct 3, 2023 at 7:05 PM Vignesh Venkatasubramanian via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:

> This is not allowed per the spec.
>
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> ---
>  libavformat/mov.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 294c864fbd..a8f57f9281 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4892,6 +4892,8 @@ static int avif_add_stream(MOVContext *c, int
> item_id)
>  {
>      MOVStreamContext *sc;
>      AVStream *st;
> +    if (c->fc->nb_streams)
> +        return AVERROR_INVALIDDATA;
>      int item_index = -1;
>      for (int i = 0; i < c->avif_info_size; i++)
>          if (c->avif_info[i].item_id == item_id) {
> --
>

lgtm
-- 
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".