Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Vittorio Giovara <vittorio.giovara@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter
Date: Fri, 15 Dec 2023 15:12:24 -0500
Message-ID: <CABLWnS9rE4h51KwVa=gRg7CF7aOu14npE_Z7z8abxz5EeOaHiw@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB0744C078873F26009CB5F0C58F93A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

On Fri, Dec 15, 2023 at 12:34 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> > +static int list_add_frame(FrameList **list, size_t *size, AVFrame
> > *frame)
> > +{
> > +    FrameList *element = av_mallocz(sizeof(FrameList));
>
> The overhead of this FrameList is unnecessary: You can simply use
> AVFrame.opaque as your next pointer.
>

Good tip! Attached an edited version, with all the other suggestions too.
-- 
Vittorio

[-- Attachment #2: 0001-Add-new-vf_tiltandshift-filter.patch --]
[-- Type: application/octet-stream, Size: 21413 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-12-15 20:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  0:51 Vittorio Giovara
2023-12-12  8:00 ` Nicolas George
2023-12-13 10:06   ` Vittorio Giovara
2023-12-15 17:36     ` Andreas Rheinhardt
2023-12-15 20:12       ` Vittorio Giovara [this message]
2023-12-20 19:43         ` Vittorio Giovara
2023-12-20 19:50           ` Nicolas George
2023-12-20 19:56             ` Vittorio Giovara
2023-12-21 21:43               ` Vittorio Giovara
2023-12-22 15:33                 ` Paul B Mahol
2023-12-22 15:40                   ` Ronald S. Bultje
2023-12-22 21:48                     ` Paul B Mahol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABLWnS9rE4h51KwVa=gRg7CF7aOu14npE_Z7z8abxz5EeOaHiw@mail.gmail.com' \
    --to=vittorio.giovara@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git